From: Seth Jennings <sjennings@variantweb.net>
To: Fabian Frederick <fabf@skynet.be>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH 1/1] mm/zswap.c: add __init to zswap_entry_cache_destroy
Date: Sat, 07 Jun 2014 08:56:08 -0500 [thread overview]
Message-ID: <539319fd.22abb60a.05d2.70c7@mx.google.com> (raw)
On Jun 7, 2014 6:08 AM, Fabian Frederick <fabf@skynet.be> wrote:
>
> zswap_entry_cache_destroy is only called by __init init_zswap
>
> This patch also fixes function name
> zswap_entry_cache_ s/destory/destroy
Thanks for the improvement ☺
Acked-by <sjennings@variantweb.net>
>
> Cc: Seth Jennings <sjennings@variantweb.net>
> Cc: linux-mm@kvack.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> mm/zswap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index aeaef0f..ab7fa0f 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -207,7 +207,7 @@ static int zswap_entry_cache_create(void)
> return zswap_entry_cache == NULL;
> }
>
> -static void zswap_entry_cache_destory(void)
> +static void __init zswap_entry_cache_destroy(void)
> {
> kmem_cache_destroy(zswap_entry_cache);
> }
> @@ -926,7 +926,7 @@ static int __init init_zswap(void)
> pcpufail:
> zswap_comp_exit();
> compfail:
> - zswap_entry_cache_destory();
> + zswap_entry_cache_destroy();
> cachefail:
> zbud_destroy_pool(zswap_pool);
> error:
> --
> 1.9.1
>
next reply other threads:[~2014-06-07 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-07 13:56 Seth Jennings [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-07 11:08 Fabian Frederick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539319fd.22abb60a.05d2.70c7@mx.google.com \
--to=sjennings@variantweb.net \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox