From: "Jan Beulich" <JBeulich@suse.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: mingo@elte.hu, linux-mm@kvack.org, tglx@linutronix.de,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
hpa@zytor.com
Subject: Re: [PATCH] improve __GFP_COLD/__GFP_ZERO interaction
Date: Wed, 04 Jun 2014 17:03:30 +0100 [thread overview]
Message-ID: <538F5F720200007800017E73@mail.emea.novell.com> (raw)
In-Reply-To: <538C9E3F.3000403@citrix.com>
>>> On 02.06.14 at 17:54, <david.vrabel@citrix.com> wrote:
> On 02/06/14 15:46, Jan Beulich wrote:
>>
>> --- 3.15-rc8/drivers/xen/balloon.c
>> +++ 3.15-rc8-clear-cold-highpage/drivers/xen/balloon.c
>
> Please split the Xen part out into a separate patch since this is a
> useful cleanup either way.
Actually I'm not convinced the Xen part alone is a good change: By
switching to __GFP_COLD allocations without using suitable special
cased memory scrubbing you'd blow good parts of your data cache
for no good reason, i.e. this quite likely would introduce a
performance regression. Which I wouldn't want to put my name
under.
Jan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-06-04 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 14:46 Jan Beulich
2014-06-02 15:16 ` Kirill A. Shutemov
2014-06-02 15:27 ` Jan Beulich
2014-06-02 15:49 ` Kirill A. Shutemov
2014-06-02 15:54 ` David Vrabel
2014-06-04 16:03 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F5F720200007800017E73@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox