From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by kanga.kvack.org (Postfix) with ESMTP id 034C46B0031 for ; Mon, 2 Jun 2014 03:13:28 -0400 (EDT) Received: by mail-pa0-f53.google.com with SMTP id lj1so2849739pab.40 for ; Mon, 02 Jun 2014 00:13:28 -0700 (PDT) Received: from lgeamrelo01.lge.com (lgeamrelo01.lge.com. [156.147.1.125]) by mx.google.com with ESMTP id mr8si14735649pbb.181.2014.06.02.00.13.26 for ; Mon, 02 Jun 2014 00:13:28 -0700 (PDT) Message-ID: <538C240F.60501@lge.com> Date: Mon, 02 Jun 2014 16:13:19 +0900 From: Gioh Kim MIME-Version: 1.0 Subject: Re: [PATCH v2 2/3] CMA: aggressively allocate the pages on cma reserved memory when not used References: <1401260672-28339-1-git-send-email-iamjoonsoo.kim@lge.com> <1401260672-28339-3-git-send-email-iamjoonsoo.kim@lge.com> <53883902.8020701@lge.com> <538C1196.9000608@lge.com> <20140602062344.GB7713@js1304-P5Q-DELUXE> In-Reply-To: <20140602062344.GB7713@js1304-P5Q-DELUXE> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: Andrew Morton , Rik van Riel , Johannes Weiner , Mel Gorman , Laura Abbott , Minchan Kim , Heesub Shin , Marek Szyprowski , Michal Nazarewicz , "Aneesh Kumar K.V" , Linux Memory Management List , LKML , =?UTF-8?B?7J206rG07Zi4?= I'm not sure what I'm doing wrong. These are my code. 770 #ifdef CONFIG_CMA 771 void adjust_managed_cma_page_count(struct zone *zone, long count) 772 { 773 unsigned long flags; 774 long total, cma, movable; 775 776 spin_lock_irqsave(&zone->lock, flags); 777 778 zone->managed_cma_pages += count; 779 780 total = zone->managed_pages; 781 cma = zone->managed_cma_pages; 782 movable = total - cma - high_wmark_pages(zone); 783 784 printk("count=%ld total=%ld cma=%ld movable=%ld\n", 785 count, total, cma, movable); 786 2014-06-02 i??i?? 3:23, Joonsoo Kim i?' e,?: > On Mon, Jun 02, 2014 at 02:54:30PM +0900, Gioh Kim wrote: >> I found 2 problems at my platform. >> >> 1st is occured when I set CMA size 528MB and total memory is 960MB. >> I print some values in adjust_managed_cma_page_count(), >> the total value becomes 105439 and cma value 131072. >> Finally movable value becomes negative value. >> >> The total value 105439 means 411MB. >> Is the zone->managed_pages value pages amount except the CMA? >> I think zone->managed_pages value is including CMA size but it's value is strange. > > Hmm... > zone->managed_pages includes nr of CMA pages. > Is there any mistake about your printk? > >> >> 2nd is a kernel panic at __netdev_alloc_skb(). >> I'm not sure it is caused by the CMA. >> I'm checking it again and going to send you another report with detail call-stacks. > > Okay. > > Thanks. > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org