[PATCH] mm/hugetlb_vmemmap: Use max() macro to simplify the code

[PATCH] mm/hugetlb_vmemmap: Use max() macro to simplify the code

[zenghongling]

Use the max() macro to simplify the function and improve
its readability.

Signed-off-by: zenghongling <zenghongling@kylinos.cn>
---
 mm/hugetlb_vmemmap.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/hugetlb_vmemmap.h b/mm/hugetlb_vmemmap.h
index 18b490825215..abdfa870b096 100644
--- a/mm/hugetlb_vmemmap.h
+++ b/mm/hugetlb_vmemmap.h
@@ -48,7 +48,7 @@ static inline unsigned int hugetlb_vmemmap_optimizable_size(const struct hstate
 
 	if (!is_power_of_2(sizeof(struct page)))
 		return 0;
-	return size > 0 ? size : 0;
+	return max(size, 0);
 }
 #else
 static inline int hugetlb_vmemmap_restore_folio(const struct hstate *h, struct folio *folio)
-- 
2.25.1

Re: [PATCH] mm/hugetlb_vmemmap: Use max() macro to simplify the code

[Muchun Song]

> On Jan 21, 2026, at 09:51, zenghongling <zenghongling@kylinos.cn> wrote:
> 
> Use the max() macro to simplify the function and improve
> its readability.
> 
> Signed-off-by: zenghongling <zenghongling@kylinos.cn>

Reviewed-by: Muchun Song <muchun.song@linux.dev>

Re: [PATCH] mm/hugetlb_vmemmap: Use max() macro to simplify the code

[Matthew Wilcox]

On Wed, Jan 21, 2026 at 09:51:14AM +0800, zenghongling wrote:
> Use the max() macro to simplify the function and improve
> its readability.

How does this improve readability?  I understand what this does in
the ternary form.  I have to think far harder about it in the max()
form.

>  	if (!is_power_of_2(sizeof(struct page)))
>  		return 0;
> -	return size > 0 ? size : 0;
> +	return max(size, 0);
>  }

Re: [PATCH] mm/hugetlb_vmemmap: Use max() macro to simplify the code

[David Laight]

On Wed, 21 Jan 2026 06:17:07 +0000
Matthew Wilcox <willy@infradead.org> wrote:

> On Wed, Jan 21, 2026 at 09:51:14AM +0800, zenghongling wrote:
> > Use the max() macro to simplify the function and improve
> > its readability.  
> 
> How does this improve readability?  I understand what this does in
> the ternary form.  I have to think far harder about it in the max()
> form.

I must do a patch for checkpatch.pl to stop it suggesting min/max
for trivial cases.
Oh - and stop it ever suggesting the _t variants.
IMHO it is better to have an explicit cast on one of the parameters.

	David

> 
> >  	if (!is_power_of_2(sizeof(struct page)))
> >  		return 0;
> > -	return size > 0 ? size : 0;
> > +	return max(size, 0);
> >  }  
>