[PATCH 2/2] memcg: correct comments for __mem_cgroup_begin_update_page_stat

[PATCH 2/2] memcg: correct comments for __mem_cgroup_begin_update_page_stat

[Qiang Huang]

Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
---
 mm/memcontrol.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 5804d71..f96e68e 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2251,12 +2251,11 @@ cleanup:
 }

 /*
- * Currently used to update mapped file statistics, but the routine can be
- * generalized to update other statistics as well.
+ * Used to update mapped file or writeback or other statistics.
  *
  * Notes: Race condition
  *
- * We usually use page_cgroup_lock() for accessing page_cgroup member but
+ * We usually use lock_page_cgroup() for accessing page_cgroup member but
  * it tends to be costly. But considering some conditions, we doesn't need
  * to do so _always_.
  *
@@ -2270,8 +2269,8 @@ cleanup:
  * by flags.
  *
  * Considering "move", this is an only case we see a race. To make the race
- * small, we check mm->moving_account and detect there are possibility of race
- * If there is, we take a lock.
+ * small, we check memcg->moving_account and detect there are possibility
+ * of race or not. If there is, we take a lock.
  */

 void __mem_cgroup_begin_update_page_stat(struct page *page,
-- 
1.8.3

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH 2/2] memcg: correct comments for __mem_cgroup_begin_update_page_stat

[Michal Hocko]

On Wed 07-05-14 16:27:13, Qiang Huang wrote:
> 
> Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>

Looks good
Acked-by: Michal Hocko <mhocko@suse.cz>

Thanks!

> ---
>  mm/memcontrol.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 5804d71..f96e68e 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -2251,12 +2251,11 @@ cleanup:
>  }
> 
>  /*
> - * Currently used to update mapped file statistics, but the routine can be
> - * generalized to update other statistics as well.
> + * Used to update mapped file or writeback or other statistics.
>   *
>   * Notes: Race condition
>   *
> - * We usually use page_cgroup_lock() for accessing page_cgroup member but
> + * We usually use lock_page_cgroup() for accessing page_cgroup member but
>   * it tends to be costly. But considering some conditions, we doesn't need
>   * to do so _always_.
>   *
> @@ -2270,8 +2269,8 @@ cleanup:
>   * by flags.
>   *
>   * Considering "move", this is an only case we see a race. To make the race
> - * small, we check mm->moving_account and detect there are possibility of race
> - * If there is, we take a lock.
> + * small, we check memcg->moving_account and detect there are possibility
> + * of race or not. If there is, we take a lock.
>   */
> 
>  void __mem_cgroup_begin_update_page_stat(struct page *page,
> -- 
> 1.8.3
> 

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>