From: n-horiguchi@ah.jp.nec.com
To: riel@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
lwoodman@redhat.com, peterz@infradead.org, mgorman@suse.de,
dave.hansen@intel.com, sunil.k.pandey@intel.com
Subject: Re: [PATCH] mm,numa: remove BUG_ON in __handle_mm_fault
Date: Tue, 29 Apr 2014 15:26:22 -0400 [thread overview]
Message-ID: <535ffd31.c177e00a.701c.ffffe36bSMTPIN_ADDED_BROKEN@mx.google.com> (raw)
In-Reply-To: <20140425144147.679a7608@annuminas.surriel.com>
On Fri, Apr 25, 2014 at 02:41:47PM -0400, Rik van Riel wrote:
> Changing PTEs and PMDs to pte_numa & pmd_numa is done with the
> mmap_sem held for reading, which means a pmd can be instantiated
> and/or turned into a numa one while __handle_mm_fault is examining
> the value of orig_pmd.
>
> If that happens, __handle_mm_fault should just return and let
> the page fault retry, instead of throwing an oops.
>
> Signed-off-by: Rik van Riel <riel@redhat.com>
> Reported-by: Sunil Pandey <sunil.k.pandey@intel.com>
Looks good to me.
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-04-29 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 18:41 Rik van Riel
2014-04-29 19:26 ` n-horiguchi [this message]
[not found] ` <1398799576-9pfzypnu@n-horiguchi@ah.jp.nec.com>
2014-04-29 19:36 ` [PATCH -v2] " Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535ffd31.c177e00a.701c.ffffe36bSMTPIN_ADDED_BROKEN@mx.google.com \
--to=n-horiguchi@ah.jp.nec.com \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lwoodman@redhat.com \
--cc=mgorman@suse.de \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=sunil.k.pandey@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox