From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Andrew Morton <akpm@digeo.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.5.73-mm3
Date: Wed, 02 Jul 2003 11:50:11 -0700 [thread overview]
Message-ID: <535730000.1057171811@flay> (raw)
In-Reply-To: <530600000.1057169520@flay>
> scsi HBA driver Qlogic ISP 10X0/2X00 didn't set a release method.
> st: Version 20030622, fixed bufsize 32768, s/g segs 256
> oprofile: using NMI interrupt.
> NET4: Linux TCP/IP 1.0 for NET4.0
> IP: routing cache hash table of 131072 buckets, 1024Kbytes
> TCP: Hash tables configured (established 524288 bind 65536)
> NET4: Unix domain sockets 1.0/SMP for Linux NET4.0.
> VFS: Cannot open root device "sda2" or unknown-block(0,0)
> Please append a correct "root=" boot option
> Kernel panic: VFS: Unable to mount root fs on unknown-block(0,0)
>
> Note the "scsi HBA driver Qlogic ISP 10X0/2X00 didn't set a release method"
> bit.
OK, this rediffed version of Mike's earlier patch fixes it - I guess it
got trampled in the merge. All the ifdefs surrounding isplinux_release
are a bit odd, but I think I got 'em right. Would be a damned sight
easier if we ripped out all that version crud.
M.
diff -purN linux-2.5.73-mm3/drivers/scsi/isp/isp_linux.c 2.5.73-mm3/drivers/scsi/isp/isp_linux.c
--- linux-2.5.73-mm3/drivers/scsi/isp/isp_linux.c 2003-07-01 20:29:04.000000000 -0700
+++ 2.5.73-mm3/drivers/scsi/isp/isp_linux.c 2003-07-02 11:01:02.000000000 -0700
@@ -145,7 +145,6 @@ isplinux_detect(Scsi_Host_Template *tmpt
return (rval);
}
-#ifdef MODULE
/* io_request_lock *not* held here */
int
isplinux_release(struct Scsi_Host *host)
@@ -185,7 +184,6 @@ isplinux_release(struct Scsi_Host *host)
isp_kfree(FCPARAM(isp)->isp_dump_data, amt);
FCPARAM(isp)->isp_dump_data = 0;
}
-#endif
#if defined(CONFIG_PROC_FS) && LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,0)
/*
* Undo any PROCFS stuff
@@ -193,8 +191,8 @@ isplinux_release(struct Scsi_Host *host)
isplinux_undo_proc(isp);
#endif
return (1);
-}
#endif
+}
const char *
isplinux_info(struct Scsi_Host *host)
diff -purN linux-2.5.73-mm3/drivers/scsi/isp/isp_linux.h 2.5.73-mm3/drivers/scsi/isp/isp_linux.h
--- linux-2.5.73-mm3/drivers/scsi/isp/isp_linux.h 2003-07-01 20:29:04.000000000 -0700
+++ 2.5.73-mm3/drivers/scsi/isp/isp_linux.h 2003-07-02 10:53:38.000000000 -0700
@@ -774,12 +774,8 @@ static INLINE unsigned long _usec_to_jif
int isplinux_proc_info(char *, char **, off_t, int, int, int);
int isplinux_detect(Scsi_Host_Template *);
-#ifdef MODULE
int isplinux_release(struct Scsi_Host *);
#define ISPLINUX_RELEASE isplinux_release
-#else
-#define ISPLINUX_RELEASE NULL
-#endif
const char *isplinux_info(struct Scsi_Host *);
int isplinux_queuecommand(Scsi_Cmnd *, void (* done)(Scsi_Cmnd *));
#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2003-07-02 18:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-02 3:38 2.5.73-mm3 Andrew Morton
2003-07-02 5:07 ` 2.5.73-mm3 Martin J. Bligh
2003-07-02 5:18 ` 2.5.73-mm3 Andrew Morton
2003-07-02 18:12 ` 2.5.73-mm3 Martin J. Bligh
2003-07-02 18:50 ` Martin J. Bligh [this message]
2003-07-02 19:56 ` 2.5.73-mm3 Martin J. Bligh
2003-07-02 9:10 ` 2.5.73-mm3 `highmem_start_page' undeclared with DEBUG_PAGEALLOC and no highmem Helge Hafting
2003-07-02 10:54 ` 2.5.73-mm3 Maneesh Soni
2003-07-02 15:18 ` 2.5.73-mm3 Andrew Morton
2003-07-02 18:27 ` 2.5.73-mm3 Valdis.Kletnieks
2003-07-10 2:11 ` 2.5.73-mm3 vs. linux-2.5.74-mm1 Piet Delaney
2003-07-10 2:32 ` Piet Delaney
2003-07-10 3:13 ` Piet Delaney
2003-07-10 3:13 ` Piet Delaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535730000.1057171811@flay \
--to=mbligh@aracnet.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox