Re: [akpm-mm:mm-new 417/421] fs/ext4/file.c:825:36: error: incompatible type for argument 1 of 'daxdev_mapping_supported'

[Lorenzo Stoakes <lorenzo.stoakes@oracle.com>]

On Tue, Jan 20, 2026 at 12:30:12PM +0800, kernel test robot wrote:
> Hi Lorenzo,
>
> FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
> head:   e4348a62bb1acacafcdeb149c9363291fae08c0c
> commit: e3900da1b37f861133669d26ae02415f18fa71b9 [417/421] mm: update all remaining mmap_prepare users to use vma_flags_t
> config: sparc-randconfig-002-20260120 (https://download.01.org/0day-ci/archive/20260120/202601201215.7iVpmWIM-lkp@intel.com/config)
> compiler: sparc64-linux-gcc (GCC) 8.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260120/202601201215.7iVpmWIM-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202601201215.7iVpmWIM-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>    fs/ext4/file.c: In function 'ext4_file_mmap_prepare':
> >> fs/ext4/file.c:825:36: error: incompatible type for argument 1 of 'daxdev_mapping_supported'
>      if (!daxdev_mapping_supported(desc->vma_flags, file_inode(file), dax_dev))
>                                    ~~~~^~~~~~~~~~~
>    In file included from fs/ext4/file.c:27:
>    include/linux/dax.h:114:56: note: expected 'vm_flags_t' {aka 'long unsigned int'} but argument is of type 'vma_flags_t' {aka 'struct <anonymous>'}
>     static inline bool daxdev_mapping_supported(vm_flags_t vm_flags,
>                                                 ~~~~~~~~~~~^~~~~~~~
>
>
> vim +/daxdev_mapping_supported +825 fs/ext4/file.c
>
>    806
>    807	static int ext4_file_mmap_prepare(struct vm_area_desc *desc)
>    808	{
>    809		int ret;
>    810		struct file *file = desc->file;
>    811		struct inode *inode = file->f_mapping->host;
>    812		struct dax_device *dax_dev = EXT4_SB(inode->i_sb)->s_daxdev;
>    813
>    814		if (file->f_mode & FMODE_WRITE)
>    815			ret = ext4_emergency_state(inode->i_sb);
>    816		else
>    817			ret = ext4_forced_shutdown(inode->i_sb) ? -EIO : 0;
>    818		if (unlikely(ret))
>    819			return ret;
>    820
>    821		/*
>    822		 * We don't support synchronous mappings for non-DAX files and
>    823		 * for DAX files if underneath dax_device is not synchronous.
>    824		 */
>  > 825		if (!daxdev_mapping_supported(desc->vma_flags, file_inode(file), dax_dev))
>    826			return -EOPNOTSUPP;

Yup I missed one case here as pointed out by Zi, will fix.

>    827
>    828		file_accessed(file);
>    829		if (IS_DAX(file_inode(file))) {
>    830			desc->vm_ops = &ext4_dax_vm_ops;
>    831			vma_desc_set_flags(desc, VMA_HUGEPAGE_BIT);
>    832		} else {
>    833			desc->vm_ops = &ext4_file_vm_ops;
>    834		}
>    835		return 0;
>    836	}
>    837
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki