Re: [PATCH 1/5] hugetlb: prep_compound_gigantic_page(): drop __init marker

[Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>]

Hi Luiz,

On Tue, Apr 08, 2014 at 03:02:16PM -0400, Luiz Capitulino wrote:
> This function is going to be used by non-init code in a future
> commit.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  mm/hugetlb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 7c02b9d..319db28 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -689,8 +689,7 @@ static void prep_new_huge_page(struct hstate *h, struct page *page, int nid)
>  	put_page(page); /* free it into the hugepage allocator */
>  }
>  
> -static void __init prep_compound_gigantic_page(struct page *page,
> -					       unsigned long order)
> +static void prep_compound_gigantic_page(struct page *page, unsigned long order)
>  {
>  	int i;
>  	int nr_pages = 1 << order;

Is __ClearPageReserved() in this function relevant only in boot time
allocation?  If yes, it might be good to avoid calling it in runtime
allocation.

Thanks,
Naoya Horiguchi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>