From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27C0AC433EF for ; Fri, 1 Apr 2022 10:46:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A70838D0002; Fri, 1 Apr 2022 06:46:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F7228D0001; Fri, 1 Apr 2022 06:46:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 871328D0002; Fri, 1 Apr 2022 06:46:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 748948D0001 for ; Fri, 1 Apr 2022 06:46:15 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4806D21EB4 for ; Fri, 1 Apr 2022 10:46:05 +0000 (UTC) X-FDA: 79307980290.14.2C143A7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id B2511C0005 for ; Fri, 1 Apr 2022 10:46:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648809964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xiOEHMN+N8h0zJ0SMcJZz4gaUnk1cTnEy4jqmAnZpc4=; b=hMQj6QlCz3E7irNVUh+kG5DBsczDjPsBo2W7yXaQtNqfBMqwntlhp3xDKgokiVYnnR/pqo NgJogRCnjye0eNRkG9Ko7t9MEmlSjksA4eg1SJWhMOpC1jYFMmOKMEboIk3XZ0Mt1blBLK HYDC+eIga6W/+br+1Cr6giy1zN7kQOc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-403-aRxSWOvqNvK1UrTU4DpWDA-1; Fri, 01 Apr 2022 06:46:03 -0400 X-MC-Unique: aRxSWOvqNvK1UrTU4DpWDA-1 Received: by mail-wr1-f69.google.com with SMTP id k20-20020adfc714000000b001e305cd1597so509162wrg.19 for ; Fri, 01 Apr 2022 03:46:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=xiOEHMN+N8h0zJ0SMcJZz4gaUnk1cTnEy4jqmAnZpc4=; b=ZwhS1Gsxmm6tL5wB+oKHnFzNJIo7y4ko1ZznK1vavaVkrD7h9Jg3Q1x+UulBtZ+BIG NcJ8FKiRDhj3coZQEORA1k3u/L03xDfcI57/RHjzerm/QcEiSBP7I7dxg1YUnQAaWIQ6 5rLOIL2/vhrntSCTlE3SLt+bx4oA6426Rlzl2v5xKFG42x/r054WByu2xbLU3i+8gOgj WVj+yTxUigDqKUr5KToamSsu5if9LsSGJgcPkiRKyY7CM43jr3d6VA48ihJK3nVkiCOZ lLfABZp4m3UBzXsjZnRWdRRGM+1RHtCQjkhpYOlJkFY3Bum/wStRVeyzvaO6vvoExEin 6Vsg== X-Gm-Message-State: AOAM531zDar9iHhFtjdn+cdmlUmFxWV0R8UJ1rKTED4aejTL268+cOiW /vuyyNP3GVC+5rn9CuAGjt7PbJFjjmR71A73FzTiqmuhkHbdgX8v8FIGI9/fuzc1gwz/F0c8A7N a55M3XFMnptE= X-Received: by 2002:a05:6000:15c3:b0:204:1185:7033 with SMTP id y3-20020a05600015c300b0020411857033mr7152790wry.625.1648809961978; Fri, 01 Apr 2022 03:46:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxG6qdtKkHpCzK5kfgnGP3ksdgfaziO7qjWnqOtF8DYMjkpdW5H7mcAyR9Skz1fhr1WB/9Aw== X-Received: by 2002:a05:6000:15c3:b0:204:1185:7033 with SMTP id y3-20020a05600015c300b0020411857033mr7152778wry.625.1648809961748; Fri, 01 Apr 2022 03:46:01 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:9e00:229d:4a10:2574:c6fa? (p200300cbc7069e00229d4a102574c6fa.dip0.t-ipconnect.de. [2003:cb:c706:9e00:229d:4a10:2574:c6fa]) by smtp.gmail.com with ESMTPSA id az19-20020a05600c601300b0038cadf3aa69sm14215057wmb.36.2022.04.01.03.46.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Apr 2022 03:46:01 -0700 (PDT) Message-ID: <533f85f9-82e2-bfa7-3788-4b2a668daedf@redhat.com> Date: Fri, 1 Apr 2022 12:46:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v2 2/2] hugetlb: Fix return value of __setup handlers To: Peng Liu , mike.kravetz@oracle.com, akpm@linux-foundation.org, yaozhenguo1@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20220401101232.2790280-1-liupeng256@huawei.com> <20220401101232.2790280-3-liupeng256@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220401101232.2790280-3-liupeng256@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B2511C0005 X-Stat-Signature: kwjohyjod775j6to3qmcirron86gp81b X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hMQj6QlC; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf10.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1648809964-314159 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.04.22 12:12, Peng Liu wrote: > When __setup() return '0', using invalid option values causes the > entire kernel boot option string to be reported as Unknown. Hugetlb > calls __setup() and will return '0' when set invalid parameter > string. > > The following phenomenon is observed: > cmdline: > hugepagesz=1Y hugepages=1 > dmesg: > HugeTLB: unsupported hugepagesz=1Y > HugeTLB: hugepages=1 does not follow a valid hugepagesz, ignoring > Unknown kernel command line parameters "hugepagesz=1Y hugepages=1" > > Since hugetlb will print warn or error information before return for > invalid parameter string, just use return '1' to avoid print again. > > Signed-off-by: Peng Liu > --- > mm/hugetlb.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 9cd746432ca9..6dde34c115c9 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -4131,12 +4131,11 @@ static int __init hugepages_setup(char *s) > int count; > unsigned long tmp; > char *p = s; > - int ret = 1; Adding this in #1 to remove it in #2 is a bit sub-optimal IMHO. -- Thanks, David / dhildenb