From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C7E7EB64D9 for ; Wed, 14 Jun 2023 14:57:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B1A26B0078; Wed, 14 Jun 2023 10:57:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 639816B007B; Wed, 14 Jun 2023 10:57:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B3576B007E; Wed, 14 Jun 2023 10:57:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 388526B0078 for ; Wed, 14 Jun 2023 10:57:45 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 07DB48050C for ; Wed, 14 Jun 2023 14:57:45 +0000 (UTC) X-FDA: 80901657690.23.065101D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id B646F4000D for ; Wed, 14 Jun 2023 14:57:42 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QqQF3gPD; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686754662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uppa3uWzfF5tvk9avd6pQ9IphfaAL83xnkk0Cjs6Hhk=; b=8BCuNYxF4jgq8JK25A4gMT+skTvauCKG/HBMLCDXOFfiUliFIvSBihYItPBzXAFNPG36Dj W+FkvCB3z9aeYd/kf81NUH4AJJzRMbrBx6wmCYdoHCE1JQLRnVVYw/7BorIzl6XHvHvQAA YSsOHLshOlnsKf/t/b5h+NANHOwnEQE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QqQF3gPD; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686754662; a=rsa-sha256; cv=none; b=gq9dI5RZPiaz3y7CXdZUEXizdjJze86nsubbj5A5/CQUOvFkcERS3VXt5JhvqP+kESX6eb TCCoJaJwNKbhZ6+Fpn0LlpUJ3SLv6cJaB6AP9q4/st4WX5yM/8gErTrjikIQKTe4EqwPrN 5gPD9bTU6OuHWiwdJphtL/bwEbP3SjI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686754662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Uppa3uWzfF5tvk9avd6pQ9IphfaAL83xnkk0Cjs6Hhk=; b=QqQF3gPD/L1teKwah2+Dj9mq75Uio5rRaGQgfqonxora3y4wCGWsh0/qI8COZq2SI0Y92D 84WSKMHjhYiCYOandIxUL8Rl6QFRriUkSAwEZng3Da3KSoqRtIfXwtdfZWXyj2D2qkxbHX VfOj8r3R42vM/SG7qydHFOxuxQ/pJmo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-161-vg2xn6A_OvmJ12z_yzcmfg-1; Wed, 14 Jun 2023 10:57:40 -0400 X-MC-Unique: vg2xn6A_OvmJ12z_yzcmfg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f7678c74beso5709715e9.3 for ; Wed, 14 Jun 2023 07:57:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686754659; x=1689346659; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Uppa3uWzfF5tvk9avd6pQ9IphfaAL83xnkk0Cjs6Hhk=; b=EA/QZA06KZPEMzYzmyL/UjH5mKr0Tg06khR0xGk3bROu+KmxqActK121lVe3413Tfp 7LohIgfdZ7Nct9evn980Mqtbl9Au7bfCriZZxxPTCLn6AdV0rt0XnIL2TemXgyiCTgAn kjouL6/UtN0B+ye+cJdVHrpvO/RbE9hcabXIdD2MSjP/kyL06T/538jhdt7FAln+gDNN WM5gsC0iUDOH13WtKYAJb2dN6tm6XjvfjqhtPBL+Bz3lzKOVbzOpPn2NLwiqAbyhlMHU e4m756QKKWy2N64nX664LIaOCojGoQ3vPdz3D8Khok9QyCzJwFJMS7YZEH3Lj1dwsg75 O5cg== X-Gm-Message-State: AC+VfDzQ1D3sWDW722zEsI2Gz2pRMl4gvNIfpuxNIySTg1sx6+nA711z PhCAF0tDC7WwSn6y1grea+yB2xf+/dybXjoA5mWUg8FPfhessdPqxbO+ch0VlhrdI8OIfZJ3Pws 4/IoHyY6MQAc= X-Received: by 2002:a05:600c:2948:b0:3f7:3a11:e3ae with SMTP id n8-20020a05600c294800b003f73a11e3aemr13311865wmd.38.1686754659497; Wed, 14 Jun 2023 07:57:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6I7h1wgATJMLGDmmkyARD4Su7DI+YrvaeE8V1DcZiJhjoRIYauvU/WmxrswjRJeCtwb2mqog== X-Received: by 2002:a05:600c:2948:b0:3f7:3a11:e3ae with SMTP id n8-20020a05600c294800b003f73a11e3aemr13311853wmd.38.1686754659123; Wed, 14 Jun 2023 07:57:39 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:b200:7d03:23db:ad5:2d21? (p200300cbc704b2007d0323db0ad52d21.dip0.t-ipconnect.de. [2003:cb:c704:b200:7d03:23db:ad5:2d21]) by smtp.gmail.com with ESMTPSA id z10-20020a05600c114a00b003f7e60622f0sm17749133wmz.6.2023.06.14.07.57.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 07:57:38 -0700 (PDT) Message-ID: <533c32cf-9a18-1590-4d29-f076d6bd58c1@redhat.com> Date: Wed, 14 Jun 2023 16:57:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 4/7] mm/hugetlb: Prepare hugetlb_follow_page_mask() for FOLL_PIN To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Matthew Wilcox , Andrea Arcangeli , John Hubbard , Mike Rapoport , Vlastimil Babka , "Kirill A . Shutemov" , Andrew Morton , Mike Kravetz , James Houghton , Hugh Dickins References: <20230613215346.1022773-1-peterx@redhat.com> <20230613215346.1022773-5-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230613215346.1022773-5-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 7pn9xje1k55nzhju31ha6zc3kaqni5fw X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B646F4000D X-HE-Tag: 1686754662-45102 X-HE-Meta: U2FsdGVkX1+WkOZfipw/ajghSB4l6kmqvXS5HjXDr0VXcTa275vjqB2lpE8wyN+K9UdNUf2U48DwoD7udHMa1Ms0QDLJiX8VUqkzakfNoqS1ObQYCDDUj9ZJFkZ5XZbp6eBbx99Xyw5ncnL/RC+oFie1K0cC9Nyde1I0099W/sTHJFM5TDe5JGviSGPvDUU7lib5JwcnPnEyRedlwFBBj9UCxCN0mZdoTH4OmiBwxXcCGVTUR4hxYL6q+vKGszWwwHwZiF77Y8XjyURU75ZIkauhhnyZZWCVVGdegwiYQPdi5j1vd/oAP7BN3CXfje19nFSoU/+EQANgt5BhJrzrWc2f+q17h4frs0P8Fuz1uCtEXylnHl3MDC+gpaqwlnYnQbA/tYlFEWbdlqrOJ/4c5O/cXbBAaRMDgHaFMy/V4DpB6YdcDZVSPv2ka1z/d1qQPgHAARm5lWCtRFUqi5gv4hts76PtIz9VWdz2g/g5u+3uzvFELrhCqVffjbPVGGbFCjpVJ7fc4uU1HSwbkvydSbjm4uqiO/e1AZFdG+NyiK7ZhtQKqFSftq8q0BrI76o+dDUQhlCZr0hb+L9b/uQXEcq60dBtLl35IxxT4FcI80NYSddipXW3otd17R7Jy5J0kMS0XRNi2x5D5Kp82Zer1M/hwicCZF3XBMNCOV6GwEu5AtJVUmVRRQYKw/JPGzlyoKxihyl3TJVRXf/Gqh5zZo02QBz7pjbbd8KqDt3rwBPLVPgLhu8VuJ+Yaw4XoF2xZjENlqwE5NtsVZK2qgKajq6FMP7LOPa7oFobM8XVDLTM2bV7kEyV5KPacdDuIlb+r74o20h/jYzNix870bl35ol6FtjhiGdTYUsZjkXej61/Jo598/JUvPEG9vgJUPHAXIDA5G4y4Mdj+KSG605ExsTsa0dOJ00m7bvcHDuoHCfqpNfI9bqndx3eBBQaeNp+2elw+65fDRK/vf1DMjw JSzFP3sU M2967E9q2vJR6wJVbyvYkrf9EYJ49bTlUNHJ6XjvjBybc8wi06A1B31L6BUdBJTJQ4kk0ZoqUZ8RKZFVg1zvEuLMLbjJSX5S04VgsO5iDa7htscNwVifpAXqXrpvDaWtLXD5LUWz/JaVJwMI4UV3A7oQENS0bUZ/9lKnlzoAZRidjs1/RD5EcOhNA4D2BK/jIKLhD1NnVftscuJioJ27wrRuxIDbdBen//vIBdku55+kZSWJecznRe48Vx40iy31BlvlB3zafXes+1Ayvt0bI9sjYswYP/pBUS2lGPobvnEKZl0CkHdhcpgfliUFZ5qzAGWoYeNenV6wRY/3QaGAFmisDdpopcXKvhvQ2/FvpmraGPn0luzf0Tkc96ARJw3BUkiJ3PWfgNAEblR5U91jL4D0LjAh+oDi7HheN1zSEtql23OY9AnSK8xWWkTjZ5ZA52Qi1YAbrwBWdwR0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.06.23 23:53, Peter Xu wrote: > It's coming, not yet, but soon. Loose the restriction. > > Signed-off-by: Peter Xu > --- > mm/hugetlb.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index f037eaf9d819..31d8f18bc2e4 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -6467,13 +6467,6 @@ struct page *hugetlb_follow_page_mask(struct vm_area_struct *vma, > spinlock_t *ptl; > pte_t *pte, entry; > > - /* > - * FOLL_PIN is not supported for follow_page(). Ordinary GUP goes via > - * follow_hugetlb_page(). > - */ > - if (WARN_ON_ONCE(flags & FOLL_PIN)) > - return NULL; > - > hugetlb_vma_lock_read(vma); > pte = hugetlb_walk(vma, haddr, huge_page_size(h)); > if (!pte) Did you fix why the warning was placed there in the first place? (IIRC, at least unsharing support needs to be added, maybe more) -- Cheers, David / dhildenb