From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E98FC369CF for ; Sun, 20 Apr 2025 00:31:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB64A6B00A7; Sat, 19 Apr 2025 20:31:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E64676B00A8; Sat, 19 Apr 2025 20:31:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2C1F6B00A9; Sat, 19 Apr 2025 20:31:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B24CE6B00A7 for ; Sat, 19 Apr 2025 20:31:49 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C470A806E3 for ; Sun, 20 Apr 2025 00:31:50 +0000 (UTC) X-FDA: 83352544380.15.66A9BB1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 6491220008 for ; Sun, 20 Apr 2025 00:31:48 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=U18YNH5b; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of llong@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745109108; a=rsa-sha256; cv=none; b=4hBPwEUUJKhqluhfMB2VJ8bxL/3/BnLqFKtn1b1NsAj7lWV+h+S7khpVl0OCMZg7LmhMqR WcGTtUFzsjsZ7iEfObG2t9dSSYPISFP3dnNQ/e1UhBiRPPx//ApMZdr5FSpjmFx1hBHfy7 5FmPQlynoVkqDYjiSpEqnTDgjPKvLWQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=U18YNH5b; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of llong@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745109108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dgEWx6bqfsYcNIZ2nRjRSHhDwyAXgwASsQ5jmGYZ/+8=; b=HnQ2K+EbDcEuu6GomcegQVP1fu8eXSnzFDeebjRor4gScrRmJ7Ul2YMVnr4dFY9j8IWdMY Nce39gvGX0GpZyHOUHIRzoDWpT4vtJNyRcO+rJFS2WAjbHeNJI8VT/WNPnygwyajftoeg1 MendAiKpAWyxGkXgyEP9YsPiNt2Xp7Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745109107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dgEWx6bqfsYcNIZ2nRjRSHhDwyAXgwASsQ5jmGYZ/+8=; b=U18YNH5btcXadEcK2/NBjuGTtro8ks8hfj4cK4rFT1rCElUEvFn7B3CrJby64Ajn7ozjDB XUyVBvbTlVtbn08awNJYEXNVWgQBnMG4jwZe+a8wk+V6TcT1cT5ytsyVCBvamS4oQZ7oOg KId4iTPoY7LLV3NKdLnDiiv0XbFgzI0= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-CxneD0x-Oe2nWAL2nIin1w-1; Sat, 19 Apr 2025 20:31:44 -0400 X-MC-Unique: CxneD0x-Oe2nWAL2nIin1w-1 X-Mimecast-MFC-AGG-ID: CxneD0x-Oe2nWAL2nIin1w_1745109103 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c5d608e703so509162985a.3 for ; Sat, 19 Apr 2025 17:31:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745109103; x=1745713903; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dgEWx6bqfsYcNIZ2nRjRSHhDwyAXgwASsQ5jmGYZ/+8=; b=dTjQIP74jNlf1AHMd74xRC38dJ7MQCn7rhErqDwbris2O6sv4nMDaHgp1xvOhk4ZDJ gLEO0I9wichJe7YVoMgyOHTYz0IXNGHp4jcZmHCGM7nqWBaLjq3mBf+SLeja9uzd8Kow 69eitLWu/PUDIo1qIPQw6sx+DCvbN033YfotPqoAcruuuBVSlx905yY5LqkZyGxdt4x4 rx57AiA2SrhmNcuBtdt++CsS0+QvslxkkoPh+nhzfkPat9ttF1ly2R1wgdnfBRejoAo2 eWJPCnirKDMF1OSQWdiEKSaq+xV4zlRA+5h13cuaCoJlZSiXw0xpVMgURtTS5BkpoK75 M9gg== X-Forwarded-Encrypted: i=1; AJvYcCVG0z4YWnRyLFGu+TOzAevVdJiidBxzHL3kf0gxq6dS1wGsjybxoKml4Y69letfr5GUW+K5C4iC3g==@kvack.org X-Gm-Message-State: AOJu0YzUANhhqxS7ZomB6mlaopahhRJQTDQM984PWp/prEciyHdd0WEY IcKwV/3tPLnN9s07DfZi+1+0nUxdKMKNpivTmnfjBfLL2lOYhbtnbd8SFzY5/Uftj4nfntZDwDr bANRETube+cKCIRgL+EwoLX4o+7dvNegul0m+N29/d/s3kNhw X-Gm-Gg: ASbGncsBD+rmXTBT3YlWe+KJLl+VyZgo21ZxHOZtoNMWAqMJCaAVYshJxV/6bGBSg36 46Gav2ilBhv7pk14dq2mhWZsl7/Wr8TqHtpX95fD8xMSz4nJGaMtLjBNdnT3/1MNyH/Hx465Gn+ OJ46BJ5Tkv6zkuzIPWVNimzTZ0gkTpBe9W1fG/8DrUCZddb2kAQ8v5l2SRFygMXNNrBvQLsfbyP Nr/V/bg5Cspeuo7vTF7BtxI6ghRZ04Fbg3sK3TPtFONMPSmKjkM6Y2JDrRV0oL+lqYX2VXGKCjH AKXq6Tgo6H68fiIGnWKvnE4B9HdZxCvKLXyl0tr6BVTt8174PA== X-Received: by 2002:a05:620a:2482:b0:7c5:4454:6b05 with SMTP id af79cd13be357-7c92804d3e6mr1365215485a.57.1745109103697; Sat, 19 Apr 2025 17:31:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH3CW4OI4+0M83k8AsYGQ4HxOMj60YbZOnkxwdYcny3UUeUE0axskyJtzAkSfGwP8v9qyUOJA== X-Received: by 2002:a05:620a:2482:b0:7c5:4454:6b05 with SMTP id af79cd13be357-7c92804d3e6mr1365213585a.57.1745109103442; Sat, 19 Apr 2025 17:31:43 -0700 (PDT) Received: from [192.168.130.170] (67-212-218-66.static.pfnllc.net. [67.212.218.66]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c925b4da22sm258243385a.66.2025.04.19.17.31.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Apr 2025 17:31:42 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <532fe761-4907-4f4b-b98d-566453301399@redhat.com> Date: Sat, 19 Apr 2025 20:31:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] vmscan,cgroup: apply mems_effective to reclaim To: Gregory Price , linux-mm@kvack.org Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, tj@kernel.org, mkoutny@suse.com, akpm@linux-foundation.org References: <20250419053824.1601470-1-gourry@gourry.net> <20250419053824.1601470-3-gourry@gourry.net> In-Reply-To: <20250419053824.1601470-3-gourry@gourry.net> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2A7U08hc_kwsxFocq7pr5Yf38gqI_aBguURFxeTZRXs_1745109103 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6491220008 X-Stat-Signature: j6yqj5k9acffb4m6eu3bxn3zqxtuhn4o X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745109108-973042 X-HE-Meta: U2FsdGVkX1/R15BCqbAEQ6qowesvP8OCurDnoec6O+5L8zClCo7C2JiFS6/Vzo59m7mD6E0PK2HRIRcNTmNJ1Z/ScqZMSZeNyoF7W2ohIyRg6JdXfWlLLPVe6AZc8z6msxYPt8yq75CUR0HaXQsRuJPXtJ+1x7mgwjTck0auIMnmLXFJj0EiaiWnQXXATAT5U+Pl+bc/zml9apS6QYqRf++pHn3bykI5CPClQrBSPaMNsktTmN5PKLUXNEyupClFN0U19V3UXPodzv59gcf487SxU35VPXWDnVpR/1tZtZeZJGev0k3d/hVTG4Aw1Aex3ug1DhEHlUXdCJYrDttVl+MOtLmS/bhqA8UObdKMbnHx1mwz03s4SpmIo7TsOAmfX2YaUn3KBwlIAMZcN19R9jTMn7tWQ1iCqpAZDwRL0bMw723HOOXPCZWF4eJKcOm1rwxhvnaVwylolAHc9DJggbGd0taCUgnRDdABwPnoMVIJh0SyDcN4Vd+3ExXoulFuXeHDH5JkpiwGdH8V0c/uovuSfqS2lfHQmEiUKHcfxv4RabHRp55p2SyqK/7xTueIHhLOzd7OI8LEqX/nizezE74MRNERUsu+KEKcNqtn72sv0LB0HAVuOofJWVCDm1FxfGXtrCV0uP7Fh3xHxl6C+lT7fMCBCtxSpAahUg6qBLLyZ/k8+2s+Li0B6AaB3x7aC2eZZSZfUJJJ4Dhc3S1DAUBKgaBFEjVFU2lBMlIO5pDNyWKytxQWBbGdlsAY/6xbdiwWr00rwSbpzqCo+zXp2A4nHeI4H7Ux0cfe1M/96WvOwog9KVFlr8/hmV07s+khmSH2F61H7+xrYUyHSj81IRbN6r6ayV9R2eNR8BLkMaaO/PJiEZR3hNLnyEvssoQ8bX/Pf0Pbh+TxyedazTMJ0iFy8dqLUVCAs6FDjDZaaEOQ6WLKdC5AUba8+u3ujdh12stkqQP8W+XwEjyhyAc WeXB43GC 2Mcqd52hiAwVYAp3kc7M1l0rUNqAYPLUb0r0VgGqDZu/DK0B56jXtMfwJC7NM0BofOFHFzVbhd7zc6jKBzvSiTmcfeRvA2kFUx2DBOT/dYdpPskdBIsS9x/ZwSXR4kH0xSAJkjn00AJZw+x/Uh1DbNAHwo+OFwSj4SlW9iRG7uyK0py2VnMYgPCv+flV/XAgodl7oyZMLJ0CkCNlNtsYWAsIE7r4f+VS9nlnxaFi0vv1PeO5WkDfcsJYJ9enAWZX3UIAmvHWbAgLNnsAOVX486tLgGEak5IBuY36afYIl00ZjVddNiMdoVcuBKY+Q9k1KG/oqVJrqA+VTDhDsQI8PnkIzG4hWtIspiQ9zV6unyjmUaIhK1wPcbKXXkWRYSOZL+g6qQ4ZGD6r4FWBG/4jg4+VZixnkjLXsJBnTaiYFNfKMZzmxGcZsdXujmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/19/25 1:38 AM, Gregory Price wrote: > diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h > index 893a4c340d48..c64b4a174456 100644 > --- a/include/linux/cpuset.h > +++ b/include/linux/cpuset.h > @@ -171,6 +171,7 @@ static inline void set_mems_allowed(nodemask_t nodemask) > task_unlock(current); > } > > +extern bool cpuset_node_allowed(struct cgroup *cgroup, int nid); > #else /* !CONFIG_CPUSETS */ > > static inline bool cpusets_enabled(void) { return false; } > @@ -282,6 +283,10 @@ static inline bool read_mems_allowed_retry(unsigned int seq) > return false; > } > > +static inline bool cpuset_node_allowed(struct cgroup *cgroup, int nid) > +{ > + return false; > +} > #endif /* !CONFIG_CPUSETS */ I suppose we should return true in the !CONFIG_CPUSETS case. Other than that, the patch looks good to me. Cheers, Longman