From: kbuild test robot <fengguang.wu@intel.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
kbuild-all@01.org
Subject: [next:master 216/452] drivers/block/zram/zcomp.c:237:8-9: WARNING: return of 0/1 in function 'zcomp_strm_single_set_max_streams' with return type bool
Date: Tue, 18 Mar 2014 03:55:08 +0800 [thread overview]
Message-ID: <5327531c.fCek1K1FJ86yLrhi%fengguang.wu@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 609 bytes --]
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 8808b950581f71e3ee4cf8e6cae479f4c7106405
commit: 1dc40232c6515cf0eb4ce7650b3b703bb8eea82c [216/452] zram: propagate error to user
coccinelle warnings: (new ones prefixed by >>)
>> drivers/block/zram/zcomp.c:237:8-9: WARNING: return of 0/1 in function 'zcomp_strm_single_set_max_streams' with return type bool
Please consider folding the attached diff :-)
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
[-- Attachment #2: boolreturn-zcomp.patch --]
[-- Type: text/x-diff, Size: 1067 bytes --]
From: Fengguang Wu <fengguang.wu@intel.com>
Subject: [PATCH] zram: fix coccinelle warnings
TO: Stephen Rothwell <sfr@canb.auug.org.au>
CC: Minchan Kim <minchan@kernel.org>
CC: linux-kernel@vger.kernel.org
drivers/block/zram/zcomp.c:237:8-9: WARNING: return of 0/1 in function 'zcomp_strm_single_set_max_streams' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: coccinelle/misc/boolreturn.cocci
CC: Minchan Kim <minchan@kernel.org>
CC: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
cocci-output-25581-4ec682-zcomp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/block/zram/zcomp.c
+++ b/drivers/block/zram/zcomp.c
@@ -234,7 +234,7 @@ static void zcomp_strm_single_release(st
static bool zcomp_strm_single_set_max_streams(struct zcomp *comp, int num_strm)
{
/* zcomp_strm_single support only max_comp_streams == 1 */
- return 0;
+ return false;
}
static void zcomp_strm_single_destroy(struct zcomp *comp)
reply other threads:[~2014-03-17 19:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5327531c.fCek1K1FJ86yLrhi%fengguang.wu@intel.com \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox