From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99E40EB64DC for ; Sat, 1 Jul 2023 02:57:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C57F8E0062; Fri, 30 Jun 2023 22:57:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 376108E0059; Fri, 30 Jun 2023 22:57:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 264F58E0062; Fri, 30 Jun 2023 22:57:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 172CF8E0059 for ; Fri, 30 Jun 2023 22:57:59 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CA68640420 for ; Sat, 1 Jul 2023 02:57:58 +0000 (UTC) X-FDA: 80961533436.23.8D965F5 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf17.hostedemail.com (Postfix) with ESMTP id 2C65640014 for ; Sat, 1 Jul 2023 02:57:55 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf17.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688180276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8dLNprRkNIxnmx7sXCJmcalmskFOVN/B6DzwH8freQQ=; b=ITshiT+PYJazLaMOkO5TiO5ED4gYUCy4xRCj3L+uQOah/ZGq0yreq63yPRugTUbrxJaNLO SUfeh67jTq8BiMb1QDTyguus7jn8Tn015QW9IoPid7VOX44C0vWqD4BzsETp8QkN8J+CHt cTIpH1LyG4wJCCbCslG0OvwXAsRIKdA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf17.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688180276; a=rsa-sha256; cv=none; b=Eh821ZG7R014PdZw6vNTW2aHfevuiAgqfbxV9NKdwj1NOFdovWyFzAEfLlhSkQfmILUBKz hHvet3XzIzGq2EXozW17zYokXYB/+j7ADWD0pH/sW5qe4cn2TV5MqeL8YRzRpgiAUIUyTZ beCD23QMFy7CFqavYP4eI/rsHJg3xXQ= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4QtGyl2VkBzLn1h; Sat, 1 Jul 2023 10:55:43 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sat, 1 Jul 2023 10:57:50 +0800 Message-ID: <530c0778-577d-2476-24f4-612e80551d21@huawei.com> Date: Sat, 1 Jul 2023 10:57:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/2] mm: remove page_rmapping() Content-Language: en-US To: Sidhartha Kumar , , CC: , , , References: <20230630121310.165700-1-zhangpeng362@huawei.com> <20230630121310.165700-2-zhangpeng362@huawei.com> From: "zhangpeng (AS)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2C65640014 X-Stat-Signature: 88998tt1m9ms4zs1ufebgysqzmj5rt57 X-HE-Tag: 1688180275-327859 X-HE-Meta: U2FsdGVkX1/yUZgtMzakXWI2xecxTs/8Eq0YcEio/U5GfHknwuq1Iz1EUYaBvUKqv6GtgYAh85xns0/wQW7S4u0pj202bz7PqrVL0z94YnI3g2TD5FaEngW+6KsQbRCuU6lqVQW7sFaYS4x1q43qzT5leThxKDLmrZF9TQ65h8LK5xBe2vY5S0nL4MNs5r4WP6HFH2B24yuKj27OkJkAUxRDTHi/fVNrI8RvzEZFDcAzPu3NAEE+Rriie7Kp68b8yLkeMrvU7fBK+SYcoReto6qpMM9SmgjkwsNRkSNOR3suvvegp3LL5ijeFTVsn2yaHYU+Y36k23CWzu2Egjg6ezMI6MNUXGM7lvzsVuYDzTBkaOElis+YOqq8eRLidSJgLDxIcE+uCNT+chjToAzNrIEBkryt3FUAD06xS/eXH8LI18HvhLUwrUbFPEZRhHsROVMEzElsA65/iezQ5i3yRHmt+vXMlRWSzHa4sxHj1Vs4dH1HzcwvMhTXSle45KKwsey54xYbQ/HcfwOs0BNoVjCj1oMiUZ1poee1NHT2YqxPpRCBMFme1Tjb8NAI46TzJKrUTSRZ1h+XspTzl6VIrlVQorqmgma8kVdyxRNUyzzYElQ5fAcdXAtQq5uFy+rOueMmNRjIyI8MdX/26RDfoGccPNKP5bq0AQQcIZ0idVATmTKcjHaHB5O/utlfYMXBhBEzIKrI5qeugzAhpg6eQJy3ztP4rJIIsgzgy9K3xct3xuiaczN5Kcc3xE8TxBhLLnstvOrHD0tk8HNgd4B2AhCTta6NfdS5vws/vooDW7+/E+BnmM4kgNagVHaVMPwlfLMyoSAAvZc19rKXf9i111u4nH6sNyFvvlXQY7OSc0e3GNvORF56j1p5Lh46APJmm2GPSWBB5fUXjs62awjRBw2l0VqTifrRLQD9Zm95J6gdnW219TbbulKoM7raARGy0r8UUztmq8jcdJmK8Hb lBtHki9f hhyuq90/YFnwvWIjKiDc67oWqTGtaiq4rS0mdAftR9hxoUBR0oUvxOa3+gY6lW85/lqmucIK1eYRt20y4kikpALjX/+wL+a7X5ceAeLIUIkAPyQz7msr9B8dfeRoUXAeQ1tEwqgBYg9mAnM+pV+lv//bFZmLdErV4L8roKUrSmOJW7arAsG5x0CpyE8nu2yhi7IjpCm80v4D90nw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/1 0:03, Sidhartha Kumar wrote: > On 6/30/23 5:13 AM, Peng Zhang wrote: >> From: ZhangPeng >> >> After converting the last user to folio_raw_mapping(), we can safely >> remove the function. >> >> Signed-off-by: ZhangPeng >> --- >>   include/linux/mm.h | 1 - >>   mm/memory.c        | 2 +- >>   mm/util.c          | 6 ------ >>   3 files changed, 1 insertion(+), 8 deletions(-) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 9ecb8b9c07f6..8c7eba7370b2 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -2129,7 +2129,6 @@ static inline void *folio_address(const struct >> folio *folio) >>       return page_address(&folio->page); >>   } >>   -extern void *page_rmapping(struct page *page); >>   extern pgoff_t __page_file_index(struct page *page); >>     /* >> diff --git a/mm/memory.c b/mm/memory.c >> index 21fab2727209..6921df44a99f 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -2979,7 +2979,7 @@ static vm_fault_t >> fault_dirty_shared_page(struct vm_fault *vmf) >>        * pinned by vma->vm_file's reference.  We rely on unlock_page()'s >>        * release semantics to prevent the compiler from undoing this >> copying. >>        */ > > >     struct page *page = vmf->page; > >     ... > >     dirtied = set_page_dirty(page); >     VM_BUG_ON_PAGE(PageAnon(page), page); > > Can this earlier part of the function be converted to folios so a > folio can be passed directly in folio_raw_mapping()? Thanks for your feedback. I convert the last user to use a folio in patch 2. I'll reverse the order of the two patches. Best Regards, Peng >> -    mapping = page_rmapping(page); >> +    mapping = folio_raw_mapping(page_folio(page)); >>       unlock_page(page); >>         if (!page_mkwrite) >> diff --git a/mm/util.c b/mm/util.c >> index dd12b9531ac4..5e9305189c3f 100644 >> --- a/mm/util.c >> +++ b/mm/util.c >> @@ -734,12 +734,6 @@ void *vcalloc(size_t n, size_t size) >>   } >>   EXPORT_SYMBOL(vcalloc); >>   -/* Neutral page->mapping pointer to address_space or anon_vma or >> other */ >> -void *page_rmapping(struct page *page) >> -{ >> -    return folio_raw_mapping(page_folio(page)); >> -} >> - >>   struct anon_vma *folio_anon_vma(struct folio *folio) >>   { >>       unsigned long mapping = (unsigned long)folio->mapping; >