From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ea0-f172.google.com (mail-ea0-f172.google.com [209.85.215.172]) by kanga.kvack.org (Postfix) with ESMTP id 2986E6B00B7 for ; Tue, 25 Feb 2014 18:03:59 -0500 (EST) Received: by mail-ea0-f172.google.com with SMTP id l9so434110eaj.31 for ; Tue, 25 Feb 2014 15:03:58 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTP id a43si46207285eei.58.2014.02.25.15.03.57 for ; Tue, 25 Feb 2014 15:03:58 -0800 (PST) Message-ID: <530D2141.50707@redhat.com> Date: Tue, 25 Feb 2014 18:03:29 -0500 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 3/3] exec: kill the unnecessary mm->def_flags setting in load_elf_binary() References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Alex Thorlton , linux-kernel@vger.kernel.org Cc: Gerald Schaefer , Martin Schwidefsky , Heiko Carstens , Christian Borntraeger , Andrew Morton , Paolo Bonzini , "Kirill A. Shutemov" , Mel Gorman , Ingo Molnar , Peter Zijlstra , Andrea Arcangeli , Oleg Nesterov , "Eric W. Biederman" , Alexander Viro , linux390@de.ibm.com, linux-s390@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org On 02/25/2014 03:54 PM, Alex Thorlton wrote: > load_elf_binary() sets current->mm->def_flags = def_flags and > def_flags is always zero. Not only this looks strange, this is > unnecessary because mm_init() has already set ->def_flags = 0. > > Signed-off-by: Alex Thorlton > Suggested-by: Oleg Nesterov Acked-by: Rik van Riel -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org