From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B5D9C54FD3 for ; Wed, 25 Mar 2020 14:36:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 04CB220777 for ; Wed, 25 Mar 2020 14:36:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04CB220777 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8FF456B0005; Wed, 25 Mar 2020 10:36:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B0946B000C; Wed, 25 Mar 2020 10:36:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C5806B000D; Wed, 25 Mar 2020 10:36:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id 636AA6B0005 for ; Wed, 25 Mar 2020 10:36:27 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 328DE252A8 for ; Wed, 25 Mar 2020 14:36:27 +0000 (UTC) X-FDA: 76634135214.04.soap51_8f9dfcf60e52f X-HE-Tag: soap51_8f9dfcf60e52f X-Filterd-Recvd-Size: 2573 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Mar 2020 14:36:26 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 38A0DAC50; Wed, 25 Mar 2020 14:36:24 +0000 (UTC) Subject: Re: [RFC v2 2/2] kernel/sysctl: support handling command line aliases To: Michal Hocko Cc: Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" References: <20200325120345.12946-1-vbabka@suse.cz> <20200325120345.12946-2-vbabka@suse.cz> <20200325142936.GC19542@dhcp22.suse.cz> From: Vlastimil Babka Message-ID: <52faea3b-6442-3b1b-9404-6a018d1d1c44@suse.cz> Date: Wed, 25 Mar 2020 15:36:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200325142936.GC19542@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/25/20 3:29 PM, Michal Hocko wrote: > Both patches look really great to me. I haven't really checked all the > details but from a quick glance they both seem ok. Thanks. > I would just add a small clarification here. Unless I am mistaken > early_param is called earlier than it would be now. But that shouldn't > cause any problems because the underlying implementation is just a noop > for backward compatibility. Yeah, indeed worth noting somewhere explicitly. The conversion can't be done blindly, one has to consider whether the delay compared to early_param can be a disadvantage or not. For example the nmi_watchdog parameter is probably best left as it is? > Thanks a lot this looks like a very nice improvement. > > On Wed 25-03-20 13:03:45, Vlastimil Babka wrote: > [...] >> -static __init int setup_numa_zonelist_order(char *s) >> -{ >> - if (!s) >> - return 0; >> - >> - return __parse_numa_zonelist_order(s); >> -} >> -early_param("numa_zonelist_order", setup_numa_zonelist_order); >> - >> char numa_zonelist_order[] = "Node"; >> >> /* >> -- >> 2.25.1 >