From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 397A6C25B0E for ; Fri, 19 Aug 2022 05:04:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6264A8D0003; Fri, 19 Aug 2022 01:04:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D61B8D0002; Fri, 19 Aug 2022 01:04:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44FB88D0003; Fri, 19 Aug 2022 01:04:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 302458D0002 for ; Fri, 19 Aug 2022 01:04:47 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 08A6BAC06C for ; Fri, 19 Aug 2022 05:04:47 +0000 (UTC) X-FDA: 79815152214.21.C6A552C Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf25.hostedemail.com (Postfix) with ESMTP id CBFA3A0018 for ; Fri, 19 Aug 2022 05:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660885485; x=1692421485; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=jT/V1Oq+Rg+Eo8agblaIydGU66xOG6UOauXF3aCL6/I=; b=dM7kAZ7carAUxatJ3w3lsu1VPSwFDptpUj83DBsQzAn7oI6bW7TpVdNS R7CH8k7F6+CBhnFMaYe2w5izxIBEVXOhKtu1eBHeZNtndYsVC46AEekKK W/g2L9cEgsGfFZKS3++klS8DVwWI/Ezgqt3WeqMhEzMEJb4H0db+WUjc9 rRRXwANF7A28hbS6mCUa2wjd31DrAE0losYCYELQOWpzchu8+DckVS0ze 5EPzrG5V1tX897rNueoklVI63z/6cXyN8lXQuJKJc9U4ayZOpXlPrAHxI ZJNsqEflY9oIi+saFJnTghDXBztTiOF/35rKuPwEYryQQooMe3DHi0zwF g==; X-IronPort-AV: E=McAfee;i="6500,9779,10443"; a="292933098" X-IronPort-AV: E=Sophos;i="5.93,247,1654585200"; d="scan'208";a="292933098" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2022 22:04:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,247,1654585200"; d="scan'208";a="711212599" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 18 Aug 2022 22:04:43 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 18 Aug 2022 22:04:43 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 18 Aug 2022 22:04:42 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 18 Aug 2022 22:04:42 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Thu, 18 Aug 2022 22:04:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hvfjz8BktiJsSa+ZoQI5Pzw+d1HBPLHDOLMAI+hQ3Lf8KjMS2lFmk5PhsNTDcwol+qwLt1zLpxNkIZMlL/DGJp62rFQuEuR1fm0L1kCZoYodJNmR2mJX3kVaJxt7ihHr2Ez5ClayQPHWMGdQodKx/TjwCtUd4CoBa5JjnNcsflBKdUyM5WfA/5e5I8SUaHBUFM43N4Wxx+yo55TEJLjP74PLdCD0RAka7keQ1Iye49y/q/3MJpVvMiV+LmKQSI+I7kp3Y178iD7YVKkQ/kfiRpNo6EXzid77FG6CxyQS52rfuPi84oGlvuGhoxZk17GjoSVibt4+qS9veAl+6NQO9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cgF0GSb3+bPc/QEdxLOuHhK5csZCTcatodfwpl+hJSU=; b=RWZIENdKxYjBykSuCNpZvtuQd5r2nNQVRqQl2ofeqcga+XutmRotPY8Sju0REloR+RJIbSP4LmYEeYDfUG32TkcpzbyGs/pflAYb2SWLj19Sc2ytFexRzXLqwhiDH+pRyDffqGA6so9sxYQY4iLeiJucxVWZRvah+EebNxG99aKEffxP3l/XPxIVZXECZW8OfM7JgnWg8WMGx5fv7M+R6NkHCNqJ1TpAkfty9RhoqxEr9Ud5aBOyJwuCB79obAbW7ERLXbLeFxjDMe5sa3EngEp1G+TzeBvA3cnwoDTyp+YNz/fMrWVa8iikKz0PsVehFWsSANEQzBWNwR8tDGDJzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by CY8PR11MB6940.namprd11.prod.outlook.com (2603:10b6:930:58::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.18; Fri, 19 Aug 2022 05:04:32 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::fcda:4c77:5786:209c]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::fcda:4c77:5786:209c%4]) with mapi id 15.20.5546.018; Fri, 19 Aug 2022 05:04:32 +0000 Message-ID: <52f4b69a-86f8-5051-29e1-8da0b6ed312d@intel.com> Date: Fri, 19 Aug 2022 13:04:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.12.0 Subject: Re: [PATCH v3] mm: release private data before split THP Content-Language: en-US From: "Yin, Fengwei" To: , , , , , Andrew Morton CC: , , References: <20220810064907.582899-1-fengwei.yin@intel.com> In-Reply-To: <20220810064907.582899-1-fengwei.yin@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR02CA0077.apcprd02.prod.outlook.com (2603:1096:4:90::17) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 72b403fc-c957-45b7-aaf1-08da81a04d45 X-MS-TrafficTypeDiagnostic: CY8PR11MB6940:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yvNnkwF+fYZkhJSkSJ+b0YCHBt7HRzHRGh+u3cziXMyaksaz3qUFSGO0/1mKviv+JIXPjHmfwazNTeSlRRVTDpaLbc8ejNrQ6k4E+fwsjbjVDD5reDpjOe5c3KkOIDbbNRIFIeNeDl0CxLm/ZVRVt5GDgMPGSaVVSSv9ZFVSCTyyxgXH1cZQTfkH6kbMasws2W4f24yZwrZH6wAcrECfzkdSjNKF9yEwMWYWVcBk+oiZS/IVPwGL6KgFxDASrwOdKPVDZ1fX8DfuYkWjKvvh7wAucN5oONj2SPmktrzVRe9wlFAQJrCsAcMdtRUGOiIwq9JrKuqjA5nzWA3QN87xCu9mRbSRdHz+Jj6X1s9jwoCxLLTULebgwwUUzeRLSldF/5TVQ+AMnn9wF7MTQQv3Iqwipkk4oSPUNH5IlgJ7cQL5NHOtvZiFX/Fm6Vkw6FbgaI0bL9B1CjwDHC9ggOj088nshHasTuDLRE6VAkZnsRRJmCEZBD/AoHsVUeA8KwTiFIUO+XQUNG6gyPSHTHNWtgT5u3jIafu25yKk1dndtFA7VqqLNTSaEikkZhp2j9O3fTVwo8ZfUL0S47pkdRGeUxonMpl2J5PlMBJ7pzVZwGZQvOjkeLkZTgi7svWVRQ4S3S/2noyez+dOutohuwrWF4nlrjGcSsqKFkB1qSI/ZfC44ChEPsj7jBqIGVTXhYgon2OB/W5K0aGpRW+5BUq6Lk+8QCy4uJySWGuMFg6Ov19a38Nyu2Y25qVO5ygD/5kE+mBLXxs9F2yWUYVmtPcj36rnhdB8sTky2N2V7088FEPCKH1vUaXnOKJXIuxaLpA9bFc7rjivDLQKoyhWqFth9xfAmZpBqOYAzzpIR3/dtqI4KB/uhOhkH6XsoNNE00lU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(346002)(396003)(366004)(136003)(83380400001)(82960400001)(38100700002)(66946007)(66556008)(8676002)(4326008)(6916009)(66476007)(316002)(8936002)(5660300002)(6512007)(26005)(53546011)(6666004)(6506007)(2616005)(107886003)(186003)(41300700001)(6486002)(31686004)(966005)(478600001)(2906002)(36756003)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWs0bGpwNWg5WEpYUXlIVlJmVFRuRlExdlhBYThYWXpvN25WV2QrMzNna2hI?= =?utf-8?B?WVRTNE9HaGZYM0ZtZXVscjBhckRSTUlEM0h0d1FhOFJQNkd0dURNS0hidjFa?= =?utf-8?B?Y1VlVDU4Y0dvSWcrdUdDUlE1TWZ1MHdnYTJBUm53U0pZdTR4cVhaZG45TDZz?= =?utf-8?B?bjRXYXNjK0hFaC9ZZkt5cmx5V1RNa3REaWZZR3V6WldvaDNUWk9ONHUvMnk5?= =?utf-8?B?cS9tL29LSkZmbWhEeTJNZ1B1SVVRdXByUVJsQlhJRGppK2lIWnV1UVRzalh6?= =?utf-8?B?MjNkZzNYdHByWkVVU2tobTdvNG5PbTNpWjl1QXRHSlkwTEdxYUFLbU1TQ05k?= =?utf-8?B?dzUvMkQzajIrcHZnWlZLMFdkeHBmd01LNnpQMVJySDlSSlM1cHoyT1UvLzd3?= =?utf-8?B?dFlOMXgra3FUL2tYNWtBdGVNRUJIY3A0Y0JGN0tCVkljQ0NmcUE0cGVmaTRQ?= =?utf-8?B?YlRxMCtSU2RESjlyY3dqWWQ5UkpNTCt4UjZvN09od0dhMjY4MURhRDBCa1hN?= =?utf-8?B?aHdUazFrdGc3QXdqTzhjK2lVYUJSdmFka3pySTZ2cnVaeHR4NE5LdnNPNjV1?= =?utf-8?B?eDVUSGpYdTFCOU5PRER0c1Bqc21yZVlWVUUzcGEvTXlLUnFIUmJkUDI1Sjhw?= =?utf-8?B?dEVsMnpreVUwNlEyT0IwdGdacUw0WlFJQVJHOFFGMkhGQko0UWk0TXNMSnJZ?= =?utf-8?B?TUpCaUErN01YUmcxcFZFVnZRaVpuOTkwVzlYa1FISml6S0FnUURhMlZEL0Yy?= =?utf-8?B?ZHlHSE54c1RmR2xPcWtTc1p5bVp3ckYvOGh5Y2ZqRTNqTlA0UUdORE5hOE1z?= =?utf-8?B?U08yTTRjV3Z4Sk00SEZMUUVYK0F2bzFWcS9IUGxrQlhoZjVJb2RRcWlHS1VO?= =?utf-8?B?MHdsVTlHNVoxNW9RSWR3ek03YUxCdm9LQzRQS1dpZmI4czFaODIyanB4TlBl?= =?utf-8?B?enlkU2s3TGpqdjB5ZHJ0cWcraEhsQ3hHMzJZZTBSQko0Rjl6RXZZdG9YSjE3?= =?utf-8?B?SlJYOC9EUnpkTmZnY1YwTE1UYzlpdVNmcHpzS0Vsd0JCYnVCNk9XZlNDamVV?= =?utf-8?B?VEZqSkRLVWRPb3RteWdzNVlkeGZ5M2xDN3RlbWkzQVRWamhsL2E3KzU0cyt3?= =?utf-8?B?VFhSTm5kVW83VW10T2pnOW8wZy9rcGFGSlFDc3FUV2RrcnlMai9iaGRJQ0Ro?= =?utf-8?B?SW5iMWtOUkdaclVrMFh3MSs4dGZRTlpQQWh0d3pCYmd0SzRvc2FWdkRjSE9Y?= =?utf-8?B?RHY5UEhLRlhob2trWXg3aWw1MDcyOTR4NVJxcDNER0IyRW5xQ3ZpUzV6eXJ0?= =?utf-8?B?Ti9EWDZ0MXNidFVKMFREVDAxRVVDckNvSXl4bll2RzM4RTVnVTlJWHUzM3dn?= =?utf-8?B?YUpmQTFwMTRwNHp3Ym91eWNiNHZEUDJLMWlEM2diWDBOcEtOVlNnT0xCSFgx?= =?utf-8?B?TXdqSWNTQ1YvMlV0U2g0anozVG5xeVIvQmptMS8wMFhhQ3RmSDBOQ0FDYmpQ?= =?utf-8?B?SWJmemlvZHdVMllmRjh6eVR3c1RIM25wbHJwVHFQMFRhLy93T3J1Y3o3QXNv?= =?utf-8?B?UmFNOGRBTURXSk5zaWhPRzR0RURpTTJrNnp0Zy93dEhaOUNGNlF3V0x5dEp3?= =?utf-8?B?bHRhRFlZOWdMWVN4dm1OK2hoaGdPbGhYOG0yL0RNL2JJRWxqaTNNNXVxcjZn?= =?utf-8?B?MHRvWDduU1g0SE9CNW9Sa2F6Z3Rld1NpZzMrdDFSWjVNY0dqTnVqYlEzVURL?= =?utf-8?B?UERrR2VDRzNWOWJDM2hzSDVkL3c5YXJCbk1EV0craVpZemJBSzdIR0c5M3Fr?= =?utf-8?B?R0ZKdDRNS1NvN3FEYTJXcE0zaVA4OXJpQXdOUUk1Y05Wem5UbkNsSkpkR3c3?= =?utf-8?B?OVl2ZUljdVRpb3l2M0U1Q0xQaSs4YVFyV3liWHl4NDlZd0FMZzlLT0JOYkJB?= =?utf-8?B?YmhiZlpwNkdXZUEwNk9lV1pEdlFIQys0Ymh1Z0RRbjJCbUVMOFBQSFJvQ0t1?= =?utf-8?B?U0JUdUxQaGtxUVRTQXBXUitzbUZxYlVIWGNhblB3ME4zTWNsNUQ4VXpHbFFC?= =?utf-8?B?bjMvOHFOOXFqcmNZdlVyaXZ0S0ZYRHdqNjhUSlFGaWQrZkozWlV5Z0pvclpN?= =?utf-8?B?ZStVckttazBXalFLQ1RjSXBIYjZpeW9aV0UyWHIvQ2lJNnFnZ2plVmd5Ylpi?= =?utf-8?B?SHc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 72b403fc-c957-45b7-aaf1-08da81a04d45 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 05:04:32.0163 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3aNbyplGSOqsBfov6vzIWRuRYdC0HddAyfXZADaY8UEyGDZrSW3+Q2t0u+AbdyC1GH4OIMPIMLk409upWLtXpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6940 X-OriginatorOrg: intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1660885486; a=rsa-sha256; cv=fail; b=PbQB+ldbmV/AvR4z7xOC+9GsUG2e2wiNXj/d8tQJCR8Nw53x4kXx2rqm36vs+umTf04yyy noq0HPHU9eVTPqla/gmbFqDopuWexaq/QYGJKpfHZFK7mSfacY74W7dR6/GgXjxxwyyfUs a3EO+MSnFqg1VGsOCnmGDBUlWPHJeyg= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=dM7kAZ7c; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf25.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660885486; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cgF0GSb3+bPc/QEdxLOuHhK5csZCTcatodfwpl+hJSU=; b=IALVZwKS21Ar26JnS8IXBb3BsZ+G5gd+yZ5n2MEkL4dt8MXrT1kZO6dQ0sMzrqYGyyHcb4 FAcnUkhrHFRl4MmqgckLdrHxAMZT5fYnYHurmZ8MO/9ZAh5EiBcLEzsigKy4mO+qp9oB5s rBWv26AAXdf1DbQE5rj6Ama4kXVbXrQ= Authentication-Results: imf25.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=dM7kAZ7c; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf25.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com X-Rspam-User: X-Stat-Signature: g6hey8zai633bfkktz1tt7za4m5qxmuz X-Rspamd-Queue-Id: CBFA3A0018 X-Rspamd-Server: rspam03 X-HE-Tag: 1660885485-565039 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, > On 8/10/2022 2:49 PM, Yin Fengwei wrote: Sorry for pinging you here. I suppose all the review comments were addressed so far. To make this patch merged, any other action I need to take? Thanks. v1 is on: https://lore.kernel.org/linux-mm/20220804025121.4001361-1-fengwei.yin@intel.com/ v2 is on: https://lore.kernel.org/linux-mm/20220805062844.439152-1-fengwei.yin@intel.com/ v3 is on: https://lore.kernel.org/linux-mm/20220810064907.582899-1-fengwei.yin@intel.com/ Regards Yin, Fengwei > If there is private data attached to THP, the refcount of > THP will be increased and block the THP split. Release > private data attached to THP before split it to increase > the chance of splitting THP successfully. > > There was a memory failure issue hit during HW error > injection testing with 5.18 kernel + xfs as rootfs. Test > got killed and system reboot was required to re-run the > test. > > The issue was tracked down to THP split failure caused the > memory failure not being handled. The page dump showed: > > [ 1785.433075] page:0000000025f9530b refcount:18 mapcount:0 mapping:000000008162eea7 index:0xa10 pfn:0x2f0200 > [ 1785.443954] head:0000000025f9530b order:4 compound_mapcount:0 compound_pincount:0 > [ 1785.452408] memcg:ff4247f2d28e9000 > [ 1785.456304] aops:xfs_address_space_operations ino:8555182 dentry name:"baseos-filenames.solvx" > [ 1785.466612] flags: 0x1000000000012036(referenced|uptodate|lru|active|private|head|node=0|zone=2) > [ 1785.476514] raw: 1000000000012036 ffb9460f8bc07c08 ffb9460f8bc08408 ff4247f22e6299f8 > [ 1785.485268] raw: 0000000000000a10 ff4247f194ade900 00000012ffffffff ff4247f2d28e9000 > > It was like the error was injected to a large folio for xfs > with private data attached. > > With private data released before split THP, the test case > could be run successfully many times without reboot system. > > Co-developed-by: Qiuxu Zhuo > Signed-off-by: Qiuxu Zhuo > Signed-off-by: Yin Fengwei > Suggested-by: Matthew Wilcox > --- > Changelog from v2: > - Use safe gfp flags for different callsite of split_huge_page_to_list > per Yang's comment. > - Remove reviewed-by tag from Aaron which was only valid for RFC patch > but keep it by mistake. > > Changelog from v1: > - Move private release to split_huge_page_to_list > to cover wider path per Yang's comment. > - Update to commit message. > > Changelog from RFC: > - Use new folio API per Mathhew Wilcox's suggestion. > - Add one line comment before re-get folio of page per > Miaohe's comment. > - Remove RFC tag > - Add Co-developed-by of Qiuxu who did a lot of debugging > work to locate where the real issue is. > mm/huge_memory.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 8a7c1b344abe..ae8c4e209e58 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2627,6 +2627,8 @@ int split_huge_page_to_list(struct page *page, struct list_head *list) > mapping = NULL; > anon_vma_lock_write(anon_vma); > } else { > + gfp_t gfp; > + > mapping = head->mapping; > > /* Truncated ? */ > @@ -2635,8 +2637,16 @@ int split_huge_page_to_list(struct page *page, struct list_head *list) > goto out; > } > > - xas_split_alloc(&xas, head, compound_order(head), > - mapping_gfp_mask(mapping) & GFP_RECLAIM_MASK); > + gfp = current_gfp_context(mapping_gfp_mask(mapping) & > + GFP_RECLAIM_MASK); > + > + if (folio_test_private(folio) && > + !filemap_release_folio(folio, gfp)) { > + ret = -EBUSY; > + goto out; > + } > + > + xas_split_alloc(&xas, head, compound_order(head), gfp); > if (xas_error(&xas)) { > ret = xas_error(&xas); > goto out; > > base-commit: d4252071b97d2027d246f6a82cbee4d52f618b47