linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov@parallels.com>
To: hannes@cmpxchg.org, mhocko@suse.cz, cl@linux-foundation.org
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [PATCH RFC 2/3] percpu-refcount: allow to get dead reference
Date: Tue, 13 May 2014 17:48:52 +0400	[thread overview]
Message-ID: <52edf96a623197ed3c947dfa8b216ec0540d6460.1399982635.git.vdavydov@parallels.com> (raw)
In-Reply-To: <cover.1399982635.git.vdavydov@parallels.com>

Currently percpu_ref_tryget fails after percpu_ref_kill is called, even
if refcnt != 0. In the next patch I need a method to get a ref that will
only fail if refcnt == 0, so let's extend the interface to percpu ref a
bit to allow that.

Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
---
 include/linux/percpu-refcount.h |   11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/include/linux/percpu-refcount.h b/include/linux/percpu-refcount.h
index 95961f0bf62d..7729e59b9cb7 100644
--- a/include/linux/percpu-refcount.h
+++ b/include/linux/percpu-refcount.h
@@ -129,7 +129,8 @@ static inline void percpu_ref_get(struct percpu_ref *ref)
  * used.  After the confirm_kill callback is invoked, it's guaranteed that
  * no new reference will be given out by percpu_ref_tryget().
  */
-static inline bool percpu_ref_tryget(struct percpu_ref *ref)
+static inline bool __percpu_ref_tryget(struct percpu_ref *ref,
+				       bool maybe_dead)
 {
 	unsigned __percpu *pcpu_count;
 	int ret = false;
@@ -141,13 +142,19 @@ static inline bool percpu_ref_tryget(struct percpu_ref *ref)
 	if (likely(REF_STATUS(pcpu_count) == PCPU_REF_PTR)) {
 		__this_cpu_inc(*pcpu_count);
 		ret = true;
-	}
+	} else if (maybe_dead && unlikely(atomic_read(&ref->count)))
+		ret = atomic_inc_not_zero(&ref->count);
 
 	rcu_read_unlock_sched();
 
 	return ret;
 }
 
+static inline bool percpu_ref_tryget(struct percpu_ref *ref)
+{
+	return __percpu_ref_tryget(ref, false);
+}
+
 /**
  * percpu_ref_put - decrement a percpu refcount
  * @ref: percpu_ref to put
-- 
1.7.10.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2014-05-13 13:48 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 13:48 [PATCH RFC 0/3] kmemcg slab reparenting Vladimir Davydov
2014-05-13 13:48 ` [PATCH RFC 1/3] slub: keep full slabs on list for per memcg caches Vladimir Davydov
2014-05-14 16:16   ` Christoph Lameter
2014-05-15  6:34     ` Vladimir Davydov
2014-05-15 15:15       ` Christoph Lameter
2014-05-16 13:06         ` Vladimir Davydov
2014-05-16 15:05           ` Christoph Lameter
2014-05-13 13:48 ` Vladimir Davydov [this message]
2014-05-13 13:48 ` [PATCH RFC 3/3] slub: reparent memcg caches' slabs on memcg offline Vladimir Davydov
2014-05-14 16:20   ` Christoph Lameter
2014-05-15  7:16     ` Vladimir Davydov
2014-05-15 15:16       ` Christoph Lameter
2014-05-16 13:22         ` Vladimir Davydov
2014-05-16 15:03           ` Christoph Lameter
2014-05-19 15:24             ` Vladimir Davydov
2014-05-19 16:03               ` Christoph Lameter
2014-05-19 18:27                 ` Vladimir Davydov
2014-05-21 13:58                   ` Vladimir Davydov
2014-05-21 14:45                     ` Christoph Lameter
2014-05-21 15:14                       ` Vladimir Davydov
2014-05-22  0:15                         ` Christoph Lameter
2014-05-22 14:07                           ` Vladimir Davydov
2014-05-21 14:41                   ` Christoph Lameter
2014-05-21 15:04                     ` Vladimir Davydov
2014-05-22  0:13                       ` Christoph Lameter
2014-05-22 13:47                         ` Vladimir Davydov
2014-05-22 19:25                           ` Christoph Lameter
2014-05-23 15:26                             ` Vladimir Davydov
2014-05-23 17:45                               ` Christoph Lameter
2014-05-23 19:57                                 ` Vladimir Davydov
2014-05-27 14:38                                   ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52edf96a623197ed3c947dfa8b216ec0540d6460.1399982635.git.vdavydov@parallels.com \
    --to=vdavydov@parallels.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox