From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com [209.85.192.182]) by kanga.kvack.org (Postfix) with ESMTP id BEC576B0037 for ; Thu, 23 Jan 2014 08:25:30 -0500 (EST) Received: by mail-pd0-f182.google.com with SMTP id v10so1760625pde.41 for ; Thu, 23 Jan 2014 05:25:30 -0800 (PST) Received: from mga03.intel.com (mga03.intel.com. [143.182.124.21]) by mx.google.com with ESMTP id nu5si14105884pbc.328.2014.01.23.05.25.28 for ; Thu, 23 Jan 2014 05:25:29 -0800 (PST) Date: Thu, 23 Jan 2014 21:25:01 +0800 From: kbuild test robot Subject: mm/rmap.c:851:9-10: WARNING: return of 0/1 in function 'invalid_mkclean_vma' with return type bool Message-ID: <52e1182d.5UX4ApvQfKmrhsjc%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_52e1182d.qxPMq3TpG6zFd/lZnpuyPKGqwjP5SFh+AtT0S7HHVBgkF5SP" Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: Linux Memory Management List , Andrew Morton , kbuild-all@01.org This is a multi-part message in MIME format. --=_52e1182d.qxPMq3TpG6zFd/lZnpuyPKGqwjP5SFh+AtT0S7HHVBgkF5SP Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0dc3fd0249a295863900984e02dd4bb89204205b commit: 9853a407b97d8d066b5a865173a4859a3e69fd8a mm/rmap: use rmap_walk() in page_mkclean() date: 2 days ago coccinelle warnings: (new ones prefixed by >>) >> mm/rmap.c:851:9-10: WARNING: return of 0/1 in function 'invalid_mkclean_vma' with return type bool Please consider folding the attached diff :-) --- 0-DAY kernel build testing backend Open Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation --=_52e1182d.qxPMq3TpG6zFd/lZnpuyPKGqwjP5SFh+AtT0S7HHVBgkF5SP Content-Type: text/x-diff; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="boolreturn-rmap.patch" From: Fengguang Wu Subject: [PATCH] mm/rmap: fix coccinelle warnings TO: Linus Torvalds CC: Joonsoo Kim CC: linux-kernel@vger.kernel.org mm/rmap.c:851:9-10: WARNING: return of 0/1 in function 'invalid_mkclean_vma' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: coccinelle/misc/boolreturn.cocci CC: Joonsoo Kim CC: Linus Torvalds Signed-off-by: Fengguang Wu --- cocci-output-10204-4a1ebb-rmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/mm/rmap.c +++ b/mm/rmap.c @@ -848,9 +848,9 @@ out: static bool invalid_mkclean_vma(struct vm_area_struct *vma, void *arg) { if (vma->vm_flags & VM_SHARED) - return 0; + return false; - return 1; + return true; } int page_mkclean(struct page *page) --=_52e1182d.qxPMq3TpG6zFd/lZnpuyPKGqwjP5SFh+AtT0S7HHVBgkF5SP-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org