linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <fengguang.wu@intel.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	kbuild-all@01.org
Subject: mm/rmap.c:851:9-10: WARNING: return of 0/1 in function 'invalid_mkclean_vma' with return type bool
Date: Thu, 23 Jan 2014 21:25:01 +0800	[thread overview]
Message-ID: <52e1182d.5UX4ApvQfKmrhsjc%fengguang.wu@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   0dc3fd0249a295863900984e02dd4bb89204205b
commit: 9853a407b97d8d066b5a865173a4859a3e69fd8a mm/rmap: use rmap_walk() in page_mkclean()
date:   2 days ago


coccinelle warnings: (new ones prefixed by >>)

>> mm/rmap.c:851:9-10: WARNING: return of 0/1 in function 'invalid_mkclean_vma' with return type bool

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[-- Attachment #2: boolreturn-rmap.patch --]
[-- Type: text/x-diff, Size: 967 bytes --]

From: Fengguang Wu <fengguang.wu@intel.com>
Subject: [PATCH] mm/rmap: fix coccinelle warnings
TO: Linus Torvalds <torvalds@linux-foundation.org>
CC: Joonsoo Kim <iamjoonsoo.kim@lge.com>
CC: linux-kernel@vger.kernel.org 

mm/rmap.c:851:9-10: WARNING: return of 0/1 in function 'invalid_mkclean_vma' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: coccinelle/misc/boolreturn.cocci

CC: Joonsoo Kim <iamjoonsoo.kim@lge.com>
CC: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 cocci-output-10204-4a1ebb-rmap.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -848,9 +848,9 @@ out:
 static bool invalid_mkclean_vma(struct vm_area_struct *vma, void *arg)
 {
 	if (vma->vm_flags & VM_SHARED)
-		return 0;
+		return false;
 
-	return 1;
+	return true;
 }
 
 int page_mkclean(struct page *page)

                 reply	other threads:[~2014-01-23 13:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52e1182d.5UX4ApvQfKmrhsjc%fengguang.wu@intel.com \
    --to=fengguang.wu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=kbuild-all@01.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox