From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C5B0C433E7 for ; Mon, 13 Jul 2020 16:36:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 101F720738 for ; Mon, 13 Jul 2020 16:36:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="fNpeW/b9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 101F720738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A09D08D0007; Mon, 13 Jul 2020 12:36:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B86E8D0001; Mon, 13 Jul 2020 12:36:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 880358D0007; Mon, 13 Jul 2020 12:36:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id 6C1C18D0001 for ; Mon, 13 Jul 2020 12:36:33 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2E15E2C12 for ; Mon, 13 Jul 2020 16:36:33 +0000 (UTC) X-FDA: 77033605866.19.shape19_5514ff326ee9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 0545A1ACEAD for ; Mon, 13 Jul 2020 16:36:32 +0000 (UTC) X-HE-Tag: shape19_5514ff326ee9 X-Filterd-Recvd-Size: 5763 Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Jul 2020 16:36:32 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 13 Jul 2020 09:36:17 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 13 Jul 2020 09:36:30 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 13 Jul 2020 09:36:30 -0700 Received: from rcampbell-dev.nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 13 Jul 2020 16:36:17 +0000 Subject: Re: [PATCH v2 19/22] mm/memremap_pages: Convert to 'struct range' To: Dan Williams , CC: Paul Mackerras , Michael Ellerman , Benjamin Herrenschmidt , Vishal Verma , Dave Jiang , Ben Skeggs , David Airlie , Daniel Vetter , Ira Weiny , Jason Gunthorpe , , , , , , , , References: <159457116473.754248.7879464730875147365.stgit@dwillia2-desk3.amr.corp.intel.com> <159457126779.754248.3575056680831729751.stgit@dwillia2-desk3.amr.corp.intel.com> From: Ralph Campbell X-Nvconfidentiality: public Message-ID: <52e00a67-b686-8554-8b92-a172ba9f34b6@nvidia.com> Date: Mon, 13 Jul 2020 09:36:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <159457126779.754248.3575056680831729751.stgit@dwillia2-desk3.amr.corp.intel.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1594658177; bh=pEu43f6TYC38teVwUvS5veiq+jHDv/8kh2CbYzLWE6U=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=fNpeW/b9FMcDuL8oBoNL4fjzJoqpiaHBjJ5dsdIG5lrR+4Y/gb8oxeR9pNqs5p58E jg/E8fTCGVG/pvYTlGNYMJ4np0poYz626qjoxbOuxMSk67Oh9xeDZjp9Dlx+JvN/yI anmR/T+xHKXScxT+q/iQrtkW+yLeCbIRALu8t1RHIL23PtB5Gt3fPRk3mkNbf55HbY rurMSczEzdbFa7CP+/s/hv3jIlWgQnc/l3MXL6dU1kdaK+Pru79j771P+5fyYyqL5O XSYWgz3RPaAQhvk7/olB0odRYdNQkhmC2b55QRVX3q2JPs4J6+AQSE73bzRJ26O6Q9 P7158pxFYmDSQ== X-Rspamd-Queue-Id: 0545A1ACEAD X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/12/20 9:27 AM, Dan Williams wrote: > The 'struct resource' in 'struct dev_pagemap' is only used for holding > resource span information. The other fields, 'name', 'flags', 'desc', > 'parent', 'sibling', and 'child' are all unused wasted space. > > This is in preparation for introducing a multi-range extension of > devm_memremap_pages(). > > The bulk of this change is unwinding all the places internal to > libnvdimm that used 'struct resource' unnecessarily. > > P2PDMA had a minor usage of the flags field, but only to report failures > with "%pR". That is replaced with an open coded print of the range. > > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Dan Williams > Cc: Vishal Verma > Cc: Dave Jiang > Cc: Ben Skeggs > Cc: David Airlie > Cc: Daniel Vetter > Cc: Ira Weiny > Cc: Jason Gunthorpe > Signed-off-by: Dan Williams > --- > arch/powerpc/kvm/book3s_hv_uvmem.c | 13 +++-- > drivers/dax/bus.c | 10 ++-- > drivers/dax/bus.h | 2 - > drivers/dax/dax-private.h | 5 -- > drivers/dax/device.c | 3 - > drivers/dax/hmem/hmem.c | 5 ++ > drivers/dax/pmem/core.c | 12 ++--- > drivers/gpu/drm/nouveau/nouveau_dmem.c | 3 + > drivers/nvdimm/badrange.c | 26 +++++------ > drivers/nvdimm/claim.c | 13 +++-- > drivers/nvdimm/nd.h | 3 + > drivers/nvdimm/pfn_devs.c | 12 ++--- > drivers/nvdimm/pmem.c | 26 ++++++----- > drivers/nvdimm/region.c | 21 +++++---- > drivers/pci/p2pdma.c | 11 ++--- > include/linux/memremap.h | 5 +- > include/linux/range.h | 6 ++ > mm/memremap.c | 77 ++++++++++++++++---------------- > tools/testing/nvdimm/test/iomap.c | 2 - > 19 files changed, 135 insertions(+), 120 deletions(-) I think you are missing a call to memremap_pages() in lib/test_hmm.c and a call to release_mem_region() that need to be converted too. Try setting CONFIG_TEST_HMM=m. Also, what about the call to release_mem_region() in drivers/gpu/drm/nouveau/nouveau_dmem.c? Doesn't that need a small change too?