From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B31FC7EE22 for ; Tue, 16 May 2023 00:39:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 889E7900004; Mon, 15 May 2023 20:39:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 839CB900002; Mon, 15 May 2023 20:39:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70116900004; Mon, 15 May 2023 20:39:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5D7D2900002 for ; Mon, 15 May 2023 20:39:37 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 32CF11C8CA6 for ; Tue, 16 May 2023 00:39:37 +0000 (UTC) X-FDA: 80794259994.15.CBAC6EE Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf12.hostedemail.com (Postfix) with ESMTP id 3EE4A40009 for ; Tue, 16 May 2023 00:39:35 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=WSyNAaJo; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf12.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684197575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=anq0Dx/y6CxVEmQw6r0YtSvw2DpI1Jz0AvRNCGxjAb4=; b=TrQkme5X8cFhncQ4Fywb7VPZtzQ58FLJusvBjBBV8GRZ3ToUEpdLdpkCBqvpLmIik2+P/s OcsTRYqCswXmW/DnPsj/kGI8ZaBX17T26A1cwDIjnpCx5zrCjA0JcCGjCNlbIuF4P6a7LJ tMAvVEP6SSOCJkoAlcd71trWU3wB8zw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=WSyNAaJo; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf12.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684197575; a=rsa-sha256; cv=none; b=WMsLKHBccuK8lxyYl7DrN/QfwKZ5mStfDipLhMdXqsrtZ/Rur9F2a7dw7mo+WrQP/5WJIV Q/gcDqh0Zpv9RS2RKugCnD57zEAiPgmIKp5U3Lus5y3a4BlaAb1JCuryYqk0h96xdp0RUY iqxycLlXvIApff/Suyh0XPIejncOJGs= Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-24df161f84bso9215104a91.3 for ; Mon, 15 May 2023 17:39:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1684197574; x=1686789574; h=content-transfer-encoding:in-reply-to:from:cc:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=anq0Dx/y6CxVEmQw6r0YtSvw2DpI1Jz0AvRNCGxjAb4=; b=WSyNAaJoTiySOyqUHAL2TFJcCFF0bl5Jb/d7rhS5/7LFDEIZ+QwDbFi8p1gy8aV37d YuoG0B3CFmgbaI2StCVZ50DuXpMYnTVCco553c7CZWf81mMRjpeMJQHUF8wZ3G27Vsom e/QthlyzAXwogcdsN5lNnbKiutgRiiOX4ViKldqBRG+gS/vOtVmoHLPZWQJ+UiXpTAR/ ZYy1zwTAnS08mrp8jtqPCVd2B6Pv/ovGn1AAntBKWNmq43aRv8Zoe/RyNvqqAXarQT5q 71OG1+XvSE8NxTlmT5qp09v2BZiQJb7wQ1UdHq90XqqNHQwZtS3wa/B9GGJmoxeuxUIh D7HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684197574; x=1686789574; h=content-transfer-encoding:in-reply-to:from:cc:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=anq0Dx/y6CxVEmQw6r0YtSvw2DpI1Jz0AvRNCGxjAb4=; b=k+7je3Xas7LPlAZcWDn+AuBq0ACayhLDMnSgGwcE5xABw/7x4IM4u6nxmB/HShbfk7 mPRO/hY7NieKWSSc5TKT/i8+7EVYd0V+SxrZRE+I6Mc7uJw6B+GWxLpJW6GONwKiQoJD SAIE/L/wlHOChugz3B5R8QTdhO9A6PRnYBsgPc/k1z414OOgCRLydRZQB/Zs/UbMUNse mdObYZ2LSTGR/MX4YZmotxTvee/8Oe6KXqOnzo4npTXClPUuItvK+UOqdJtDvzdjY0hI kUYel9Xps4j+OVfIqkhdVh39wtcTH+8FLANXr51/BzTms3y7uie1hjWzdfZYwbeBl7GD 2JWg== X-Gm-Message-State: AC+VfDxl0RDR9U+EYj/5C3usQcgfK+NibnTr+kbEGn4nEjZpmY7AnJgy Pr7QuTKE7GFQEs0hZQqsa1cDzw== X-Google-Smtp-Source: ACHHUZ5NcTS8/wwjOKQBJzOZQS0mPdkTYYWeK79aGZ375sI2PtGiKnEbk2+oDyJSvUhi3LQACWeYFw== X-Received: by 2002:a17:90b:3609:b0:247:2437:d5c4 with SMTP id ml9-20020a17090b360900b002472437d5c4mr35808739pjb.13.1684197573978; Mon, 15 May 2023 17:39:33 -0700 (PDT) Received: from [10.200.9.178] ([139.177.225.227]) by smtp.gmail.com with ESMTPSA id ob15-20020a17090b390f00b002502161b063sm198088pjb.54.2023.05.15.17.39.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 May 2023 17:39:33 -0700 (PDT) Message-ID: <52da839c-f23f-3341-961d-a253003bfbb3@bytedance.com> Date: Tue, 16 May 2023 08:39:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 02/10] maple_tree: Drop mtree_alloc_{range,rrange}() and related functions. To: "Liam R. Howlett" References: <20230515131757.60035-1-zhangpeng.00@bytedance.com> <20230515131757.60035-3-zhangpeng.00@bytedance.com> <20230515173516.5tmytjvnzvdogfm7@revolver> Cc: Matthew Wilcox , Peng Zhang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org From: Peng Zhang In-Reply-To: <20230515173516.5tmytjvnzvdogfm7@revolver> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: tbi53wfty8dykgyx95bigc6js4iozij5 X-Rspam-User: X-Rspamd-Queue-Id: 3EE4A40009 X-Rspamd-Server: rspam07 X-HE-Tag: 1684197575-380045 X-HE-Meta: U2FsdGVkX1+mSj3Sxu220NkPKCh7FPJwBve6oDtTHn25qarG8wvI3qnzqTvzaulhPqR6sY9emZEp1ix+9rrohI83OITbKOG+GbHC4nyGZEHXfSoisWQD8aC6ZXmzGwwpBXXx3+HBCzXFr2q+EvHjqMHiLkQk8I2IxVwvu5Op8KQoJu/N3rGZZ4TvpZHFnlXt9pWgsHfk3dL24ZUcncMlQMhweYqKEbzonijO9GPKGJwbMDRCL2U/J51Z7ybnVPDWUZWAXQtNsm6RbDGt8buq6lJesX+0c6m8fpToch0aIzb+QIhrH8qCO0qvrw+7QAw2APIAPdfSB3M4AqU2DBF48ZJU0Vpz4QXCo0CL8vDFnuJWdjcMWnCWFbB+liJhkmDxOvkAQr4UvhLkNyKkUn8eVs/YE8Pg61lqYeI0eexCwQC2sVJ3df8X8RtuM+YjFZE4eK15fkz1IZ+TPqP3RV7HbhPXiNDXV59gnb7vhpcLrIOa+vmm4FYuQzlXYXbAtLXpbNAIHZNUMHEYHk1r/kiJDjepRrBp5ooTRv1dAEwlhUdq9B+HPd1NNxSrNoVhuzKhEOP80dRo7txGH4gn1HQg0ez4yvpuyU6tckI7e2hN0E/M3fL8lCzjdf0sA+/31jcC52pibJyJC6Tnep1vr5D9sQlSVSKD/BfKYXOMouVDo0TFsFca+iZSxvoBn6YXrW5WVCNfpWAXfXhZ/+K3Oxf2h9JgBjPJtcSf/dP6NeSLTwPjor1pblY4qavwDTicvS8Y+xjZQUN+1YBh63uUhKOgfP1l+yKrH65Kssk4KaQdqiwEFkzq8r8E0ULKuwttCqQRzEshBXjOGVS/ppWzWaMQNCq8nhyEh0o87sgsmY74VIkS1lVF4clHsTF7JrN/FkEKQuaCGqpnwpK4fuIQQ00aMDH6uSEBQPsIaB6LYvvtw+BQqGxZ4SPD7CTYicfzK2wjU2h0l6eEMhlCONr+FTJ pVLHJXIZ RGqr79eR2c8dEGrw36loMRZKJ+X48ZxzR7VC2bP6mpos0H/lPm/OOJrJQ292uHi96F8xU9MufsD9OXIoxQt4dQbBwq5nsnwl6kN1nV1efqjcfrrNoMhWgC0m6heKB2vQ5fCdN6zj4/cc/He0YdzaLTrc8RhH2jrkEaO2YLy5FYVT1/y9JC7WGGrwwE3X6OQD5LKWEz9PksuLjndgzjY31UuwAK4AUK5nzd3X2fW6kRbNxZujAku5kirJKgV/qv+HEl0BhCwwZmeACPinDfDvANKsI5I8FWd1yZx7Ywb9KpjWcYe7xl2/Q2uzDWVovGQy4BGJ88l6xIoHg3eE5l7VZEdhsizwbCwoAeKiubGd17jhC/6spzpRH9X80KYjU1zpZ8lbJRx5yh/vhi3RBzdPGxOQmyKRle5nJONVkIj6PSNT/Ma2GTJ47XGu9WS3pAU/7pfeQeDPhoE/z+Dw9wp27/nfD0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/5/16 01:35, Liam R. Howlett 写道: > * Matthew Wilcox [230515 13:27]: >> On Mon, May 15, 2023 at 09:17:49PM +0800, Peng Zhang wrote: >>> Drop mtree_alloc_{range,rrange}(), mas_{rev_}alloc() and mas_fill_gap(). >>> mtree_alloc_{range,rrange}() currently have no users and can be easily >>> implemented with mas_empty_area{_rev}(). mas_{rev_}alloc() and >>> mas_fill_gap() are just their internal functions, drop them together. >> >> No, I think this is the wrong way to go. >> >> Most users should not be using the mas_* API. These are the advanced >> APIs. Most users will want to use mtree_alloc_range(). Just like most >> users of the XArray use the xa_insert() API rather than open-coding the >> xa_state and calling the xas_* APIs. >> >> Please read Documentation/core-api/xarray.rst and maple_tree.rst for more >> details on Normal vs Advanced API. The real problem is that we have so >> few users today, so you haven't seen that most people don't want to use >> the advanced APIs. > > > Peng, Apologies on the confusion. Please do as Matthew said. If you > have a way to unify the functionality to use the same internal > functions, then I think that would be a welcome change. > I will implement new mtree_alloc_{range,rrange}() using other internal functions.