From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9AD7C433EF for ; Wed, 13 Jul 2022 03:29:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52F949400FB; Tue, 12 Jul 2022 23:29:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DE759400E5; Tue, 12 Jul 2022 23:29:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CCFC9400FB; Tue, 12 Jul 2022 23:29:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2E0669400E5 for ; Tue, 12 Jul 2022 23:29:41 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4D97D20493 for ; Wed, 13 Jul 2022 03:29:40 +0000 (UTC) X-FDA: 79680646920.31.FE7C429 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf14.hostedemail.com (Postfix) with ESMTP id 51D22100062 for ; Wed, 13 Jul 2022 03:29:39 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LjNPh2DGCzFpxd; Wed, 13 Jul 2022 11:28:40 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 13 Jul 2022 11:29:35 +0800 Subject: Re: [PATCH v2] mm/compaction: fix set skip in fast_find_migrateblock To: Chuyi Zhou , CC: Andrew Morton References: <20220712072745.33870-1-zhouchuyi@bytedance.com> From: Miaohe Lin Message-ID: <52d6ee61-e801-9bac-c1d8-c2c6f5c535e2@huawei.com> Date: Wed, 13 Jul 2022 11:29:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657682980; a=rsa-sha256; cv=none; b=KUVjrW2gWogsYGyztjn7qTCRT1idvYq9GAihMgoTLSbyhBuTzR59DxSLQ+TmhK/yfXpbWd N91arYBLH/2mzSiKnbmhr6OJ7Zwfjrg60SV5n+7PQc2jQXKJcwOr4tEe0f2lZ+NWVY1b1q 7G8cuIfcHlmnfSUusPR3TjSrrN1vOsw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657682980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zuxxErb5k8CKBhNR4PBWSrKpDo9sKM7bZN+b3TqAfmY=; b=Td/xPHT7xIQDoTAQ1Cb7kKxdVZrbQ/JiZChLrAK3zjWM5vzr0vm63+elme3m++Uc6nEyud kgfyDjJwf2xqeT3qddwpw1mfQGu+k8RBoVq4bXaaR6t9/h5xKfAC89LnKnp4DVjZM4L1H4 ZjfA4BnA0SfwWFr/oG+cP+9+d0iTB0Y= X-Rspamd-Queue-Id: 51D22100062 Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: hsd55nbmnpft8kse98egoaran4irnuj6 X-HE-Tag: 1657682979-686550 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/7/13 11:13, Chuyi Zhou wrote: > > ... > Thanks for your help sincerely. It seems I should use "Fixes". However, I wonder to know why I run ./scripts/checkpatch.pl it shows : > total: 0 errors, 0 warnings, 7 lines checked > 0001-mm-compaction-fix-set-skip-in-fast_find_migrateblock.patch has no  obvious style problems and is ready for submission. > > I clone the kernel source from https://kernel.googlesource.com/pub/scm/linux/kernel/git/stable/linux-stable. Maby I should clone the source from another place ? I usually use the git from https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/ when I work on mm though I think checkpatch.pl should get the same result. Thanks.