From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 937E8D6ED26 for ; Thu, 21 Nov 2024 13:04:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 279E06B008A; Thu, 21 Nov 2024 08:04:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 229A06B008C; Thu, 21 Nov 2024 08:04:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07CE36B0093; Thu, 21 Nov 2024 08:04:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D66836B008A for ; Thu, 21 Nov 2024 08:04:33 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7ED681C7FA1 for ; Thu, 21 Nov 2024 13:04:33 +0000 (UTC) X-FDA: 82810118286.09.CCC226D Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf04.hostedemail.com (Postfix) with ESMTP id 721DC40008 for ; Thu, 21 Nov 2024 13:03:23 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=jQFAZTE+; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=zwsjwRgy; spf=pass (imf04.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732194177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sios1lXAeM9BCJSXDbSMZDSqeIbeNsXvyBXL7wTm8xY=; b=oVoXldi9uOmo2F0hEctT2jHN1/7qf+8MKbAyD/xM6euc5xq/qEjS320DN64i/1VBkS+nM6 +yhHE1JS+BnNxJyUmsuIob6KMRcOYdCnPlVXfgQdmgPAyaVHasowJcfn0DDeo6rrtIi/aY /yvwV+W36jDbe7wUyZWlUxYZpvnT4Fk= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1732194177; a=rsa-sha256; cv=pass; b=NxcKiwyfpuIaHj361tSd7Lm9xKPH7MWFrKG4b3Z2zWOw+/9STBPVXCbA2bQY2+EHGo+bZR r80nfFVjqGMtY/jr8r4BzM68oFROwhsm9UXBJZFKGpvdHp8maY6fu46ZBcr5jjgl2TnGQx 0WuBXpKmtzl0s4r+7Yu1DAxK+4I6JuE= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=jQFAZTE+; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=zwsjwRgy; spf=pass (imf04.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4ALCtYsA006857; Thu, 21 Nov 2024 13:04:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=Sios1lXAeM9BCJSXDbSMZDSqeIbeNsXvyBXL7wTm8xY=; b= jQFAZTE+bbuxmu9JUtFMRyRlwIb6I7oKxkz27OwDdUZStW/qA8e5U599cgiKWQBO IYSkUH6DLa824QrG5loQ1m82aJKUR8VRw2RKRkvuQ0kKJW5Zw3CEi1lTy5nlYDcZ zl2DmtiOnzLhhP0EmAZl7cnFYR/7QaBB1i/1P+q/WA1qUYxyLYqai8M28ji0LHdN oLUUyXDBFSkokkbeD9FrpdkZ91kgWdp6EhBv2C+SVFr6baFZoNgA9tKWwvx1biWc oKRjCdDOpOvnq6NKJiQAv6JghoqjGRonwKOz9qnvCIA6dqbx+6PdTXfTGwmyPixu +vQhGlSSL7CDrCCuCRHlRg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42xkec1px8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Nov 2024 13:04:19 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4ALBgY5T008575; Thu, 21 Nov 2024 13:04:19 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2043.outbound.protection.outlook.com [104.47.73.43]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 42xhubmn12-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Nov 2024 13:04:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vUtxVvG8gHmKWqYX9T9/SeVZYcYzT4GdMeG98zEhb7wja28ei/3QrKIztek09c4UwPRJ4Qwe9jEP0Xxc3s4nKz6y+F1xBIpSUSCwNxpB3dJ5+xAmhePHgmLSj+sMYlca6UVCN5dbrQ9UV6UFkNRjLewpwmze7Fcp/zu8Y7yHm5h5EvLJr7TZiOvsVJfl8Kp7LVZ8n3JAMgkVyuMNYtl8NarhL1O+EZM/ctqkyf1zG4R3nTd+LmkHCLvMp0EHHksjeNBr9hNGMVvt/w109pOpc0g0o8lQLQiIR0XLkrItA/WVfGT71f3nrl3MXg6Rjf+ISpLAVCDMzBQy8irh2O+HdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sios1lXAeM9BCJSXDbSMZDSqeIbeNsXvyBXL7wTm8xY=; b=SLnDBrCCaskvDUqYcy9eAvNsgKnowXpWil1/qrDJ9uXAQEnEoF9NGu557ZF+A7R6xd576aYRls853M9sUSoFqjAHXWjeOAfaSn3sUOGVv1Mtwg5mIFFoOyEpH2fclU+RUhB2AtzXkmJXdmtx2QXrJpm5hNrbNyDrv7/LwY6BKStRv9lT22jpgzjuqRrrgEi+bnaOioiTHyXCCXVH/3WgiPVlgBVb9sw+/c3aH/1wSka6TKALuIGkyks7mBe6dwzowUIQqpdAVclbHPMQXakHUnRCxWovYBJorktkDkhNth9l6NNLk7+8IdmyCn5YIXLOJwz2uzgPEOuu2rCqqFN5ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sios1lXAeM9BCJSXDbSMZDSqeIbeNsXvyBXL7wTm8xY=; b=zwsjwRgywwPM1KlkFKYXRxo3eP/sfESOz9k+5ir0h7ppL2ImP1uh5QDtlRJLLUFtq9LEWxzPmYUaPookpPaePiYBFUecRnC7YjSDB5cCcdruB6rFRYFPWLfzsZIIKHTUfmOy9FPp2ATY+wAb/o0lqLibnMgU7Obe8hMHt7KBazs= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by DS0PR10MB7341.namprd10.prod.outlook.com (2603:10b6:8:f8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.23; Thu, 21 Nov 2024 13:04:12 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%7]) with mapi id 15.20.8158.023; Thu, 21 Nov 2024 13:04:12 +0000 Date: Thu, 21 Nov 2024 13:04:09 +0000 From: Lorenzo Stoakes To: Alice Ryhl Cc: Miguel Ojeda , Matthew Wilcox , Vlastimil Babka , John Hubbard , "Liam R. Howlett" , Andrew Morton , Greg Kroah-Hartman , Arnd Bergmann , Christian Brauner , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org, Andreas Hindborg Subject: Re: [PATCH v8 5/7] mm: rust: add mmput_async support Message-ID: <52cf60c5-b987-4c37-b7e5-caaf425a9fd7@lucifer.local> References: <20241120-vma-v8-0-eb31425da66b@google.com> <20241120-vma-v8-5-eb31425da66b@google.com> <5762ab92-3091-46cf-9565-f59cf917b470@lucifer.local> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO0P265CA0008.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:355::11) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|DS0PR10MB7341:EE_ X-MS-Office365-Filtering-Correlation-Id: b2e89262-e2f9-4ccb-04cd-08dd0a2cfe80 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?L2ZON1JacHJrTjlTRGw3ejlYa0hmLzFjN0ZFNDdVb2tsejE2R1ozVWtYamxn?= =?utf-8?B?WE5xSW5pN1FyeXRnM2JpZDU4YjV2T2dianlaZ0pkRzNYUFE1eW1wZWd6QnF1?= =?utf-8?B?ZWkxblFwTFhFd1lGR3oyQ1VQcW1TdUI2SndOS2hBMTFtOXB6T2FiYUFwNDR0?= =?utf-8?B?R2NZbFBjalM1dlIrOHpBbFJEbUdOMGJQbVh3enh2UzRHVjU2a3krUXpraTRS?= =?utf-8?B?VEVRR0NaMDl0VmpBZXVPVHRBellpcmRrR0g0VnRkckVaRkVERElrcTAzcUl6?= =?utf-8?B?MkxFVC8yMUR2YzE4Sm9QZXNIUXdzZTh2SHNXSkU5cFh6SjlZbkZuanh2aTV3?= =?utf-8?B?QW8zV1JwWm1uOVlJWTFERGI1NVJZZXVLWDV5TDB0SDRQSkVnWHFWN3AvSDVT?= =?utf-8?B?OFFWVnJPWnpaWGtUV0N6cVdrU2xTak0vekplZVRZcksrZG5LTDBxNzF4V3BB?= =?utf-8?B?bVpVTjhlUUozYVlJWkFGbnhyVGRQSzNwSFg0YTRzS2dnc2ZaTnFWVjN6QTB2?= =?utf-8?B?dThpekhseXlHTFRQT3gvdUNtNVh3a0tYQzZhczJFMjJDS1FxY0tvK2RvZktB?= =?utf-8?B?cE9TNncvYThMdTdyVUpwL1NrYnZFRTVQZGdXQ0JHWnIyeXpUUUR4RFFZQ3o4?= =?utf-8?B?bnRPNmRhTk9sNlBydmtTNERxWHpnNTlFK3R6bDlPeU5xa2d0ZExHQjBwNU5a?= =?utf-8?B?QmVmWU9NRDM2TVNJUDE1T2xubC9SVEVTbzViSm9kNHU1U3czaUVPL1MrL2tu?= =?utf-8?B?d3F3ZDZFcyttLzVXN0lEOXFpY05PdnBXbUpQUGxQdHRkU0xkWWpkOXlHK015?= =?utf-8?B?REdQN2NPK0kxYXBkbHdMZFhVT29sWFFkVktRcUdiZGY4VHp6dGpRZVJKK3hk?= =?utf-8?B?TWhYTjFnWFBBbCtkNkJJdm1jeUIvd09ERHU0OWkwRndYVGxBNUlJVnUwM0Jr?= =?utf-8?B?UmNLUUVoR2xOTTEzN0FzQ1F4T3BLKzMzY2xsK05YcmxLSEZhYVgvVXZBRVpk?= =?utf-8?B?WldiRDNaK2JOVHFXQmlHTUk3dEVNWkVZbHR6bExMV1dxWlRxZVIzemhBZU00?= =?utf-8?B?blNIalRaeVFZNklWVGZtUVEzYTdSSWlHenB3emNLMnhKTTBCc2FIWG9jaDVF?= =?utf-8?B?bDJuUC80SVJMQzVMQzJ5WVF0dStBeWduckFCclhYNUluaURoSURUS2xyWkVn?= =?utf-8?B?SmdkeUpLdFB1K01mSDlYaHZXWTRGVlJBOHp0RlY5dU5vbGkyMDhVKy9ZY2hR?= =?utf-8?B?L1N4WENwaUE1ZDdKMnQ0RVpWUHNvK1pIUEVQM0VIZGI5cGQ0dUVvTzgrWTFi?= =?utf-8?B?QUxwRFN3MkZKR0oyWUcvM3liOHJWYjVkSDRxZGVDNVRqNjNMZE9GV1R5TFg2?= =?utf-8?B?ZXdNUVdKNzN1VVVndmcrUWpNVUhjdjg5U3pacjBkeGIvR1RWVG9lcDFIU1Q4?= =?utf-8?B?ekdiQ0hoUTlWNS9mRTlHL2FPRWZUQUQ2SjhBZzJqeUQvVG9pc1pMSHZkQTVO?= =?utf-8?B?MnRJSWRId21uMklhN3RKN1dQK3E3dWFzVGUvQVM0eXVmeUd3bk9zTEsrckN1?= =?utf-8?B?QTU4NG5MLytjNGpFZjNleXI4VmdJQWljbVE4YXV5TTJWd0o1cjJVTWI2NlY3?= =?utf-8?B?YkcrWUF5WEkvQzJ2MmNDV0hqZW1NN21iblpDSVRidEVZK0NJMTU4OUhISC9n?= =?utf-8?Q?onEq3E2azTCw6lc2MZDw?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmZReE1GT1hkQXNmMG5jeit6ejVtUzR4NzhBdFhvUVFsVHFVc05TNTdnTll0?= =?utf-8?B?ODErRUpBRGFqNTNaQk1qamNyaThZbDllK1JXNGw4WmJGNjNXZm5ybWMvazlK?= =?utf-8?B?emdVUFlaNjRKakQ2QTg3MVZadVJyYk9Dck5sLzZUeFM0by9DcTVjVXNBUXpi?= =?utf-8?B?ejhsN1Z0ZWlkQlUwbDRWZ0VPSGR0L25QY0VKKzRuakhuUjlFWHNJbUYyR2RH?= =?utf-8?B?Zks5QzNWcm5WQXpzc3JlNmM1cUZnUHZXaGVTN3YyWlhpOGdKMS9aL2lsRHV3?= =?utf-8?B?UkFMbFVlZndmem1sMlpCZ2pheUJsUUVsQ2dFdFBkUTFLb2tZY0twb3hGbW9i?= =?utf-8?B?aWhZZkdKcm94UWlkb3F4c3JHM2JjTWpMVktVWXRkb2Q5dHZXcWhJd3B3TmRq?= =?utf-8?B?bjRvcWxoRi9MaVVXT3VQa3RTTlhZWS9NdVVkY1dsR3dVaEVFSGtHWXFTYmhI?= =?utf-8?B?OXN0NUFnVU5QcEo3MG0ydUhGMUpkam5zWlpNRUpKbDZRNlFpV3ZRcU9BUng4?= =?utf-8?B?K1lwK3VDQW1EMVdRSzBDenB0OGMvNCtVc01YQkRUMk5jUXVYb1FKTnN6RXhW?= =?utf-8?B?SjhDUWppMHNla0RwMUNxMERMSTk3MmQ2eWI2b1lRd3VHTk0wNkZjY0VtWmpY?= =?utf-8?B?U3ArRy8vMEI2QVU1ZjB2SE90dmEwUklXUDRzdVRUbGtDSUpWaWFXdnlYeVJj?= =?utf-8?B?MDFiTjcwTjRzV3hRSmxQRG5LM0I1eTk1M1pheGlpbkl1RFI3UWlhcTJjdDBy?= =?utf-8?B?K0k4UmNGVDUrVEF5b2dFM0k3b1hmRldlbWVsdXZMdURSVVlIR1VDWE5JdWJD?= =?utf-8?B?aWdnYmdIS3VXYURHUHIvdng4Mm9NaXZJYXh2Vnk1anJsMFpNL0xGbUsyNS9k?= =?utf-8?B?L1p2bTNtc2hoZGJjdE9DekVzRzR0SVN0bmNGbnlpa3E5Q1VvQmpLRkVMb2x1?= =?utf-8?B?Z2s1ZWNjZ3dmSkZ0UGVKeTJxeUZXWXN1U3lnYkxvM2h0VWVCd0VRclJBRkV3?= =?utf-8?B?c1JVNTF6QXBCL2c2WGF2Yk12b01lSm5rclhiK1VyZTU5dUg2RzRYUDhIWW5H?= =?utf-8?B?dlRZWUxXQnFxZVkxditkZ1AybGV2VkthOGY4bW9CSlBLWDQ4cENTVEUrWGZK?= =?utf-8?B?eEZ3cmVyRUxyYk9iK1I3WTdpa28yZ2diTDJPM3VjWjFucDd0RVYrT2xMKy9G?= =?utf-8?B?RGhlZTJNZENiR084V01zYnM1WmF4ZGlHQ3dITVRJbU5kYndqdFhlak91NU9I?= =?utf-8?B?WjJNbSs1Y1dldE5MV1Q3L0sxU2JBTjJHbCtMVW5mMld2emVoY2VXUm9ETzZP?= =?utf-8?B?QnV4MHdjQUtjSXN3TlRGWkNIK3VxcmZ2L1VZUFJ0T3ZWQXgzKytGZ0pRWkVT?= =?utf-8?B?VWtFY2I0VDVzQkR3ejU1WVpMekZOVXVWOWtmM0RkM2ZQQTd4TStnZndaUUI0?= =?utf-8?B?M2d4NFNiUk5FOEtqcWVYOGxlK2U5Rm5BOThBZ0lqOHRwUEEvaXBkaHI2VXBH?= =?utf-8?B?RWdraklFQ2luaDlNMkg4YU9Ya0FnaS8zL0hIc3RyRFVGeVJualpFdzFEOTJ2?= =?utf-8?B?TkU5RzU3cllFUVlDT3J2cFgxT1BqV202Um9nV3RBeFNtb0RlbTVHV25SVUc1?= =?utf-8?B?Y1Z3bDlFZUg0dFVSRHplanBJOFNQUy9uL2t1VE84eVFlV3Z5UlNya3prazEz?= =?utf-8?B?b1dNUWhIS1hHd0RPSHRIdEN2Q0pBSmFDRzhHMllKUlJWL1NvR2w0UEptTHpp?= =?utf-8?B?dEpQS3NyTFN2dHFYdUxDSDR0dkY3ZCtjVEkzaFY1dmFOQjZ0RGU0R09xcXd0?= =?utf-8?B?SUt4b1JrZ0RvUnFRR0lLYTRJdTZXTzlhV1kwZFR3N3U1YVBESGRjWlRSWUN6?= =?utf-8?B?akZ3blFOOFhlbmtJbUMyTEhEM0xtN3h2ajFOWGRzb3lzdU94ZnBMdmlLV1BJ?= =?utf-8?B?a3ZMOEtmczR0V2J5Y3pZYVMxcXRpZjhQY0ROeGFZeHdwZFBUaXdYazJXbmww?= =?utf-8?B?cFJpTXkwVzNjS2ZQNzNzT3ZEU0hTaEVDRXZoK0NQaWZHZFFhOVBMZWN4emk4?= =?utf-8?B?bUp2LzZiZjk3alJIUkJ3R2xkSEZSWmhsYlpGTjQ1OUsveVJzYUdaUnpuYkR1?= =?utf-8?B?ZUJZY0JVRG1WdDdSWFZUM3ZCUjg1NVlzWEU5QjBhTGc0Vys0d0NvNlNlOThZ?= =?utf-8?B?MlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: tGF7YOY5OZYQ2j6zZWxsUitSGSBxnaBoH/inb7ULgiD8mXahCuqOBjcsry9XxMxSmjoDNj7HPDwpC0TnN/Mlr175AMOB/Xep8ypBF9VGxgxzhT42shz1WAljliUt8Sti32+9YOr7pA5rPL8VHvlzynRpOxyU0nDeF28Fk1442aCy3t+uWdvS09w5KQYZkDpL/9eGuF1Dj3oVFdI0qcbqnWGBioVJlBeKuyouUEEgmTXh6YA/JBDVgwuen1lpzd7JIc/cgjecbBUTDJxNvOSm6vr+3X23uHS05ByCZwA3sisP1tLyiT2zAwcxlPSKR0v0FzkHxQyPPWleGBjc8zkSSlXpaWFglmsuOw2hG7bmq2ScbyXXOuhTh6U6fvNSsDxsVvzLLOObsykPxvzO6XV7hd0I1a4bgnQAAZrijW3l190EAwqfSrcrRz3r2CNDRvP2wWtLEyThDqg6r8mHP2IKC7+GZmDpDa4AExkPBvp1h3nVvTbbCCO9FsM+7gG1A6Hz3Wyb/Boovegk9RvSR4Dku8B6cH5hQlUsZxeduB6nPfvAMFpL1AzEGqJwopeXE7x4zMO8T5Mz3iodMreTswIfiNIZE//AWhGQ8qpT0wJ1JY8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2e89262-e2f9-4ccb-04cd-08dd0a2cfe80 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2024 13:04:12.2187 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ALsurQGJzbw/5iF/NkAQWaVHO8qJKvEcEdeP0rfcs8MuT0nOOcetktvQQu+OzKF38BF+ShlGJxQ7I+cLowazYOJrV82xZLgxvZpBoEeEM34= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7341 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-11-21_09,2024-11-21_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 mlxscore=0 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2411210102 X-Proofpoint-GUID: hqTEIBa8lPEqN6QGbEXTmVQr4IDn7dX3 X-Proofpoint-ORIG-GUID: hqTEIBa8lPEqN6QGbEXTmVQr4IDn7dX3 X-Rspamd-Server: rspam10 X-Stat-Signature: n9ddqrzhoiayeceah5zowa1tdt1fxpr6 X-Rspamd-Queue-Id: 721DC40008 X-Rspam-User: X-HE-Tag: 1732194203-605315 X-HE-Meta: U2FsdGVkX19HGT0vA08HL0zse+4Ol6lNks57sBGhmthJ+0ZqVh7sbONpK13cAbnNKUr+sI8mo5tqsmSQ0w+yROgxdULS4FtFor4u2/5lV0qcMD3R3ZUMiE8kfI7kfPEoxKrHHQrNF7n0gff0MryAqTzba3Tw9fyhL0eiZCPV2o+xz6aL/Yspc196uh529weJvwZ3Do8j74FQPF+VP1JzCYk+hZWF1om15VNZONJSHpGvt5fgvKQDQysMEpzbGZyhUnyJXsvfFLLDybj3sQqVeagVNI2mCjpBIh7XirYFjudWBNqalKHjcw8Giy0BFHj8mcX40Zsdl5lZ1BH2Sa7RRniuyC0xkjODPQ/pUMb7Rq/fkJl0hIL3vnP2fqsiuGi64Qcoc1s1ruZfktdq/r6QwVFu2PfyTTpAm381sZgb2wF4I08cvtQiMSag+dYmo2U/bPd7jUpms1XljqI+aV/YiU1ySAtBgFUOw2UJevDOQtXxvFLll0U8ePRQRnpWRuz4J6nl0dC7js31HUzfi+gamGXASKU7fzXuYUjyf2XViGYr9TkigPIkqwGCr+4ayBC387E+zYiF/PLyzYdaKSFu9ZKn3gftg6olE7vKsz8tjYtbqjdTqWd2HvZkWf1T0BBIhTjwjMZ4hXn+pHGGk0hzWdlXDY7I8EB6xKSEsHTLPG4rzwvwCsKF3DBT+rpdYLirNHLfRR5vT5k0RwEqq1vtecnjRSUkmipzRrD6e++ct/Nd/+u2SGuskKnuRbBoxyY8gP8Y5syEvDqUlsHeLE+2cLh/dvu6o3RsSjYgPcfd4+jI6He3mzgUYDSGgiYZQy6oi1I0rRioQ9+C8y1Gz7yEp/w4eZM4Gd2Ab41zkOLwa2Gvv+Xuq5KVOIe7lU6mW6aVg5nJs5QRMNCf9O1IZ8aTg9rckPR+pYHytn34ho8/gt1nrscio20kK3Amskym8mOvnWg+nEAM6IZc+CYcT6X AUxVOomA pJq0GI6PHnio3sgiQIkJ9iUqRAnS89i5oISWVj1QD7mxlYTSvUrvPVWAw0oEXE3vUi0YgJgIlWsE3TfZmENLi54xmC0RkBEmP4mZ33MPpgi2WSKcsyqJUUNW5qfpuctf9WJR6P4kCyU8SlNtiVbHQOrqLyQP+A3izHgn9wCIkqPtEcnDIxFaks90TOzdIwAH+PkAHFDZhBWxFgpSmp/bxHCxmVJ9VtKD9REzqnhkLjD8hzP9T+0cZ9V2kkteJpXMGffq/jYOkEUVDFW/hEDBTRkW7jL6oR6iYXjFXQtXURM0PplJlaK+uKn26ffqXqm9WwxpO20J88yE9Y0Gx7WQxjd93r8ej46IJe3Z4lqRjBRN4jyMiYAG4Pa3Az3GLjJhNb+ZCNhu9ZgPxnoQ/HOpNlqh4n9FJyinNDA1yKdJt1AKiPRpOeNxsOO0mL5VLs/BqiQ8fGHW/xuaZ74/R1wSz6NRpIBTILg4sWzfFJYTUIbMgHi1hpVwpXcF/1TO9qnlDyFLqEXZ10MQ/Jbx7sqjESghkqRN03dZxXQqFjx2DG5vzzZUP6f52XIFEg9nh+/TUqSHeGYJIVtGzOYANKZU+3iiwqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 21, 2024 at 12:39:37PM +0100, Alice Ryhl wrote: > On Wed, Nov 20, 2024 at 8:47 PM Lorenzo Stoakes > wrote: > > > > On Wed, Nov 20, 2024 at 02:49:59PM +0000, Alice Ryhl wrote: > > > Adds an MmWithUserAsync type that uses mmput_async when dropped but is > > > otherwise identical to MmWithUser. This has to be done using a separate > > > type because the thing we are changing is the destructor. > > > > > > Rust Binder needs this to avoid a certain deadlock. See commit > > > 9a9ab0d96362 ("binder: fix race between mmput() and do_exit()") for > > > details. It's also needed in the shrinker to avoid cleaning up the mm in > > > the shrinker's context. > > > > Oh Lord, I didn't even know this existed... I see it was (re-)added in commit > > a1b2289cef92 ("android: binder: drop lru lock in isolate callback") back in 2017 > > so quite a history of being necessary for binder. > > > > I see mmdrop_async(), I guess that's not needed for anything binder-ish? A quick > > look in the code suggests this is invoked in free_signal_struct() and is there > > due to some softirq stuff on x86... so yeah I guess not :) > > I didn't know it was so binder-specific. I assumed it would be a > relatively common use-case. Yeah, seems not so much :>) > > > > // These methods are safe to call even if `mm_users` is zero. > > > impl Mm { > > > /// Call `mmgrab` on `current.mm`. > > > @@ -171,6 +213,13 @@ pub unsafe fn from_raw<'a>(ptr: *const bindings::mm_struct) -> &'a MmWithUser { > > > unsafe { &*ptr.cast() } > > > } > > > > > > + /// Use `mmput_async` when dropping this refcount. > > > + #[inline] > > > + pub fn use_mmput_async(me: ARef) -> ARef { > > > > Again, nitty, but I wonder if this should be as_xxx()? > > > > But I guess this makes sense too. > > In this case, the as_ prefix is incorrect because this is an owned -> > owned conversion. See the API guidelines: > https://rust-lang.github.io/api-guidelines/naming.html#ad-hoc-conversions-follow-as_-to_-into_-conventions-c-conv > > If we wish to use a prefix, the correct prefix is into_. Ack. > > Alice