From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 157CAC33CAA for ; Tue, 21 Jan 2020 15:12:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BC37621569 for ; Tue, 21 Jan 2020 15:12:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d72RUSmw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC37621569 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6AAA16B0007; Tue, 21 Jan 2020 10:12:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 682096B0008; Tue, 21 Jan 2020 10:12:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 549CA6B000A; Tue, 21 Jan 2020 10:12:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id 3E4316B0007 for ; Tue, 21 Jan 2020 10:12:58 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id CF8E8180AD802 for ; Tue, 21 Jan 2020 15:12:57 +0000 (UTC) X-FDA: 76401983994.09.sheet83_53ff1bc2c1e51 X-HE-Tag: sheet83_53ff1bc2c1e51 X-Filterd-Recvd-Size: 6186 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Jan 2020 15:12:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579619576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bu/iMoYfYBgd5jXQviUDjY/CFaD1fKEaBQDIzi7DS7k=; b=d72RUSmwTpLjSpL5vHlAxMxWJOovhXE4PGdHCOqB6U2z4wxAnruk65aQ56IF6PIJGTjFK/ hG+A1CXoLP2/3L23XVLzia1FqZ/JgTlzqxffHzk1Li3TepZGdUUKrj76SdCWeZoQrc/TYU RMpq3kmJUXfh8pHgtqkN2z9HJj/uG8M= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325-VqLjVD4bP52PGczZItHG_A-1; Tue, 21 Jan 2020 10:12:52 -0500 Received: by mail-wr1-f70.google.com with SMTP id u18so1431264wrn.11 for ; Tue, 21 Jan 2020 07:12:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bu/iMoYfYBgd5jXQviUDjY/CFaD1fKEaBQDIzi7DS7k=; b=ujR6Fij6VQtAepfP2lQyyYMtnCDZNZ51WNBV7krVKwlmTk1rD40C1lRH7rO3tp0Aoq u+zZs08JNIZTlbnjpRBP+ZJKy8MCniRlYYtLYKPSUI3KxU9CJYJj3YOnNQQ/+zawrT5G fhJb0Xyenj38unQH2mZyC7oBljBwTqBgMzYpDc0zIGLsNRWrAp2ID25kMdOKjq8Md3My gwwausN6CMLisyBbJtdmcuqI7VibUcWXB/p6TNe9HRf7/qg5VxkfrwUJby7y1aRLC4qD YAJYBnUizCubw7sWBjNeDLcS4plLWrUXfTx2jOPN8b02TamBQ3gtFO0vEyAK0pH32n+8 uQng== X-Gm-Message-State: APjAAAVBJKc/BaaTN7Q8iuWjRCY15oOqSKJcozKX1JwoWJYdR4R0STcW 7/lQ7ddiVeCo/l7kRQf3vMG4WxpO/AXmXh6zxeBgjGdsjA7EiUpsJcN+IhwV7ZcS1PdUroRrQLH 0BQMbbSLZJ40= X-Received: by 2002:a1c:1dd7:: with SMTP id d206mr5000208wmd.5.1579619569961; Tue, 21 Jan 2020 07:12:49 -0800 (PST) X-Google-Smtp-Source: APXvYqx3W9/IFqNtFmh53Y8FuFyZdMe+4NHjz+xYUeI++YvzTVDVuRT0IkPp6ekS3qHgnEBSwWauFA== X-Received: by 2002:a1c:1dd7:: with SMTP id d206mr5000170wmd.5.1579619569664; Tue, 21 Jan 2020 07:12:49 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:b509:fc01:ee8a:ca8a? ([2001:b07:6468:f312:b509:fc01:ee8a:ca8a]) by smtp.gmail.com with ESMTPSA id b16sm54711240wrj.23.2020.01.21.07.12.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2020 07:12:49 -0800 (PST) Subject: Re: [PATCH 12/14] KVM: x86/mmu: Fold max_mapping_level() into kvm_mmu_hugepage_adjust() To: Sean Christopherson Cc: Paul Mackerras , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, syzbot+c9d1fb51ac9d0d10c39d@syzkaller.appspotmail.com, Andrea Arcangeli , Dan Williams , Barret Rhoden , David Hildenbrand , Jason Zeng , Dave Jiang , Liran Alon , linux-nvdimm References: <20200108202448.9669-1-sean.j.christopherson@intel.com> <20200108202448.9669-13-sean.j.christopherson@intel.com> From: Paolo Bonzini Message-ID: <52cf5d90-5e65-4878-b214-7e1809224688@redhat.com> Date: Tue, 21 Jan 2020 16:12:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20200108202448.9669-13-sean.j.christopherson@intel.com> Content-Language: en-US X-MC-Unique: VqLjVD4bP52PGczZItHG_A-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/01/20 21:24, Sean Christopherson wrote: > - level = host_pfn_mapping_level(vcpu, gfn, pfn); > + slot = kvm_vcpu_gfn_to_memslot(vcpu, gfn); > + if (!memslot_valid_for_gpte(slot, true)) > + return PT_PAGE_TABLE_LEVEL; Following up on my remark to patch 7, this can also use gfn_to_memslot_dirty_bitmap. Paolo > + > + max_level = min(max_level, kvm_x86_ops->get_lpage_level()); > + for ( ; max_level > PT_PAGE_TABLE_LEVEL; max_level--) { > + if (!__mmu_gfn_lpage_is_disallowed(gfn, max_level, slot)) > + break; > + } > + > + if (max_level == PT_PAGE_TABLE_LEVEL) > + return PT_PAGE_TABLE_LEVEL; > + > + level = host_pfn_mapping_level(vcpu, gfn, pfn, slot); > if (level == PT_PAGE_TABLE_LEVEL) > return level; > > @@ -4182,8 +4172,6 @@ static int direct_page_fault(struct kvm_vcpu *vcpu, gpa_t gpa, u32 error_code, > if (lpage_disallowed) > max_level = PT_PAGE_TABLE_LEVEL; > > - max_level = max_mapping_level(vcpu, gfn, max_level); > - > if (fast_page_fault(vcpu, gpa, error_code)) > return RET_PF_RETRY; > > diff --git a/arch/x86/kvm/mmu/paging_tmpl.h b/arch/x86/kvm/mmu/paging_tmpl.h > index 0560982eda8b..ea174d85700a 100644 > --- a/arch/x86/kvm/mmu/paging_tmpl.h > +++ b/arch/x86/kvm/mmu/paging_tmpl.h > @@ -817,8 +817,6 @@ static int FNAME(page_fault)(struct kvm_vcpu *vcpu, gpa_t addr, u32 error_code, > else > max_level = walker.level; > > - max_level = max_mapping_level(vcpu, walker.gfn, max_level); > - > mmu_seq = vcpu->kvm->mmu_notifier_seq; > smp_rmb(); > >