From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36700C2FC04 for ; Thu, 17 Aug 2023 03:04:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51EF828001D; Wed, 16 Aug 2023 23:04:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CF59280019; Wed, 16 Aug 2023 23:04:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3702628001D; Wed, 16 Aug 2023 23:04:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2834C280019 for ; Wed, 16 Aug 2023 23:04:28 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 029BD1C9FE6 for ; Thu, 17 Aug 2023 03:04:27 +0000 (UTC) X-FDA: 81132103416.02.5C55DA3 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf24.hostedemail.com (Postfix) with ESMTP id 2F68A18001B for ; Thu, 17 Aug 2023 03:04:24 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="KyvQ/das"; spf=pass (imf24.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692241466; a=rsa-sha256; cv=none; b=EQMpwWuuxUKzXvKUqBm7A++4PuDJ43wiYTtZOg/rT6apbvLymPusdRESFLgdnGsxlIbf3n A//WYRYOKEBnqF6uLI7GovAIpujG3vCRoqamvuYVysZw0p2Sy61YwPsc6MLUEbvpK6NFsS /MlGTf3/WFUb22roJLBvSyTOhuBk2Ls= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="KyvQ/das"; spf=pass (imf24.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692241466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j+oN2F++TrhNWLHLX+sRtmpEl+IFfl1u9TrYRTB2hEQ=; b=NI+QsaNyNp9iQRHouq1o8g2M5+J2qYkdDSgHeh8LMvW1sAGpd66+rYBFXJR0EIc7tnHQQG jrRU/9iZ/DbTSDeP5Mf2ylkoE/rD3BK4EvLTHtizxMyIxspIew+w8Fwi5w9AMqscCImr+M iBBUkhP+VR/hJu+DmPtQbD4DNC1EAK4= Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-26b4a95f433so1053799a91.1 for ; Wed, 16 Aug 2023 20:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1692241464; x=1692846264; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j+oN2F++TrhNWLHLX+sRtmpEl+IFfl1u9TrYRTB2hEQ=; b=KyvQ/dasQFNGQMCjR1E3eZ9ABkzpDX7FJ/gyFZWJP35glaGjzutIqjCw5G2HgyUojO LgiuIQ0LiWvmNc4AYSu7qapIgigqkkhfSXg8v5erJucFUVgUZf56q2Z+ELz/y8x94wnI BA1u5d2TUYL93bmsR7UoGco0wbehX6jlUsJWJVWbi17oM7OFeEJkJXv7PlUkbvScnit+ 0PyWcrWVPzSX2fDCwf2ibhdzD/QGZQacIQv+T5KzYlL0YtG6iWRcgqtklq4Z2LT1xrFj CWrkwpL4BkxPxTzKC3qODe/pFvzWxKZdVDV8ziu/dDM+eoysfhwoW0QHlCZosDYUKPFA pUyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692241464; x=1692846264; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j+oN2F++TrhNWLHLX+sRtmpEl+IFfl1u9TrYRTB2hEQ=; b=kT3XVO3y4vDJEDLwD2EwcdAYAgI0zSQrLKD20+kwl+RqyDZuC8+Yamp7N4a+tJ5OX6 YiWeZ8EtiNRAgJlFOmWxmWmYLbOYZ+nrSr301paL3vl0TxzvtHYVzNTQ/xf6swhwWidZ wEVaBrr4yfC05isOy8jYqlNB+d0vpixgHFagbEqCGlutTJqgnZPtqglp/ukSZGaPDefx 5grvnZoi+6WRvX12lsg+tQPG0SqwaoyE+g1NzeIQqBmiOFkxtoqaHZWmL6rmFRs/RF2S 1kv+QZpFF7e04qljB1yXL3T9bIs+oHng3+mhUskNoyinaKCk3JmKkOnhfEPZz95D+TWC GGHQ== X-Gm-Message-State: AOJu0Yy7RGzzHKJr7O6G/EyISvbrHktwOmmq0mmIFZAmZGfeKRn7eH6b MKc2qT9/2dRpVoNsSDoTwHpqsg== X-Google-Smtp-Source: AGHT+IEXhHaOrOFf9jckj4CElIYgH9IvP2qs4Gx/s+K+/IxrJU4WPBPlbfNV2+NQpqjgJCr1yOaPzg== X-Received: by 2002:a17:90a:909:b0:263:2312:60c2 with SMTP id n9-20020a17090a090900b00263231260c2mr3384507pjn.3.1692241463669; Wed, 16 Aug 2023 20:04:23 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id ca8-20020a17090af30800b0026801e06ac1sm448211pjb.30.2023.08.16.20.04.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Aug 2023 20:04:23 -0700 (PDT) Message-ID: <52cc55b1-2584-9314-323d-4e407c66399a@bytedance.com> Date: Thu, 17 Aug 2023 11:04:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 1/5] mm: move some shrinker-related function declarations to mm/internal.h Content-Language: en-US To: kernel test robot , akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, joel@joelfernandes.org, christian.koenig@amd.com Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, Muchun Song References: <20230816083419.41088-2-zhengqi.arch@bytedance.com> <202308162208.cQBnGoER-lkp@intel.com> From: Qi Zheng In-Reply-To: <202308162208.cQBnGoER-lkp@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2F68A18001B X-Stat-Signature: r9oo3u9qy31uykrsx3be67mcknof63kb X-Rspam-User: X-HE-Tag: 1692241464-449950 X-HE-Meta: U2FsdGVkX196VO4ppFSxgkb0dt9KSTP1nRUpXnAuOV3BzdLY6vXqkxa+pTKhxkuqXZaJQA3yLuXZTc0Hz/WfTq0vIUCHa9MSze663JdsRWojl6acSeCb+odM8DBHAxetnrlmaXqN1y3rTTn1VKY9O8tkAa5YMKpqigpR7sBT8UgndDwW7G/0dDkJCMqKxQlxh039RX04XhgLanHGp99fsGU8CuFdSDZcVJloaYv49TMaxBtQieE5tB4KCmksL5cZVpAz6pCn3MNVM8hNVBqvORYKJ0uLjRrqPn/mdi433bIU1nCXpo/+fWzLBqz1c4B8Qr98/jzJk1jswTAP8AO/9a6qRD0ylLYGyYmslvsUNV9CsYj3YLBSdsAgo+/qdYomXkXHg55vskW+RrCvj0/+4r2oRDQf643x/AqvdGI6wHbakFZiht7anzM7zcjjZjNAkgcdKCsZVOyIjisnzUteRDBu8CqUxAtNaj0KBUQ23ZSjjc45wvE5E6ehV05M3oa0/3Ey8m9gdsmESgNDJCHqxR4IHtH2TJk60Y7Y1fLbmGqi/Uq5M6UMLuImOFaV/l+nzKIJw1hVhxxs0aJO5winu03ijsDXqnpXGa4M6N7ZIzyxaHi9AvyfLRXMt7sv9JyUlpOdydaYhjRbJYFgRP6TaKWibMyVWUN54BVmhM+Wg5NBhuvp3IO+MY9rsoxwCpDWEcLxZs8rfhDcFhUldNY3RibkjMmHS6ly35tN2ExQJ8/0+vJumZn3ULWxKJ4S/bnthv0dp/Zudka6Ldf3WlFWvFuz1eIoUm70mvphwsKR2kTnE2sTSH3EHSwchEhs3GPMhU8Zo8/A6LERnElLFpLN3uotLREThZ/L8tdpQVL4brNnuoPZy9HR/fk0W7gI2tqFcf22bu1ythHIaJbbnjYDxcNf4a01fV1fla15juKL1BU348Z3B/uiab0EatYpSdvxcqB6VRIvCaqUa0ppJ0y i5GW2yiB WLKWsAY90Ww5WNeWlq1BR/jkMKyFNP0hx36ct3SN3Bm5Qv4yaWo5pWtlKA1pWJMF4AUhFHekAKGUe8ljT8rNIUS9jHmbqfRepFeM6poyhkPi7v9K36c/7pDahmr33rgLlSEpRFnWUvIs8yDD5gGGJo5smbNT7XLe4oeMlukEIIX1gPKX4oMezf3YWbItC4HC9M6U5E5sfUgJJy+h7iSYuDyzNa75y5mA8tGyTWvNk4IIPO5Sw3AL3r1/bIUcKCLSDjD/7qsMywEVpOt/aLVDnz/TGLxkuoYOHWiUffoFbbIk+E7YS5Aq7HerMb0Rl0gJZYUOo6JxYrRN1M2s1U8qfKobZifCTa1ZOxJmyC/B1uvK78bKI7Id2bKGDHAtkBRDsIVmIAhp61dIxbZRLaxkAII0nCN4fdNuCoX5jrWaWvIxdjCcLwvXJQaWF6TBbNPErMPdF3bFFTrf8IShRIZM7DkqUHMQSq6BAGxmJijfts3XUQKOiUQGZ0JIhvFyZKk3zGSomBgSPRaVFKELKx5YZM3XcvtkvskYZ0Ywbpks0HwoV34iBD4R6yfRn0oOavKD5se95fdMv/SLdJYq6i1TWBmlEUNFnGcJZ+FxT9Thrcot1042ygQ2IZwyJDhLjaSAYiHV6M0s0JlUMXSd7605RzimBGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/8/16 23:01, kernel test robot wrote: > Hi Qi, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on brauner-vfs/vfs.all] > [also build test WARNING on linus/master v6.5-rc6 next-20230816] > [cannot apply to akpm-mm/mm-everything drm-misc/drm-misc-next vfs-idmapping/for-next] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Qi-Zheng/mm-move-some-shrinker-related-function-declarations-to-mm-internal-h/20230816-163833 > base: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all > patch link: https://lore.kernel.org/r/20230816083419.41088-2-zhengqi.arch%40bytedance.com > patch subject: [PATCH 1/5] mm: move some shrinker-related function declarations to mm/internal.h > config: x86_64-buildonly-randconfig-r003-20230816 (https://download.01.org/0day-ci/archive/20230816/202308162208.cQBnGoER-lkp@intel.com/config) > compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 > reproduce: (https://download.01.org/0day-ci/archive/20230816/202308162208.cQBnGoER-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202308162208.cQBnGoER-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > >>> mm/shrinker_debug.c:174:5: warning: no previous declaration for 'shrinker_debugfs_add' [-Wmissing-declarations] > int shrinker_debugfs_add(struct shrinker *shrinker) > ^~~~~~~~~~~~~~~~~~~~ >>> mm/shrinker_debug.c:249:16: warning: no previous declaration for 'shrinker_debugfs_detach' [-Wmissing-declarations] > struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, > ^~~~~~~~~~~~~~~~~~~~~~~ >>> mm/shrinker_debug.c:265:6: warning: no previous declaration for 'shrinker_debugfs_remove' [-Wmissing-declarations] > void shrinker_debugfs_remove(struct dentry *debugfs_entry, int debugfs_id) > ^~~~~~~~~~~~~~~~~~~~~~~ Compiling with W=1 will report this warning, will fix it by including "internal.h" in the mm/shrinker_debug.c. Thanks, Qi > > > vim +/shrinker_debugfs_add +174 mm/shrinker_debug.c > > bbf535fd6f06b9 Roman Gushchin 2022-05-31 173 > 5035ebc644aec9 Roman Gushchin 2022-05-31 @174 int shrinker_debugfs_add(struct shrinker *shrinker) > 5035ebc644aec9 Roman Gushchin 2022-05-31 175 { > 5035ebc644aec9 Roman Gushchin 2022-05-31 176 struct dentry *entry; > e33c267ab70de4 Roman Gushchin 2022-05-31 177 char buf[128]; > 5035ebc644aec9 Roman Gushchin 2022-05-31 178 int id; > 5035ebc644aec9 Roman Gushchin 2022-05-31 179 > 47a7c01c3efc65 Qi Zheng 2023-06-09 180 lockdep_assert_held(&shrinker_rwsem); > 5035ebc644aec9 Roman Gushchin 2022-05-31 181 > 5035ebc644aec9 Roman Gushchin 2022-05-31 182 /* debugfs isn't initialized yet, add debugfs entries later. */ > 5035ebc644aec9 Roman Gushchin 2022-05-31 183 if (!shrinker_debugfs_root) > 5035ebc644aec9 Roman Gushchin 2022-05-31 184 return 0; > 5035ebc644aec9 Roman Gushchin 2022-05-31 185 > 5035ebc644aec9 Roman Gushchin 2022-05-31 186 id = ida_alloc(&shrinker_debugfs_ida, GFP_KERNEL); > 5035ebc644aec9 Roman Gushchin 2022-05-31 187 if (id < 0) > 5035ebc644aec9 Roman Gushchin 2022-05-31 188 return id; > 5035ebc644aec9 Roman Gushchin 2022-05-31 189 shrinker->debugfs_id = id; > 5035ebc644aec9 Roman Gushchin 2022-05-31 190 > e33c267ab70de4 Roman Gushchin 2022-05-31 191 snprintf(buf, sizeof(buf), "%s-%d", shrinker->name, id); > 5035ebc644aec9 Roman Gushchin 2022-05-31 192 > 5035ebc644aec9 Roman Gushchin 2022-05-31 193 /* create debugfs entry */ > 5035ebc644aec9 Roman Gushchin 2022-05-31 194 entry = debugfs_create_dir(buf, shrinker_debugfs_root); > 5035ebc644aec9 Roman Gushchin 2022-05-31 195 if (IS_ERR(entry)) { > 5035ebc644aec9 Roman Gushchin 2022-05-31 196 ida_free(&shrinker_debugfs_ida, id); > 5035ebc644aec9 Roman Gushchin 2022-05-31 197 return PTR_ERR(entry); > 5035ebc644aec9 Roman Gushchin 2022-05-31 198 } > 5035ebc644aec9 Roman Gushchin 2022-05-31 199 shrinker->debugfs_entry = entry; > 5035ebc644aec9 Roman Gushchin 2022-05-31 200 > 2124f79de6a909 John Keeping 2023-04-18 201 debugfs_create_file("count", 0440, entry, shrinker, > 5035ebc644aec9 Roman Gushchin 2022-05-31 202 &shrinker_debugfs_count_fops); > 2124f79de6a909 John Keeping 2023-04-18 203 debugfs_create_file("scan", 0220, entry, shrinker, > bbf535fd6f06b9 Roman Gushchin 2022-05-31 204 &shrinker_debugfs_scan_fops); > 5035ebc644aec9 Roman Gushchin 2022-05-31 205 return 0; > 5035ebc644aec9 Roman Gushchin 2022-05-31 206 } > 5035ebc644aec9 Roman Gushchin 2022-05-31 207 > e33c267ab70de4 Roman Gushchin 2022-05-31 208 int shrinker_debugfs_rename(struct shrinker *shrinker, const char *fmt, ...) > e33c267ab70de4 Roman Gushchin 2022-05-31 209 { > e33c267ab70de4 Roman Gushchin 2022-05-31 210 struct dentry *entry; > e33c267ab70de4 Roman Gushchin 2022-05-31 211 char buf[128]; > e33c267ab70de4 Roman Gushchin 2022-05-31 212 const char *new, *old; > e33c267ab70de4 Roman Gushchin 2022-05-31 213 va_list ap; > e33c267ab70de4 Roman Gushchin 2022-05-31 214 int ret = 0; > e33c267ab70de4 Roman Gushchin 2022-05-31 215 > e33c267ab70de4 Roman Gushchin 2022-05-31 216 va_start(ap, fmt); > e33c267ab70de4 Roman Gushchin 2022-05-31 217 new = kvasprintf_const(GFP_KERNEL, fmt, ap); > e33c267ab70de4 Roman Gushchin 2022-05-31 218 va_end(ap); > e33c267ab70de4 Roman Gushchin 2022-05-31 219 > e33c267ab70de4 Roman Gushchin 2022-05-31 220 if (!new) > e33c267ab70de4 Roman Gushchin 2022-05-31 221 return -ENOMEM; > e33c267ab70de4 Roman Gushchin 2022-05-31 222 > 47a7c01c3efc65 Qi Zheng 2023-06-09 223 down_write(&shrinker_rwsem); > e33c267ab70de4 Roman Gushchin 2022-05-31 224 > e33c267ab70de4 Roman Gushchin 2022-05-31 225 old = shrinker->name; > e33c267ab70de4 Roman Gushchin 2022-05-31 226 shrinker->name = new; > e33c267ab70de4 Roman Gushchin 2022-05-31 227 > e33c267ab70de4 Roman Gushchin 2022-05-31 228 if (shrinker->debugfs_entry) { > e33c267ab70de4 Roman Gushchin 2022-05-31 229 snprintf(buf, sizeof(buf), "%s-%d", shrinker->name, > e33c267ab70de4 Roman Gushchin 2022-05-31 230 shrinker->debugfs_id); > e33c267ab70de4 Roman Gushchin 2022-05-31 231 > e33c267ab70de4 Roman Gushchin 2022-05-31 232 entry = debugfs_rename(shrinker_debugfs_root, > e33c267ab70de4 Roman Gushchin 2022-05-31 233 shrinker->debugfs_entry, > e33c267ab70de4 Roman Gushchin 2022-05-31 234 shrinker_debugfs_root, buf); > e33c267ab70de4 Roman Gushchin 2022-05-31 235 if (IS_ERR(entry)) > e33c267ab70de4 Roman Gushchin 2022-05-31 236 ret = PTR_ERR(entry); > e33c267ab70de4 Roman Gushchin 2022-05-31 237 else > e33c267ab70de4 Roman Gushchin 2022-05-31 238 shrinker->debugfs_entry = entry; > e33c267ab70de4 Roman Gushchin 2022-05-31 239 } > e33c267ab70de4 Roman Gushchin 2022-05-31 240 > 47a7c01c3efc65 Qi Zheng 2023-06-09 241 up_write(&shrinker_rwsem); > e33c267ab70de4 Roman Gushchin 2022-05-31 242 > e33c267ab70de4 Roman Gushchin 2022-05-31 243 kfree_const(old); > e33c267ab70de4 Roman Gushchin 2022-05-31 244 > e33c267ab70de4 Roman Gushchin 2022-05-31 245 return ret; > e33c267ab70de4 Roman Gushchin 2022-05-31 246 } > e33c267ab70de4 Roman Gushchin 2022-05-31 247 EXPORT_SYMBOL(shrinker_debugfs_rename); > e33c267ab70de4 Roman Gushchin 2022-05-31 248 > 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 @249 struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, > 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 250 int *debugfs_id) > 5035ebc644aec9 Roman Gushchin 2022-05-31 251 { > badc28d4924bfe Qi Zheng 2023-02-02 252 struct dentry *entry = shrinker->debugfs_entry; > badc28d4924bfe Qi Zheng 2023-02-02 253 > 47a7c01c3efc65 Qi Zheng 2023-06-09 254 lockdep_assert_held(&shrinker_rwsem); > 5035ebc644aec9 Roman Gushchin 2022-05-31 255 > e33c267ab70de4 Roman Gushchin 2022-05-31 256 kfree_const(shrinker->name); > 14773bfa70e67f Tetsuo Handa 2022-07-20 257 shrinker->name = NULL; > e33c267ab70de4 Roman Gushchin 2022-05-31 258 > 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 259 *debugfs_id = entry ? shrinker->debugfs_id : -1; > badc28d4924bfe Qi Zheng 2023-02-02 260 shrinker->debugfs_entry = NULL; > badc28d4924bfe Qi Zheng 2023-02-02 261 > badc28d4924bfe Qi Zheng 2023-02-02 262 return entry; > 5035ebc644aec9 Roman Gushchin 2022-05-31 263 } > 5035ebc644aec9 Roman Gushchin 2022-05-31 264 > 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 @265 void shrinker_debugfs_remove(struct dentry *debugfs_entry, int debugfs_id) > 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 266 { > 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 267 debugfs_remove_recursive(debugfs_entry); > 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 268 ida_free(&shrinker_debugfs_ida, debugfs_id); > 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 269 } > 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 270 >