From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C93A7D591AC for ; Mon, 18 Nov 2024 18:09:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 560CC6B008C; Mon, 18 Nov 2024 13:09:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5109F6B0092; Mon, 18 Nov 2024 13:09:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B0466B0093; Mon, 18 Nov 2024 13:09:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1C72A6B008C for ; Mon, 18 Nov 2024 13:09:24 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id ADDF21A03F6 for ; Mon, 18 Nov 2024 18:09:23 +0000 (UTC) X-FDA: 82800000276.09.E7E0EE8 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by imf14.hostedemail.com (Postfix) with ESMTP id 0528E100004 for ; Mon, 18 Nov 2024 18:08:26 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=QcXvfQn3; dmarc=pass (policy=none) header.from=linux.microsoft.com; spf=pass (imf14.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731953271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wR2vAxb4KjC7bChWhYgHEm7VYOkoUSKJ2zrGmmUQgeU=; b=gL2LXkZRQOTA6SmmS68jow6vfgEfi2J/bPh9HZ+WRIEibCvN4RMzkdfAmvY78kXunz/dN4 lXONSzoWsHc7hV8KvetjTPzvoeuDk+NHZxpZ94tRsvDnL3IQG2c4sm06ipPxhQKpMyOtAY wydj8eLwI1efjYS7dHR9fUWiQnF8DOo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=QcXvfQn3; dmarc=pass (policy=none) header.from=linux.microsoft.com; spf=pass (imf14.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731953271; a=rsa-sha256; cv=none; b=qikf4ZrrHYjhgWL4YGgZle4mYKbSX1Aw+au3mYdzUGn0RJP5EdtQshPA0t4AJNcxqC7FHr CK7IV7vnPOW888TPL0+CMjLgBW0KfvJ2jFB/gAAM00sY2ykVc3EYwLhdHCqjWm3+hZou1r uWshyZLpknlo/dJ9fI9+wU/z+1UoOYo= Received: from [192.168.35.166] (c-73-118-245-227.hsd1.wa.comcast.net [73.118.245.227]) by linux.microsoft.com (Postfix) with ESMTPSA id B3D1220BEBD0; Mon, 18 Nov 2024 10:09:17 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B3D1220BEBD0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1731953360; bh=wR2vAxb4KjC7bChWhYgHEm7VYOkoUSKJ2zrGmmUQgeU=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=QcXvfQn32bbEJk/CliGqPjJlSoPmzpqy39Cb7yWbUp/UMAorBMUaWUr/NKZ9e69DC EuA6BiEwniO9Hz9jAZdoaPATG/Z4etAtwQMMCiIdSJ0wltRFnatVskzJPAClKWSWJ2 IoOFaRlq/Uc2MlJVJm0M77F7OwMbRuycEwh39LjI= Message-ID: <52cc0733-49fc-4452-99c6-8c18bf20dde7@linux.microsoft.com> Date: Mon, 18 Nov 2024 10:09:17 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: eahariha@linux.microsoft.com, James.Bottomley@HansenPartnership.com, Julia.Lawall@inria.fr, agordeev@linux.ibm.com, airlied@gmail.com, akpm@linux-foundation.org, andrew+netdev@lunn.ch, anna-maria@linutronix.de, ath11k@lists.infradead.org, axboe@kernel.dk, bcm-kernel-feedback-list@broadcom.com, borntraeger@linux.ibm.com, catalin.marinas@arm.com, ceph-devel@vger.kernel.org, christian.gmeiner@gmail.com, christophe.leroy@csgroup.eu, cocci@inria.fr, coreteam@netfilter.org, daniel@zonque.org, davem@davemloft.net, dick.kennedy@broadcom.com, dri-devel@lists.freedesktop.org, edumazet@google.com, etnaviv@lists.freedesktop.org, florian.fainelli@broadcom.com, gor@linux.ibm.com, gregkh@linuxfoundation.org, haojian.zhuang@gmail.com, hca@linux.ibm.com, horms@kernel.org, idryomov@gmail.com, intel-xe@lists.freedesktop.org, james.smart@broadcom.com, jeroendb@google.com, jikos@kernel.org, jinpu.wang@cloud.ionos.com, jjohnson@kernel.org, joe.lawrence@redhat.com, johan.hedberg@gmail.com, jpoimboe@kernel.org, kadlec@netfilter.org, kuba@kernel.org, kvalo@kernel.org, l.stach@pengutronix.de, linux+etnaviv@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rpi-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sound@vger.kernel.org, linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org, linux@armlinux.org.uk, linuxppc-dev@lists.ozlabs.org, live-patching@vger.kernel.org, louis.peens@corigine.com, lucas.demarchi@intel.com, luiz.dentz@gmail.com, maarten.lankhorst@linux.intel.com, maddy@linux.ibm.com, marcel@holtmann.org, martin.petersen@oracle.com, mbenes@suse.cz, mpe@ellerman.id.au, mripard@kernel.org, naveen@kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, nicolas.palix@imag.fr, npiggin@gmail.com, obitton@habana.ai, ogabbay@kernel.org, oss-drivers@corigine.com, pabeni@redhat.com, pablo@netfilter.org, perex@perex.cz, pkaligineedi@google.com, pmladek@suse.com, rjui@broadcom.com, robert.jarzmik@free.fr, rodrigo.vivi@intel.com, roger.pau@citrix.com, sbranden@broadcom.com, shailend@google.com, simona@ffwll.ch, svens@linux.ibm.com, thomas.hellstrom@linux.intel.com, tiwai@suse.com, tzimmermann@suse.de, xen-devel@lists.xenproject.org, xiubli@redhat.com Subject: Re: [PATCH v2 02/21] coccinelle: misc: Add secs_to_jiffies script To: Christophe JAILLET References: <20241115-converge-secs-to-jiffies-v2-2-911fb7595e79@linux.microsoft.com> <20241116060541.5798-1-christophe.jaillet@wanadoo.fr> From: Easwar Hariharan Content-Language: en-US In-Reply-To: <20241116060541.5798-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0528E100004 X-Stat-Signature: 1nzhp8wkhauofbq5y4qhp15hyjhjxopd X-HE-Tag: 1731953306-139777 X-HE-Meta: U2FsdGVkX19KjIq9usuqpVE4vmYdRdncF3PmCJ7fzs5Rxn/ToNIrVjmH67U1TSYdTkIjdPUioiv7/fGfRYkPwCtqxliPzWsCaU37TMPb36R0lTc5kDkLc1A/5+oSsFc2bAMmzqymThqMXrMG7Hl5blN3IqTSllqzk3clKPgWV8eIeg3qkgjV0eUjtMea0VS+2tY83z9cyZAN0Ok6U14OsGPJ7e7wu7MCr6umsHmwqQWV+ZKOX5HQjxlj5uFoxidZw0pgJcs10Q/GoDHy36gzacAoiRoxggBNGzcxNF/rCaOuazaEWxu2xokEkkZtYq9eSaX/slCgxbkGPOvJRM6ZGj9tBvmPlxcGzDy7Pow6Ph0pxZbFlnwMhYQBX05gUGnbCyg7qQk411+45JzRzhfNygwzUglLtzYOaN7nh6ZxeFx6vOrS4bnkB8eDeRqGxjS7AQdzsYARry2j9V0rXSq08DVsFfo0RAIE7Ka+XN0Lko/RZhtRkdiloZRFFO1ZWVPMGCHYB+sQoZhr+bPofRLUId8sdfbA05QWjyiBlSYOxSoBzQ7//mqfeTdYRYcYZxz0bpn5jVfQ4M898GfBJFtlK8UqWGvln0cuy6XmRdPOWQd0JNq6lGg8OZHFUFqAesRdER7Xg8PVP//VarCvw03HVD1cq8W0G5Ah5UHbNffzkGxUrbDXjRVdP5r2d1At9jsHwTXUAUIcptVNMHWZCZmltfzeyjINaWZKw8oa9GHohLn3Uxua6UNdsZj6kgZi6tSDBG5l1Z23lEA86ivZFau1tTHeUA2GgkHHCsNG66XUEviIf/wGIdTit8q5he4VZcA3w2m/sSaZ11faymr/C/PC9bHyBApQpYgkGSmTUPPymbWSjAsN+zcSZRBrxUp6shF8MB38nRA5qOq2k8nH/ge6lKwWvfJCCbdcfVcbcukFcq4vM6uTo/waLBGri9SXWQzGHaUHr2EhabM9hB5wMeD iUsIAiGY uO9O6+BPVFGp/oi5M4HIOsOznafQTGijiIscU5neqM8XKuJCCSmCZu1ezeyX5zRwV7PddoKRazKrKBMHP8sUcSAazIdI0R68jjvLgPcW0kNnCtprjBj33qYlrpbEKZNzXZsF2fd4M2MMdmZHx2VRTvjFoEjUBDcyPlwqdZIvMqQYCq6AR7d+wJJFYVP/r0TGY30WKCmt/B7KL9xrCvc/tYCYdj6EcW2ZXRF5LbZr5UecNB8F2Skm1fCuJ9aw6ps6z36S7k0RI/OOdIZHNzr9IZRnHti46+vwi8FkmAySjl0C4o0y3yNPTSFWlum4at4J57hzUlcc/3N8dxsxrrAUJJclQ3TRcSOewYmz9IY1Fo6k5acvaPWYXOFpK3jN6BiV56aAN/gOtxd3mwA5mNrhvHL/+oa/kXwkSOiAELN5gDLpWNYLpODa+Bvsu/8kNbW3K7elfa3RTdBDrg9fM9K/SJtsq6gxWmM+eEQmTcgS7fALydxYsqx6NKidwpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.023155, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/15/2024 10:05 PM, Christophe JAILLET wrote: > Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : >> Suggested-by: Anna-Maria Behnsen >> Signed-off-by: Easwar Hariharan >> --- >> scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci >> new file mode 100644 >> index 0000000000000000000000000000000000000000..af762b1c0aac8f044f21150bfaafd9efc834ee87 >> --- /dev/null >> +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci >> @@ -0,0 +1,21 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/// >> +/// Find usages of: >> +/// - msecs_to_jiffies(value*1000) >> +/// - msecs_to_jiffies(value*MSEC_PER_SEC) >> +/// >> +// Confidence: High >> +// Copyright: (C) 2024 Easwar Hariharan Microsoft >> +// >> +// Keywords: secs, seconds, jiffies >> +// >> + >> +@@ constant C; @@ >> + >> +- msecs_to_jiffies(C * 1000) >> ++ secs_to_jiffies(C) >> + >> +@@ constant C; @@ >> + >> +- msecs_to_jiffies(C * MSEC_PER_SEC) >> ++ secs_to_jiffies(C) >> > Hi, > > @@ constant C =~ "000"; @@ > > * msecs_to_jiffies(C) > > also spots things like msecs_to_jiffies(1000) > > I'm not sure that coccinelle is enable to capture part of the regex to automate the removal of the 000 when converting from ms to s. > > Just my 2c, > > CJ Thank you, I'll try that rule for the later parts. Thank you all for helping with writing Coccinelle rules, I'm not familiar with metaprogramming in general and Coccinelle in particular, so these are super helpful. - Easwar