From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3542FEB64DD for ; Wed, 9 Aug 2023 10:11:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A26256B0071; Wed, 9 Aug 2023 06:11:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D6A36B0074; Wed, 9 Aug 2023 06:11:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 876578E0001; Wed, 9 Aug 2023 06:11:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7327A6B0071 for ; Wed, 9 Aug 2023 06:11:05 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2CD7CB239B for ; Wed, 9 Aug 2023 10:11:05 +0000 (UTC) X-FDA: 81104148090.23.355A9C4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 4249C4000B for ; Wed, 9 Aug 2023 10:11:02 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SLiD6EwB; spf=pass (imf17.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691575863; a=rsa-sha256; cv=none; b=dx2aGtKQF9yEcKqpOEPIbXogW0b4qqt+143C8nEcbFkHYYoEuUv/T81qgoVVlzQW4BNpKi Tealu61Qfi3cW3x4Xq/Afuafvija0TXD+VqT1rsTq1PBtcGZEvCVxNpnTkm/JiQd2/xCus 5QW+ykeYkKTxJDP+QBqFjv+mnzeMho8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SLiD6EwB; spf=pass (imf17.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691575863; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Eo2i7uJldKNgBm+LFT1PDtuMgoSPe8eMQdEaVs2mYLQ=; b=n3lsU/lX/PHQGNfOwQIS9MyX/79Dt+eWWiSqLajgFpsSKUZhhS0ZvxNCcbHCeL4JKXeV+9 olHNLwccL0Z3kufbU036jai2n7TkOpjTWWD6mX8oNmx5W1RaQhNIt368a1k8DPHo7JsrA9 M66ux390qSybjQJ3vMV8M9VSZ8qA3vg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0F082630EB; Wed, 9 Aug 2023 10:11:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CD92C433C7; Wed, 9 Aug 2023 10:10:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691575861; bh=3EDdk7dTfHs3Hy9RVE0ybDbynTaUkeq4N9itCD5SIYI=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=SLiD6EwBwAaKjaENOfNjWpIjgTZ7uN7B4ABF6+Bc5uUdhACL29f5ZDgIl8J0BIcLg dmmWF/N3vxvPZnbf7qCfoiMntKQ5KpepxLV423OWizDLKnMdMdTqG2pBQ96c7iVI/q 6jxcOzT1tUDuUKredqtZ802zOA9COiRKKjMvkV8B5wrgxL3TdF/tBsrcopqwbxnBca PDqh4/C6S52dVHwYp/5zmkTrm4IUk3O7TYiV8whC/vrlI1m9OAGJxPareUgxFZUC+2 I7slyRMFE6wXePxHgLcOI25zOvoPWown/lV3vive98S0wwvTwTzicYt9+73JrhgKdm fHO15Q9CkD8KA== Message-ID: <52bead1d6a33fec89944b96e2ec20d1ea8747a9a.camel@kernel.org> Subject: Re: [PATCH v7 05/13] fat: make fat_update_time get its own timestamp From: Jeff Layton To: OGAWA Hirofumi Cc: Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Date: Wed, 09 Aug 2023 06:10:53 -0400 In-Reply-To: <87msz08vc7.fsf@mail.parknet.co.jp> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-5-d1dec143a704@kernel.org> <87msz08vc7.fsf@mail.parknet.co.jp> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4249C4000B X-Stat-Signature: zskhhit6o3hz5t4x957yp7deu7utsgwe X-Rspam-User: X-HE-Tag: 1691575862-310593 X-HE-Meta: U2FsdGVkX18LKlWiYGBd3bqbMiyTT5dl76tjsxTYKnokRz6jFWocN3jfb9B4u6cVxSAEWdb7Yv4UqFbsc33DupjI/nhKWNTjqcizXvpux9O4MHGqKHbJXAXiVTCIIZHuKyPZqRhmHhNElPsXJL00qBoc/gUvUlFSkIRRQNBZBL/Qu+5+Sn4j2g8tjBleTrJ832EZW7o8X4baXi49AerthWo18havZAXzrqEAPedhMw17AMTc4loxP3FtN4TO5JnsYM2tWXzX89feYHDYKb7kLXSd6H7suO/wMmqFtaypH+VcPejvpIdaUgp1EfgscEuTuvJn+XYQwA9B12By8jQFirSKxzDE+Wbs5X8A/gAf+SnOYiMzH8GObE0khRyQpxNqgguSWpRLGeoGgVKus1HUW2JZ8or0afLH+Nd34DJRf01Wu/xv/K1tAWwI+WOCvEq3K3Z5nvlA9IJQ1OCOw+37X85ZT6cYcK+6NfrQ51hpq4kj9SMDTpGJoAM1NH7PUkgeFJm8cXVQjqYAVktK6FYfeMobsg3oCIAdPqZrL1BRAeekqqrS5EUJ9Emo/1ZeIhbrcvD550xSm+Ch0Hh1VC7OcF8b12CSZH9iaxf4lgio5ioHzxErntm9sknZq7MrDFD7ssKmMVvyj85O6Un8EH6sD1WMmhdH2zg5QoD+/gC0zxIIqsMmiMj9PEATTBKRB/9qYACYj+PhslnmmQqgfK1r2cch2czEnzQ5Iag8K+eUcC3VAqr41JsdHdVT/QmQqFGz0tlIAZ23t67BWIwtNwBqh0SHDt2SvCB94Au/u8koj7XKgMABzTxIsOpH2KSeFDwdc4M2xduNgTIbrMM7jkRPEHjNd+pHmOrGYH53a9g4lOijhRTZCJJQlYugQcsukwAOr1LoaEEcE8qCDh8WnV3sPmjRn2sCxlrVwQDPsHI7W1KWvqO9w5R1FOH/vD+i9jEFcVnVgTZb3Mv007HauMh XNFA8lTs uetFedZa1cMjTDzfrbY764kmU0bE1BhC1PfzozL/hl5wxlwq81JTXKpSPsNiomC8wDfdr4O4k6IkGc9SdV6ynXguHW2eU6rDyMA5LnQiod3ZZsqQznWNDmzNT/xIvMt6pgCPkDJODZFkwqEfMyFLWIa0HXnHc5w5HpCw174jt0meby7KbUA5JN/uNiIQWXvLoGH5gmtbxFejZ5zrwucG8VOLhAPabJsyfG8pIv7Chs81IE23QOXq+Gr4x5v/AgAKBakNMZlWivahBsc0XeAsNxK+IDenc/P6Z0FmCxZ8ni8ivL3yPJeB99o7FxatdIob2UUXFqayTuPmr2Ha3ymPYiyz+Ga1CtFkCLiCzii95mQA65qT65Ze+jySYyl4f7qDtBYUjCUWjnOtfM+Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2023-08-09 at 17:37 +0900, OGAWA Hirofumi wrote: > Jeff Layton writes: >=20 > > Also, it may be that things have changed by the time we get to calling > > fat_update_time after checking inode_needs_update_time. Ensure that we > > attempt the i_version bump if any of the S_* flags besides S_ATIME are > > set. >=20 > I'm not sure what it meaning though, this is from > generic_update_time(). Are you going to change generic_update_time() > too? If so, it doesn't break lazytime feature? >=20 Yes. generic_update_time is also being changed in a similar fashion. This shouldn't break the lazytime feature: lazytime is all about how and when timestamps get written to disk. This work is all about which clocksource the timestamps originally come from. > Thanks. >=20 > > Signed-off-by: Jeff Layton > > --- > > fs/fat/misc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/fs/fat/misc.c b/fs/fat/misc.c > > index 67006ea08db6..8cab87145d63 100644 > > --- a/fs/fat/misc.c > > +++ b/fs/fat/misc.c > > @@ -347,14 +347,14 @@ int fat_update_time(struct inode *inode, struct t= imespec64 *now, int flags) > > return 0; > > =20 > > if (flags & (S_ATIME | S_CTIME | S_MTIME)) { > > - fat_truncate_time(inode, now, flags); > > + fat_truncate_time(inode, NULL, flags); > > if (inode->i_sb->s_flags & SB_LAZYTIME) > > dirty_flags |=3D I_DIRTY_TIME; > > else > > dirty_flags |=3D I_DIRTY_SYNC; > > } > > =20 > > - if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false)) > > + if ((flags & (S_VERSION|S_CTIME|S_MTIME)) && inode_maybe_inc_iversion= (inode, false)) > > dirty_flags |=3D I_DIRTY_SYNC; > > =20 > > __mark_inode_dirty(inode, dirty_flags); >=20 --=20 Jeff Layton