From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Sasha Levin <sasha.levin@oracle.com>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm/rmap: fix BUG at rmap_walk
Date: Thu, 19 Dec 2013 14:14:25 +0800 [thread overview]
Message-ID: <52b28ecd.23b6440a.2262.603bSMTPIN_ADDED_BROKEN@mx.google.com> (raw)
In-Reply-To: <20131219060703.GA27787@lge.com>
On Thu, Dec 19, 2013 at 03:07:03PM +0900, Joonsoo Kim wrote:
>On Thu, Dec 19, 2013 at 02:55:10PM +0900, Joonsoo Kim wrote:
>> On Thu, Dec 19, 2013 at 01:41:55PM +0800, Wanpeng Li wrote:
>> > This bug is introduced by commit 37f093cdf(mm/rmap: use rmap_walk() in
>> > page_referenced()). page_get_anon_vma() called in page_referenced_anon()
>> > will lock and increase the refcount of anon_vma. PageLocked is not required
>> > by page_referenced_anon() and there is not any assertion before, commit
>> > 37f093cdf introduced this extra BUG_ON() checking for anon page by mistake.
>> > This patch fix it by remove rmap_walk()'s VM_BUG_ON() and comment reason why
>> > the page must be locked for rmap_walk_ksm() and rmap_walk_file().
>
>FYI.
>
>See following link to get more information.
>
>https://lkml.org/lkml/2004/7/12/241
>
Interesting, thanks. ;-)
Regards,
Wanpeng Li
>Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-12-19 6:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 5:41 Wanpeng Li
2013-12-19 5:55 ` Joonsoo Kim
2013-12-19 6:07 ` Joonsoo Kim
2013-12-19 6:14 ` Wanpeng Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52b28ecd.23b6440a.2262.603bSMTPIN_ADDED_BROKEN@mx.google.com \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox