Re: [PATCH v8 1/4] sched/numa: drop sysctl_numa_balancing_settle_count sysctl

[Wanpeng Li <liwanp@linux.vnet.ibm.com>]

On Sun, Dec 15, 2013 at 05:56:43PM +0100, Peter Zijlstra wrote:
>On Sun, Dec 15, 2013 at 04:41:10PM +0800, Wanpeng Li wrote:
>> Do you mean something like: 
>> 
>> commit 887c290e (sched/numa: Decide whether to favour task or group
>> weights
>> based on swap candidate relationships) drop the check against
>> sysctl_numa_balancing_settle_count, this patch remove the sysctl.
>> 
>> Acked-by: Mel Gorman <mgorman@suse.de>
>> Reviewed-by: Rik van Riel <riel@redhat.com>
>> Acked-by: David Rientjes <rientjes@google.com>
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>> ---
>> Changelog:
>>  v7 -> v8:
>>    * remove references to it in Documentation/sysctl/kernel.txt
>> ---
>
>No need to insert another --- line, just the one below the SoB,
>
>> Documentation/sysctl/kernel.txt |    5 -----
>> include/linux/sched/sysctl.h    |    1 -
>> kernel/sched/fair.c             |    9 ---------
>> kernel/sysctl.c                 |    7 -------
>> 4 files changed, 0 insertions(+), 22 deletions(-)
>
>Everything between --- and the patch proper (usually started with an
>Index line or other diff syntax thingy), including this diffstat you
>have, will be made to disappear.
>
>But yes indeed. The Changelog should describe the patch as is, and the
>differences between this and the previous version are relevant only to
>the reviewer who saw the previous version too. But once we commit the
>patch, the previous version ceases to exist (in the commit history) and
>therefore such comments loose their intrinsic meaning and should go away
>too.

Thanks for your great explanation. ;-)

Regards,
Wanpeng Li 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>