From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B57CC433B4 for ; Thu, 20 May 2021 11:56:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D267660FEE for ; Thu, 20 May 2021 11:56:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D267660FEE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 56B756B00C0; Thu, 20 May 2021 07:56:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52D2B6B00C1; Thu, 20 May 2021 07:56:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 346058E0002; Thu, 20 May 2021 07:56:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id F09486B00C0 for ; Thu, 20 May 2021 07:56:21 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 97183BF1D for ; Thu, 20 May 2021 11:56:21 +0000 (UTC) X-FDA: 78161456562.03.AF6CEAC Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf26.hostedemail.com (Postfix) with ESMTP id 90EA940002F1 for ; Thu, 20 May 2021 11:56:20 +0000 (UTC) Received: by mail-qt1-f169.google.com with SMTP id f8so12504581qth.6 for ; Thu, 20 May 2021 04:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:to:cc:references:from:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4NwcGNbUiLWOZxk3Po/t8ltzFfv9Dmek7i9uGh5YXhs=; b=tMou58N9AsYp7b3didtdforKkhve5y6UEbSKe9s9y/TlxOj/Rgb07i/jT6K+OSXcXD NogA0utjZXXCu46qXSFt7fbeyIDmqp7VC0DpIouJzA/gcBb4b8oLwxxhEeE8G1Qd7Ca+ Rgqvz3BeWv38aRsnVs0fTfbH52ZHb9+8qNUmri0jMSznuhnMS5gY2HXMPkcOUqjw8dLT Wwr6H3uofyYxmpMlFqw+BhtLFQoYtr+bzZALH1TcmsO2dKaXKNFvgSUKqMuGz+CV0qHw kFqrsU0fPgFpqRcVb4r4WFuv9Y44eQTX0luZoqGvF5svEYJaqEMWjSjJQ8ofU7tsi57c DmaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:cc:references:from:subject:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4NwcGNbUiLWOZxk3Po/t8ltzFfv9Dmek7i9uGh5YXhs=; b=FBDFSpsFKVA1nVDUsOEluSEe397viyoT7+unNeZSujXHAG+yrgVrA0/M8+dGu8qVMO ERw3FpeXqSrGxp68PpB7saTDfcvsr4dx48kaMhzS7LJzChtlYT1Fi+wI8LN26DShnjXu QENXW0YxF179hzhgwXgg0/EVbPPI4D9hiiNQiIsRSyM3bYM8m6W0DoUMwlDE1eaSzZC8 VXAH9mt8OyaZAa40h8Q3uAB/BYJwvq/rPwZ2TfOtcZXnIQyKM4dxAF7MPJ3aP9Hc5Dvs kAmWPIyBLKSZhWjn5IhmEvzPe/unRqkKaZyGcWYU8C1Er60nox90Hc8Zc/U1pbnRDMr8 eXXw== X-Gm-Message-State: AOAM532O6O2eaBtplGpUP31Bnh3zvAmOGOV9kRRX0ak8CQCxumdxjSMy BZGl/QVA2eGZmI5lsF2+UiQ= X-Google-Smtp-Source: ABdhPJwbtFMmRH/lQLxI0xaeHJA4iAHYjZ+u77Kze81ydq8mtfRcYReCgbscjlFfUq1VbMIJ2FPePA== X-Received: by 2002:aed:2128:: with SMTP id 37mr4519811qtc.163.1621511780559; Thu, 20 May 2021 04:56:20 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id j6sm1715403qti.4.2021.05.20.04.56.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 May 2021 04:56:20 -0700 (PDT) To: Michael Ellerman , "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, kaleshsingh@google.com, npiggin@gmail.com, joel@joelfernandes.org, Christophe Leroy References: <20210422054323.150993-1-aneesh.kumar@linux.ibm.com> <20210422054323.150993-6-aneesh.kumar@linux.ibm.com> <20210515163525.GA1106462@roeck-us.net> <87pmxpqxb1.fsf@linux.ibm.com> <87a6ork1qp.fsf@mpe.ellerman.id.au> <969f377f-fddb-c2de-781c-fde37d121a4d@roeck-us.net> <87wnrtiqjp.fsf@mpe.ellerman.id.au> From: Guenter Roeck Subject: Re: [PATCH v5 5/9] powerpc/mm/book3s64: Update tlb flush routines to take a page walk cache flush argument Message-ID: <52aa88b9-1f88-dc5f-c3f5-b7ead24e38df@roeck-us.net> Date: Thu, 20 May 2021 04:56:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87wnrtiqjp.fsf@mpe.ellerman.id.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Queue-Id: 90EA940002F1 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=tMou58N9; dmarc=none; spf=pass (imf26.hostedemail.com: domain of groeck7@gmail.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=groeck7@gmail.com X-Rspamd-Server: rspam03 X-Stat-Signature: t4ctpxbt1b9ssjiwwp4ozh8bf1cgg79c X-HE-Tag: 1621511780-81871 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/20/21 4:38 AM, Michael Ellerman wrote: > Guenter Roeck writes: >> On 5/18/21 5:26 PM, Michael Ellerman wrote: >> [ ... ] >>>>> That was the generic header change in the patch. I was commenting a= bout the >>>>> ppc64 specific change causing build failures. >>>> >>>> Ah, sorry. I wasn't aware that the following is valid C code >>>> >>>> void f1() >>>> { >>>> return f2(); >>>> ^^^^^^ >>>> } >>>> >>>> as long as f2() is void as well. Confusing, but we live and learn. >>> >>> It might be valid, but it's still bad IMHO. >>> >>> It's confusing to readers, and serves no useful purpose. >>> >> >> Agreed, but it is surprisingly wide-spread. Try to run the coccinelle >> script below, just for fun. The script doesn't even catch instances >> in include files, yet there are more than 450 hits. >=20 > Yikes, that is a lot. >=20 > I guess they're pretty harmless, but would be nice to clean them up > eventually. >=20 > Why doesn't the script work for instances in headers? >=20 Ah, that is one of those Coccinelle details. No idea. I run the script wi= th make coccicheck COCCI=3D"return-void.cocci" MODE=3Dreport M=3D. Probably there is a better way to invoke it which does handle include fil= es. Guenter