From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8AE6C636CC for ; Mon, 13 Feb 2023 17:46:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 435AC6B0073; Mon, 13 Feb 2023 12:46:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E4616B0074; Mon, 13 Feb 2023 12:46:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AB836B0075; Mon, 13 Feb 2023 12:46:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1B7496B0073 for ; Mon, 13 Feb 2023 12:46:12 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DA84C1606D2 for ; Mon, 13 Feb 2023 17:46:11 +0000 (UTC) X-FDA: 80462997342.09.C8419F2 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf03.hostedemail.com (Postfix) with ESMTP id 6F95920026 for ; Mon, 13 Feb 2023 17:46:08 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=kVzPuTIf; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf03.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676310368; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5iaJreDllW4Zy4J2gD2I+zLH2sSm/5kcAydV/Whkl50=; b=IIHOUrRK8OPpq/EvQx6/HX7Tqxdru3HeT3w9nj26tMl0dp3KkvOWV1+c9fbvYRRgandBrh yEyyhViTTtTKtRwSMbeeA8th5F+fF8AMCz+ybr1lbXKC8XGX8nNTTvvlV74/UCi8Q3FOf4 HBmjc1PuLfJGegdj5wY5JP1Qegr6HXw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=kVzPuTIf; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf03.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676310368; a=rsa-sha256; cv=none; b=Bw2AK9SklRsKNtz+8s8KC9d3LaLi6GOXR5KSa2FwrkmdDBeoNnM6YZow4k5uHbRfebEYtk JLWfHTtlPaZLhVsJeYky9rQpSmnOmwXwMxzP5UxyP43zgd4VUSRcRFXrBSjEiM8qPiRfKE dWWbVow926gdE7JqJqCxBsCp2DVcjpc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1676310367; bh=bjIdrq7E7T3M1MvC4x5lbyHOfWJfEa4UUs+f0ZSzvLo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kVzPuTIfA2sXNFdhJk/1b1s4uKm8ICG0Z1j0EkuKl4Ak+n+7mXGMI0tGuEJpz9ykd m4Yis8VvRX5n3+GHp68aG95M/4efD4oisZWmO5zdDix6w6HfjYkF4Un0Feyh3xUoXQ GLilc1pSgwz1NLkZxrDmTVH6UGcB0xDduN3+j2hpKaBWGRrkjaovRMUaWA8TLqqDvX vUWMFLkqTk/HMmrVArZxP9mMuWp2AZiSVbMGUsvWZ8puZ28ciZOCgpGwAMQeSWCbCK 6IcjlC1j9XiM6XrJJpHJqQSEwhThnTbRUr2gV9kFAwfxKTUikdRvhGV1jmSYeBzqVw JHSbLcylDKTSw== Received: from [172.16.0.188] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4PFsFp6TdfzlHF; Mon, 13 Feb 2023 12:46:06 -0500 (EST) Message-ID: <52a9f138-45f0-ca05-b67a-d734663984df@efficios.com> Date: Mon, 13 Feb 2023 12:46:06 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 7/7] tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN Content-Language: en-US To: Namhyung Kim , Steven Rostedt Cc: Yafang Shao , John Stultz , Alexei Starovoitov , Andrew Morton , Network Development , bpf , "linux-perf-use." , Linux-Fsdevel , linux-mm , LKML , kernel test robot , kbuild test robot , Andrii Nakryiko , David Hildenbrand , Arnaldo Carvalho de Melo , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro , Kees Cook , Petr Mladek , Kajetan Puchalski , Lukasz Luba , Qais Yousef , Daniele Di Proietto , Linus Torvalds References: <20211120112738.45980-1-laoar.shao@gmail.com> <20211120112738.45980-8-laoar.shao@gmail.com> <20230208212858.477cd05e@gandalf.local.home> <20230208213343.40ee15a5@gandalf.local.home> <20230211140011.4f15a633@gandalf.local.home> <20230211224455.0a4b2914@gandalf.local.home> From: Mathieu Desnoyers In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6F95920026 X-Stat-Signature: iykccm396zsxxkqy5338wioy8hi6ihsd X-HE-Tag: 1676310368-791128 X-HE-Meta: U2FsdGVkX1+Hda6SsOaTauQC58WsiRV4GYD1ye82BAiUQHNMPNep/6A53KsfcLkJWPEmZ7VlHrYMn911viVSA6YMfcbuJk/+Xf9mBavHqFgPzA3qe3iKZI3R7LYfPGIe2coNPBaQm11CpqBZPfyTOHmUXrqPsIGZg7w64d3E1t2Gt4zB/1+U+SZxKKN/MZ3ggiwUieZKMakaKPXRUC5iASqCFb0ojrX2GnvWJByDfOZtT6xeyd7yta3bWNmOvJ3/TfjxQalDjSWnr669Tu6+RRXD+m1Cb/E4fc7GQths95veQW1+FH1xNZUy3pQxLK967kdHOTsLzEeEilG8DdpvcXunc+h38uKbv47FnP/YHupQxGDJqMJYrqurVhNAjLJ0aZWoA37Rf/SgHCtEQ4zTrD/dcfGFAz4Vrp+KnJaIj+/9M/q78FQzyTHJGyKOiX3BVPZB8zg4WahgMidzvgDNAjO+PZFDbfoCQTeC+bqTuk9LL4BAPf5mPkz7YVZZQvG00b3Z52cqOjNkYGFrRjJG+a/Q2MOqtLPW+z8fFB2r0RlV59UGQbMqvR/81vMgpII0o2KADc2jbW7uzQI9szdQVbH22ntJsFXYfYPtSuPu18R1G+DgOZPRI40o2snGuegW2d4cEDw5XBNoQ4chLvJ38FVocyQ4aW+kjQ3tzjXAMDvIZsxz5BkxUR5ymazUDamGOq/OWxT2nviZ8Tc2Ja5Krf4ftMwQOHPo3kskWf2ihUdqkD2p0IEnSOULhmA0wQiY40ukDkIyqG+YMaXKJI12e9a1aCIQr4o0BfmqQ6LUjOV/ts2KHR1DdgwlR50bXEaMMNnWbha8MFNnW5PeLdfjpO2CASNaGVaLS+R+yu2+nDkT2lvPDCG3FuZ0srCfROGSftVP0QO+jg1nwnlA/Y2A8tfJGKJZJImLm6nyfTIV6weNTd0yEfovpVjZsNm8zOdJyDYjvJOoZEAAgtwnx2Q MQXwyNbr Qy+IW9C7H4zy2/DgNSy/Ta/nSexHbpNOy/r1ZsiZBs4oQ+v/FzJ/niIIB1FoYkoC3hvH7eTIc3/LYjZ1sKlNoyabTfnlFjXTgVE/aYFORdiqRV7Gu4t9F4u/a27syDncrKVLWvRwp5EOYPiEoJ5sK2HY7p5Fkk0Us0vqOu+u1NJyUF/kOy1anzwnAkZEBQ3wUpwIH40GJv0fs0LAVl2s8Awk4Cg+M/rm7Ru2Q86ezgQUCBnr6kGkMqT15TMEvV2H17T3JTXBSJr+//aYhSnoxhaShxqLOPrz4kgceJKrQnW5rnj0KGTIe1VheYc8g6AdaR4d0Gc4ImAdP7vL7xrebH7gxEAnBBA6xosxmE0On1vAEtDhNXce9zBw0EspkSPCMVeTMqnT86dZDXW83+xuRvHpn3D0g4fyhWElyEF9Ikpkqz4An1rAmia9BTStfuKHbjsS/BUFGhk8fSI11xWsYrDZSCMXfu4ygJ0RzH9dv2VbYLntVQ3Pxy8WqNPixIux7Gp3qSEiH7Lr+TUNjHDQaVeIqkptbdGYJihjw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023-02-13 12:43, Namhyung Kim wrote: > Hi Steve, > > On Sat, Feb 11, 2023 at 8:07 PM Steven Rostedt wrote: >> >> On Sun, 12 Feb 2023 11:38:52 +0800 >> Yafang Shao wrote: >> >>>> Actually, there are cases that this needs to be a number, as b3bc8547d3be6 >>>> ("tracing: Have TRACE_DEFINE_ENUM affect trace event types as well") made >>>> it update fields as well as the printk fmt. >>>> >>> >>> It seems that TRACE_DEFINE_ENUM(TASK_COMM_LEN) in the trace events >>> header files would be a better fix. >> >> NACK! I much prefer the proper fix that adds the length. > > Can we just have both enum and macro at the same time? > I guess the enum would fill the BTF and the macro would provide > backward compatibility. This is no need to keep the define. The root cause of the issue is addressed by this fix: https://lore.kernel.org/lkml/20230212154620.4d8fe033@gandalf.local.home/ Thanks, Mathieu > > Thanks, > Namhyung -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com