From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>, Rik van Riel <riel@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v5 7/8] sched/numa: fix record hinting faults check
Date: Wed, 11 Dec 2013 17:41:56 +0800 [thread overview]
Message-ID: <52a8336e.23b6440a.5215.37a6SMTPIN_ADDED_BROKEN@mx.google.com> (raw)
In-Reply-To: <20131211091422.GU11295@suse.de>
Hi Mel,
On Wed, Dec 11, 2013 at 09:14:22AM +0000, Mel Gorman wrote:
>On Wed, Dec 11, 2013 at 08:50:00AM +0800, Wanpeng Li wrote:
>> Adjust numa_scan_period in task_numa_placement, depending on how much useful
>> work the numa code can do. The local faults and remote faults should be used
>> to check if there is record hinting faults instead of local faults and shared
>> faults. This patch fix it.
>>
>> Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>
>This potentially has the side-effect of making it easier to reduce the
>scan rate because it'll only take the most recent scan window into
>account. The existing code takes recent shared accesses into account.
The local/remote and share/private both accumulate the just finished
scan window, why takes the most recent scan window into account will
reduce the scan rate than takes recent shared accesses into account?
>What sort of tests did you do on this patch and what was the result?
I find this by codes review, I can drop this patch if your point is
correct. ;-)
Regards,
Wanpeng Li
>
>--
>Mel Gorman
>SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-12-11 9:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 0:49 [PATCH v5 0/8] mm: sched: numa: several fixups Wanpeng Li
2013-12-11 0:49 ` [PATCH v5 1/8] sched/numa: fix set cpupid on page migration twice against thp Wanpeng Li
2013-12-11 0:49 ` [PATCH v5 2/8] sched/numa: drop sysctl_numa_balancing_settle_count sysctl Wanpeng Li
2013-12-11 0:49 ` [PATCH v5 3/8] sched/numa: use wrapper function task_node to get node which task is on Wanpeng Li
2013-12-11 0:49 ` [PATCH v5 4/8] sched/numa: fix set cpupid on page migration twice against normal page Wanpeng Li
2013-12-11 9:01 ` Mel Gorman
2013-12-11 0:49 ` [PATCH v5 5/8] sched/numa: use wrapper function task_faults_idx to calculate index in group_faults Wanpeng Li
2013-12-11 9:02 ` Mel Gorman
2013-12-11 0:49 ` [PATCH v5 6/8] sched/numa: fix period_slot recalculation Wanpeng Li
2013-12-11 9:02 ` Mel Gorman
2013-12-11 0:50 ` [PATCH v5 7/8] sched/numa: fix record hinting faults check Wanpeng Li
2013-12-11 9:14 ` Mel Gorman
2013-12-11 9:41 ` Wanpeng Li [this message]
[not found] ` <20131211094156.GB26093@hacker.(null)>
2013-12-11 10:15 ` Mel Gorman
2013-12-11 0:50 ` [PATCH v5 8/8] sched/numa: drop unnecessary variable in task_weight Wanpeng Li
2013-12-11 9:21 ` Mel Gorman
2013-12-11 9:34 ` Wanpeng Li
2013-12-11 14:50 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52a8336e.23b6440a.5215.37a6SMTPIN_ADDED_BROKEN@mx.google.com \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox