From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Vladimir Murzin <murzin.v@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hwpoison: add '#' to hwpoison_inject
Date: Tue, 10 Dec 2013 07:35:23 +0800 [thread overview]
Message-ID: <52a653c4.c206440a.6a1a.ffffc3a3SMTPIN_ADDED_BROKEN@mx.google.com> (raw)
In-Reply-To: <20131209162723.GA2236@hp530>
Hi Vladimir,
On Mon, Dec 09, 2013 at 05:27:27PM +0100, Vladimir Murzin wrote:
>Hi Wanpeng
>
>On Fri, Dec 06, 2013 at 05:26:53PM +0800, Wanpeng Li wrote:
>> Add '#' to hwpoison_inject just as done in madvise_hwpoison.
>>
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>> ---
>> mm/hwpoison-inject.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
>> index 4c84678..146cead 100644
>> --- a/mm/hwpoison-inject.c
>> +++ b/mm/hwpoison-inject.c
>> @@ -55,7 +55,7 @@ static int hwpoison_inject(void *data, u64 val)
>> return 0;
>>
>> inject:
>> - printk(KERN_INFO "Injecting memory failure at pfn %lx\n", pfn);
>> + pr_info(KERN_INFO "Injecting memory failure at pfn %#lx\n", pfn);
>
>You don't need KERN_INFO here.
>
Ah, indeed, I will fix it. Thanks.
Regards,
Wanpeng Li
>Vladimir
>
>> return memory_failure(pfn, 18, MF_COUNT_INCREASED);
>> }
>>
>> --
>> 1.7.7.6
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-12-09 23:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 9:26 Wanpeng Li
2013-12-06 17:48 ` Naoya Horiguchi
2013-12-09 16:27 ` Vladimir Murzin
2013-12-09 23:35 ` Wanpeng Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52a653c4.c206440a.6a1a.ffffc3a3SMTPIN_ADDED_BROKEN@mx.google.com \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=murzin.v@gmail.com \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox