From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F91C02185 for ; Mon, 20 Jan 2025 07:45:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CAD486B0082; Mon, 20 Jan 2025 02:45:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C36A66B0083; Mon, 20 Jan 2025 02:45:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A61D06B0085; Mon, 20 Jan 2025 02:45:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 83A8D6B0082 for ; Mon, 20 Jan 2025 02:45:17 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EF48E4A263 for ; Mon, 20 Jan 2025 07:45:16 +0000 (UTC) X-FDA: 83027044632.28.91AF745 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 73BE3140017 for ; Mon, 20 Jan 2025 07:45:14 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Wc+IGmxE; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737359114; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ElOuSTTZEFaFvEWF+0enicKVOtWt5Iuh94BDpIXb40Q=; b=InxsFth4/IQSt899zcOGYrUGlY8a+roLHHhE6EvqpMDJlyKV+wHhpjxVI0+c0o7E5k6xVo R0gyt4dcd4PDHicvkhfwHbT4udCGfR0UfEEBxkja45RYfih3XuSrDwh27eEm13ELR0Hgno HOwvrb7ABDf64jvd3TL8yDTSAW4i6N8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Wc+IGmxE; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737359114; a=rsa-sha256; cv=none; b=bp4LlkoejwInV6VDJxdmkeJb0c8OBGi2uamctEoueKzHlv/Q+WusjTs86wrUkA5vflAoLH 1uWcvQOF20hKbnWb7mK8fE32lXRvx5djni0fWu6vIYWn65JgJcJDv7trbR9cnyLArBjD1D 4edmJLGqptl/VsXWjmv/O/4x3Vjym4c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737359113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ElOuSTTZEFaFvEWF+0enicKVOtWt5Iuh94BDpIXb40Q=; b=Wc+IGmxEda22vEmGiy9mUiKLnR3D0tdj0oq7GCHq7tHI0jrHHRb0W+LXFHW/Q8+gDEEYOH Z/1hjBZMsfaBygy+T589SWz18WZeA0jEHd/ltkCgbnYo35/i0D39ORyfKjbjDcKkdXf4Hf ZOUdipjaitmC8tJ/Hbm415tGEfXlK2E= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-312-SwJMNHNAPAGrwpybql6d0g-1; Mon, 20 Jan 2025 02:45:11 -0500 X-MC-Unique: SwJMNHNAPAGrwpybql6d0g-1 X-Mimecast-MFC-AGG-ID: SwJMNHNAPAGrwpybql6d0g Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4359eb032c9so32542605e9.2 for ; Sun, 19 Jan 2025 23:45:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737359111; x=1737963911; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ElOuSTTZEFaFvEWF+0enicKVOtWt5Iuh94BDpIXb40Q=; b=OeET7p/sCTXkDLEy1W6K+tSL73xdu+2O21s8wfg4uuRo0G8qGetMrro9wLtdVnpNKv eVaG+OTBebyqYirGXdy+Wm9Ewo4nts5LA8qDXTVBiYyB3xTvE64Ierd/dQhuBxY342cz jS4ho0hvcx2G05ZvmIkXEvwqmrsQ2zF23ePJNkVeHtdZPdLGHtIjJ4WFBoNBRCi4LxVi BAwYi/G2yFf7EmUIkNvc4LaB9x5gz0P/VpFe1sVzpPPBE87sWhclPihb/2taHfflpW3y Jx516YawPaMNFjGuwkLKE1Y6DjsqbsDz3xNSFumEFilf9L/4WeU4mALCyea0QLO9fbuh Q5Ug== X-Forwarded-Encrypted: i=1; AJvYcCWNhUZ4C82afgLF4JEM3JN5oCI0/tvmRFIssNuYznmdZRhwnF/EaeKbc9qfLFnQL763TMrrrbP8ow==@kvack.org X-Gm-Message-State: AOJu0Yz6FrsU+/c3GVrXW3Y4mIWHWSEVpvZeK9DUNw9MBPQi2B1E7C8f TPdm7nzug2uXewKdNJgAgjJcn5JOPMLxvkgZb0gO9fYfvFxuTSlcFqpIMPzAkFMt5Lr+guHqKJg I8OmbRGhE8jAYPWS5vPupkEHjAsaWMmUT/elILlewtVQPMsI4 X-Gm-Gg: ASbGncvcwXhRgkFUUl1T67EMhW0cRdIdJ0q4DtEwA5qlvtl1C254tN+l1q+FyqyZSYm Tzh134aIItctwqRQ0/kUhHW8TzhrH536zTPyTrtmCNYD9RAqlbmV5qv/lmNBcqNIYLpTWf5Hop0 l4gDp4dEBiaRgrWOiBvSTsl85UHZYZpSWMsL4RneYGF7dOwpnluTBz9Xvw9pqIRnq7rO0417ktU URENy4KhXJyeZe/g/LNxXMptZJgAUwM/to9xUcvE+FjK1XSLVhrr09mbisSh5YrYF7viDiGVNdw EhPwDZmy2SMxW50TQqoLe46p9TPHSuJmMXIDzHpxWgpuyEqKVZOm4x4xqMUvMmsQ3g3N1fQ56ZE aS7Vj4OHeGdD6ulVEI0mkhA== X-Received: by 2002:a05:600c:b8c:b0:435:330d:de86 with SMTP id 5b1f17b1804b1-438912d2c48mr112151325e9.0.1737359110732; Sun, 19 Jan 2025 23:45:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGMAfAkjyq6M0tHuZOndmrAYDvTyGnP5uOZqrRz4DRX0zAGhk5zAEd3DrsGYoH450s+6I6nAg== X-Received: by 2002:a05:600c:b8c:b0:435:330d:de86 with SMTP id 5b1f17b1804b1-438912d2c48mr112150665e9.0.1737359110362; Sun, 19 Jan 2025 23:45:10 -0800 (PST) Received: from ?IPV6:2003:d8:2f22:1000:d72d:fd5f:4118:c70b? (p200300d82f221000d72dfd5f4118c70b.dip0.t-ipconnect.de. [2003:d8:2f22:1000:d72d:fd5f:4118:c70b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c74ac712sm186030105e9.12.2025.01.19.23.45.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Jan 2025 23:45:09 -0800 (PST) Message-ID: <52a45aa6-1554-4cb8-b8df-da601c4e18ca@redhat.com> Date: Mon, 20 Jan 2025 08:45:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/mmap: allow MAP_DROPPABLE | MAP_PRIVATE in mmap() To: Lance Yang , akpm@linux-foundation.org Cc: 21cnbao@gmail.com, ryan.roberts@arm.com, dev.jain@arm.com, shy828301@gmail.com, ziy@nvidia.com, libang.li@antgroup.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, Jason@zx2c4.com, Mingzhe Yang References: <20250120012607.4808-1-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250120012607.4808-1-ioworker0@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: i5rWDIqjGeEhxFsj07V606qTCYU5OXMxiAekF8YPjjQ_1737359111 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 73BE3140017 X-Stat-Signature: ank5g7auw94s483c4t15d5urtbsj6ieb X-HE-Tag: 1737359114-996778 X-HE-Meta: U2FsdGVkX19I6vuF/ICRxCscwH9MHEejI6sfYyUhXXrLwxT0nFAtCnqhjwFBv3gII7WhgsCmfoWaMzmcdTazEmg1iNZ2VPZJIWeNWp3NgTTazjOVUIOCtXCE7KfhZalhxfS0gTA7O9w46YeDxTLyk6rS7vohc4sk58OgNbuuq301g8szMvUAKXxBcNwATXcuzEqOqwuZzHfqBvAeSygb4frQ8aGw1NP+uFNSgryUeAWjYg8hjxE6qlKsMfEwGt2mSOxMBnL2G5KFDMjlUqGOtsEFqQOwu7gT2zum11MgJdwDSDAo8SZFsCcuhp9lc+L9UPKS6pJ658JJE72/572CfwtlE4nckyOu9MglFx+EyU6r9m3IOiZ5C6bt9noE6+9DkYiOUyXN8pMgun5JuUhjH+J92cXRHhpsVcrzAnfQtHa3w/1Z3J6QHcEKOziFq3rgRUpFo2UpdW/LFgXpp6y2NjxJND0r+ytzzjXzW+CxdzU6uIPi6uA2eEyOxKeVpYst6SNUPG0mcgbxIicbPlu6VVRPC3JNF/NyuScAiAPaw6tm9kui8IYgHYyZyjQOfDMdvXu9OjcCPYY4SOeUDFvnJ/myU20mUfW9JkRXCSMICxggsJ+vkLYky7OWjvmuEbc+6Jtb/GDtE+e+dn9Yaa9LJaAi21yuSOcv6HJkpFLywOv/1ST99dNjA6WD+HOqdC5iO01w+3I7zL185RjLilonOfcGQa8QOBV9/0S6cCDcqg76t1w/11YrK4JQtjYMs59E2JDYVj+Uf4QrbxFIBvvUYuxKgpBXmnDGep87J3S696j/7wE6IS+DF+c6pKU4DCNf78wjwBFMVtI/r6u+6KoXHupletiXnVzXtSvXza9bIWW/EjQ1cfMnsTd9Zr3HP3MnR1KUChhjVdVXC8UE7njLfGjFxBZveoJnZtzgNwWzL2knNMMntjFC13uDSip8GQ7JYYKc89EhXtFXuvrBlW9 C2RH6OBy jmj+LFdu6dP8l4Hs/LklkHt3nV92F4HHmPwMyeFaXcoPqyggdDflPapOz+NVe/2SOJqHC7jk0wfadcxZZ09JFSJzW+tWh6vucvDPhd/iY8qaJOTD3c9QOJ1oJ+KbgAPF5x1PebGVphEg6ICdDMdpD8KzFXfXGFT/6668u8c95SPN7focS8iXDoBBAeLstsR02Q6CqSq9FklsheXV6fyKfO2iA8tMGebRrTO6XCmDr6gA+b8hll913yV3QdquFm/2DsxwsmY9Ch6IXVsmcDodTzFYGfQbGoa/JdZb3W8cDi0KpBTJdqygj0QaJLURccePJs8i+/qhrhuKHQZVPdotzlnM06aUnYvjQX+0fpgAEqYl8We0zaZkknezwwFenAkXCPZTfSaWfzlDLY8PqxbY9PgU9k4Bs3LNqw6tW+Vl6RY4yH14YmXERmkzuVdaR9+kJWvotu1xjGA8DamMZdqNykeZSITQKE6u4HWHHYzpo2vqL/7iJseKrSsaTRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.01.25 02:26, Lance Yang wrote: > Currently, mmap() fails with `-EINVAL` when both MAP_DROPPABLE and > MAP_PRIVATE are specified. This behavior might be inconsistent, as the > implementation of MAP_DROPPABLE under the hood already includes the > semantics of MAP_PRIVATE. So, IMO, whether MAP_PRIVATE is explicitly > specified or not, it should work as expected. > > For example, when mmap() is called with `MAP_DROPPABLE | MAP_ANONYMOUS`, > it creates a private anonymous mapping. Users can verify this behavior > via `/proc/self/smaps`, where the resulting VMA is marked with the `dp` > (MAP_DROPPABLE) flag, and the `Private_*` fields confirm private memory > semantics. The output for a 2MiB mapping with these flags might look like: Note that "Private_" in the stats has *nothing* to do with MAP_PRIVATE. > > ``` > f433ace00000-f433ad000000 rw-p 00000000 00:00 0 > Size: 2048 kB > KernelPageSize: 4 kB > MMUPageSize: 4 kB > Rss: 2048 kB > Pss: 2048 kB > Pss_Dirty: 2048 kB > Shared_Clean: 0 kB > Shared_Dirty: 0 kB > Private_Clean: 0 kB > Private_Dirty: 2048 kB > Referenced: 2048 kB > Anonymous: 2048 kB > ... > VmFlags: rd wr mr mw me nr wf dd dp > ``` > > This patch changes mmap() to allow the combination of `MAP_DROPPABLE | > MAP_PRIVATE`. For mmap(), at least one of MAP_PRIVATE or MAP_SHARED could > be explicitly specified, regardless of the combination with other `MAP_*` > flags. > > Fixes: 9651fcedf7b9 ("mm: add MAP_DROPPABLE for designating always lazily freeable mappings") "How about we just say that VM_DROPPABLE really is something separate from MAP_PRIVATE or MAP_SHARED.. And then we make the rule be that VM_DROPPABLE is never dumped and always dropped on fork, just to make things simpler." [1] [1] https://lore.kernel.org/linux-mm/CAHk-=wi=XvCZ9r897LjEb4ZarLzLtKN1p+Fyig+F2fmQDF8GSA@mail.gmail.com/ So, nack from my side. -- Cheers, David / dhildenb