linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 5/6] sched/numa: make numamigrate_isolate_page static
Date: Sun, 8 Dec 2013 11:10:56 +0800	[thread overview]
Message-ID: <52a3e34a.0722440a.0571.ffff999dSMTPIN_ADDED_BROKEN@mx.google.com> (raw)
In-Reply-To: <1386364795-hks9q1oj-mutt-n-horiguchi@ah.jp.nec.com>

Hi Naoya,
On Fri, Dec 06, 2013 at 04:19:55PM -0500, Naoya Horiguchi wrote:
>On Fri, Dec 06, 2013 at 05:12:15PM +0800, Wanpeng Li wrote:
>> Make numamigrate_update_ratelimit static.
>
>Please change this function name, too :)

Indeed, the patch description should be "Make numamigrate_isolate_page
static".

Regards,
Wanpeng Li 

>
>Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>
>Thanks,
>Naoya Horiguchi
>
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>> ---
>>  mm/migrate.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/mm/migrate.c b/mm/migrate.c
>> index fdb70f7..7ad81e0 100644
>> --- a/mm/migrate.c
>> +++ b/mm/migrate.c
>> @@ -1616,7 +1616,7 @@ bool numamigrate_update_ratelimit(pg_data_t *pgdat, unsigned long nr_pages)
>>  	return rate_limited;
>>  }
>>  
>> -int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page)
>> +static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page)
>>  {
>>  	int page_lru;
>>  
>> -- 
>> 1.7.7.6
>> 
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org.  For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>> 
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org.  For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-12-08  3:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06  9:12 [PATCH v2 1/6] sched/numa: fix set cpupid on page migration twice Wanpeng Li
2013-12-06  9:12 ` [PATCH v2 2/6] sched/numa: drop idx field of task_numa_env struct Wanpeng Li
2013-12-06  9:12 ` [PATCH v2 3/6] sched/numa: drop sysctl_numa_balancing_settle_count sysctl Wanpeng Li
2013-12-06 16:56   ` Mel Gorman
2013-12-08  3:02   ` Rik van Riel
2013-12-06  9:12 ` [PATCH v2 4/6] sched/numa: use wrapper function task_node to get node which task is on Wanpeng Li
2013-12-06 16:57   ` Mel Gorman
2013-12-06 21:09   ` Naoya Horiguchi
2013-12-08  0:05     ` Wanpeng Li
2013-12-08  3:13   ` Rik van Riel
2013-12-06  9:12 ` [PATCH v2 5/6] sched/numa: make numamigrate_isolate_page static Wanpeng Li
2013-12-06 21:19   ` Naoya Horiguchi
2013-12-08  3:10     ` Wanpeng Li [this message]
2013-12-06  9:12 ` [PATCH v2 6/6] sched/numa: make numamigrate_update_ratelimit static Wanpeng Li
2013-12-08  3:14   ` Rik van Riel
2013-12-06 16:56 ` [PATCH v2 1/6] sched/numa: fix set cpupid on page migration twice Mel Gorman
2013-12-08  0:06   ` Wanpeng Li
2013-12-08  1:11 ` Rik van Riel
2013-12-08  1:19   ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52a3e34a.0722440a.0571.ffff999dSMTPIN_ADDED_BROKEN@mx.google.com \
    --to=liwanp@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox