From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 4/6] sched/numa: use wrapper function task_node to get node which task is on
Date: Sun, 8 Dec 2013 08:05:44 +0800 [thread overview]
Message-ID: <52a3b7e2.65c5440a.2f3e.5e21SMTPIN_ADDED_BROKEN@mx.google.com> (raw)
In-Reply-To: <1386364176-it8qfec-mutt-n-horiguchi@ah.jp.nec.com>
On Fri, Dec 06, 2013 at 04:09:36PM -0500, Naoya Horiguchi wrote:
>On Fri, Dec 06, 2013 at 05:12:14PM +0800, Wanpeng Li wrote:
>> Use wrapper function task_node to get node which task is on.
>>
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>
>Maybe we have another line to apply the same fix:
>
>./kernel/sched/debug.c:142: SEQ_printf(m, " %d", cpu_to_node(task_cpu(p)));
>
Ok, I will fold it to next version. Thanks for your review. ;-)
Regards,
Wanpeng Li
>But anyway,
>
>Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>
>Thanks,
>Naoya Horiguchi
>
>> ---
>> kernel/sched/fair.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index 56bcc0c..e0b1063 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -1216,7 +1216,7 @@ static int task_numa_migrate(struct task_struct *p)
>> * elsewhere, so there is no point in (re)trying.
>> */
>> if (unlikely(!sd)) {
>> - p->numa_preferred_nid = cpu_to_node(task_cpu(p));
>> + p->numa_preferred_nid = task_node(p);
>> return -EINVAL;
>> }
>>
>> @@ -1283,7 +1283,7 @@ static void numa_migrate_preferred(struct task_struct *p)
>> p->numa_migrate_retry = jiffies + HZ;
>>
>> /* Success if task is already running on preferred CPU */
>> - if (cpu_to_node(task_cpu(p)) == p->numa_preferred_nid)
>> + if (task_node(p) == p->numa_preferred_nid)
>> return;
>>
>> /* Otherwise, try migrate to a CPU on the preferred node */
>> --
>> 1.7.7.6
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-12-08 0:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 9:12 [PATCH v2 1/6] sched/numa: fix set cpupid on page migration twice Wanpeng Li
2013-12-06 9:12 ` [PATCH v2 2/6] sched/numa: drop idx field of task_numa_env struct Wanpeng Li
2013-12-06 9:12 ` [PATCH v2 3/6] sched/numa: drop sysctl_numa_balancing_settle_count sysctl Wanpeng Li
2013-12-06 16:56 ` Mel Gorman
2013-12-08 3:02 ` Rik van Riel
2013-12-06 9:12 ` [PATCH v2 4/6] sched/numa: use wrapper function task_node to get node which task is on Wanpeng Li
2013-12-06 16:57 ` Mel Gorman
2013-12-06 21:09 ` Naoya Horiguchi
2013-12-08 0:05 ` Wanpeng Li [this message]
2013-12-08 3:13 ` Rik van Riel
2013-12-06 9:12 ` [PATCH v2 5/6] sched/numa: make numamigrate_isolate_page static Wanpeng Li
2013-12-06 21:19 ` Naoya Horiguchi
2013-12-08 3:10 ` Wanpeng Li
2013-12-06 9:12 ` [PATCH v2 6/6] sched/numa: make numamigrate_update_ratelimit static Wanpeng Li
2013-12-08 3:14 ` Rik van Riel
2013-12-06 16:56 ` [PATCH v2 1/6] sched/numa: fix set cpupid on page migration twice Mel Gorman
2013-12-08 0:06 ` Wanpeng Li
2013-12-08 1:11 ` Rik van Riel
2013-12-08 1:19 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52a3b7e2.65c5440a.2f3e.5e21SMTPIN_ADDED_BROKEN@mx.google.com \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox