From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by kanga.kvack.org (Postfix) with ESMTP id B46616B0031 for ; Fri, 7 Feb 2014 04:14:32 -0500 (EST) Received: by mail-we0-f182.google.com with SMTP id u57so2059018wes.41 for ; Fri, 07 Feb 2014 01:14:32 -0800 (PST) Received: from mx2.suse.de (cantor2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id gg6si652435wib.34.2014.02.07.01.14.30 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 07 Feb 2014 01:14:30 -0800 (PST) Message-ID: <52F4A3F2.1050809@suse.cz> Date: Fri, 07 Feb 2014 10:14:26 +0100 From: Vlastimil Babka MIME-Version: 1.0 Subject: Re: [PATCH 0/5] compaction related commits References: <1391749726-28910-1-git-send-email-iamjoonsoo.kim@lge.com> In-Reply-To: <1391749726-28910-1-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim , Andrew Morton Cc: Mel Gorman , Joonsoo Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org On 02/07/2014 06:08 AM, Joonsoo Kim wrote: > This patchset is related to the compaction. > > patch 1 fixes contrary implementation of the purpose of compaction. > patch 2~4 are for optimization. > patch 5 is just for clean-up. > > I tested this patchset with stress-highalloc benchmark on Mel's mmtest > and cannot find any regression in terms of success rate. And I find > much reduced system time. Below is result of 3 runs. What was the memory size? Mel told me this test shouldn't be run with more than 4GB. > * Before > time :: stress-highalloc 3276.26 user 740.52 system 1664.79 elapsed > time :: stress-highalloc 3640.71 user 771.32 system 1633.83 elapsed > time :: stress-highalloc 3691.64 user 775.44 system 1638.05 elapsed > > avg system: 1645 s > > * After > time :: stress-highalloc 3225.51 user 732.40 system 1542.76 elapsed > time :: stress-highalloc 3524.31 user 749.63 system 1512.88 elapsed > time :: stress-highalloc 3610.55 user 757.20 system 1505.70 elapsed > > avg system: 1519 s > > That is 7% reduced system time. Why not post the whole compare-mmtests output? There are more metrics in there and extra eyes never hurt. Vlastimil > Thanks. > > Joonsoo Kim (5): > mm/compaction: disallow high-order page for migration target > mm/compaction: do not call suitable_migration_target() on every page > mm/compaction: change the timing to check to drop the spinlock > mm/compaction: check pageblock suitability once per pageblock > mm/compaction: clean-up code on success of ballon isolation > > mm/compaction.c | 75 +++++++++++++++++++++++++++++-------------------------- > 1 file changed, 39 insertions(+), 36 deletions(-) > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org