From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qe0-f43.google.com (mail-qe0-f43.google.com [209.85.128.43]) by kanga.kvack.org (Postfix) with ESMTP id AE6D76B0036 for ; Tue, 14 Jan 2014 06:05:31 -0500 (EST) Received: by mail-qe0-f43.google.com with SMTP id nc12so1447433qeb.30 for ; Tue, 14 Jan 2014 03:05:31 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTP id t8si235329qeu.56.2014.01.14.03.05.30 for ; Tue, 14 Jan 2014 03:05:31 -0800 (PST) Message-ID: <52D519EB.3040709@redhat.com> Date: Tue, 14 Jan 2014 06:05:15 -0500 From: Prarit Bhargava MIME-Version: 1.0 Subject: Re: [PATCH] x86, acpi memory hotplug, add parameter to disable memory hotplug References: <1389650161-13292-1-git-send-email-prarit@redhat.com> <52D47999.5080905@redhat.com> <52D48EC4.5070400@jp.fujitsu.com> <1389663689.1792.268.camel@misato.fc.hp.com> In-Reply-To: <1389663689.1792.268.camel@misato.fc.hp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Toshi Kani Cc: Yasuaki Ishimatsu , KOSAKI Motohiro , LKML , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , Len Brown , "Rafael J. Wysocki" , Linn Crosetto , Pekka Enberg , Yinghai Lu , Andrew Morton , Tang Chen , Wen Congyang , Vivek Goyal , Dave Young , linux-acpi@vger.kernel.org, "linux-mm@kvack.org" On 01/13/2014 08:41 PM, Toshi Kani wrote: > On Tue, 2014-01-14 at 10:11 +0900, Yasuaki Ishimatsu wrote: > : >>>> I think we need a knob manually enable mem-hotplug when specify memmap. But >>>> it is another story. >>>> >>>> Acked-by: KOSAKI Motohiro >>> >>> As mentioned, self-NAK. I have seen a system that I needed to specify >>> memmap=exactmap & had hotplug memory. I will only keep the acpi_no_memhotplug >>> option in the next version of the patch. >> >> >> Your following first patch is simply and makes sense. >> >> http://marc.info/?l=linux-acpi&m=138922019607796&w=2 >> > > In this option, it also requires changing kexec-tools to specify the new > option for kdump. It won't be simpler. It will be simpler for the kernel and those of us who have to debug busted e820 maps ;) Unfortunately I may not be able to give you the automatic disable. I did contemplate adding a !is_kdump_kernel() to the ACPI memory hotplug init call, but it seems like that is unacceptable as well. P. > > Thanks, > -Toshi > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org