From: Izik Eidus <izik.eidus@ravellosystems.com>
To: linux-mm@kvack.org, kvm@vger.kernel.org, aarcange@redhat.com,
Alex Fishman <alex.fishman@ravellosystems.com>,
Mike Rapoport <mike.rapoport@ravellosystems.com>
Subject: set_pte_at_notify regression
Date: Fri, 10 Jan 2014 18:38:06 +0200 [thread overview]
Message-ID: <52D021EE.3020104@ravellosystems.com> (raw)
Hi,
It look like commit 6bdb913f0a70a4dfb7f066fb15e2d6f960701d00 break the
semantic of set_pte_at_notify.
The change of calling first to mmu_notifier_invalidate_range_start, then
to set_pte_at_notify, and then to mmu_notifier_invalidate_range_end
not only increase the amount of locks kvm have to take and release by
factor of 3, but in addition mmu_notifier_invalidate_range_start is zapping
the pte entry from kvm, so when set_pte_at_notify get called, it doesn`t
have any spte to set and it acctuly get called for nothing, the result is
increasing of vmexits for kvm from both do_wp_page and replace_page, and
broken semantic of set_pte_at_notify.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2014-01-10 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 16:38 Izik Eidus [this message]
2014-01-10 16:57 ` Andrea Arcangeli
2014-01-12 11:56 ` Haggai Eran
2014-01-12 17:50 ` Andrea Arcangeli
2014-01-16 7:52 ` Haggai Eran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D021EE.3020104@ravellosystems.com \
--to=izik.eidus@ravellosystems.com \
--cc=aarcange@redhat.com \
--cc=alex.fishman@ravellosystems.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.rapoport@ravellosystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox