From: Dave Hansen <dave@sr71.net>
To: Christoph Lameter <cl@linux.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kirill.shutemov@linux.intel.com, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] [RFC] mm: slab: separate slab_page from 'struct page'
Date: Thu, 12 Dec 2013 11:28:29 -0800 [thread overview]
Message-ID: <52AA0E5D.30903@sr71.net> (raw)
In-Reply-To: <00000142e7e23135-20f346b1-a880-47b0-946c-122323669ec1-000000@email.amazonses.com>
On 12/12/2013 09:37 AM, Christoph Lameter wrote:
> On Tue, 10 Dec 2013, Dave Hansen wrote:
>> See? *EVERYTHING* is overridden by at least one of the sl?b allocators
>> except ->flags. In other words, there *ARE* no relationships when it
>> comes to the sl?bs, except for page->flags.
>
> Slab objects can be used for I/O and then the page fields become
> important.
OK, which fields? How are they important? Looking at 'struct page', I
don't see any fields other than ->flags that the slab allocators leave
alone.
I do see some refcounting (page->_count) done on
request_queue->dma_drain_buffer which is kmalloc()'d. Although, I'm a
bit skeptical that this is correct or has been audited because the slabs
do seem to write over this storage. Anything needing to do per-page
could probably be converted over to a raw alloc_pages() anyway because
it couldn't possibly be doing sub-page-size allocations.
What other cases were you thinking of?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-12-13 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 20:46 Dave Hansen
2013-12-10 21:07 ` Christoph Lameter
2013-12-10 21:44 ` Dave Hansen
2013-12-10 22:00 ` Christoph Lameter
2013-12-10 22:21 ` Dave Hansen
2013-12-12 17:37 ` Christoph Lameter
2013-12-12 19:28 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AA0E5D.30903@sr71.net \
--to=dave@sr71.net \
--cc=ak@linux.intel.com \
--cc=cl@linux.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox