From: Xishi Qiu <qiuxishi@huawei.com>
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, linn@hp.com, penberg@kernel.org,
yinghai@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Cc: Xishi Qiu <qiuxishi@huawei.com>
Subject: [PATCH] mm,x86: fix span coverage in e820_all_mapped()
Date: Tue, 10 Dec 2013 17:06:56 +0800 [thread overview]
Message-ID: <52A6D9B0.7040506@huawei.com> (raw)
In the following case, e820_all_mapped() will return 1.
A < start < B-1 and B < end < C, it means <start, end> spans two regions.
<start, end>: [start - end]
e820 addr: ...[A - B-1][B - C]...
Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
---
arch/x86/kernel/e820.c | 15 +++------------
1 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index 174da5f..31ecab2 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -85,20 +85,11 @@ int __init e820_all_mapped(u64 start, u64 end, unsigned type)
if (type && ei->type != type)
continue;
- /* is the region (part) in overlap with the current region ?*/
+ /* is the region (part) in overlap with the current region ? */
if (ei->addr >= end || ei->addr + ei->size <= start)
continue;
-
- /* if the region is at the beginning of <start,end> we move
- * start to the end of the region since it's ok until there
- */
- if (ei->addr <= start)
- start = ei->addr + ei->size;
- /*
- * if start is now at or beyond end, we're done, full
- * coverage
- */
- if (start >= end)
+ /* is the region full coverage of <start, end> ? */
+ if (ei->addr <= start && ei->addr + ei->size >= end)
return 1;
}
return 0;
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2013-12-10 9:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 9:06 Xishi Qiu [this message]
2013-12-10 21:06 ` Yinghai Lu
2013-12-10 21:29 ` H. Peter Anvin
2013-12-10 21:52 ` Yinghai Lu
2013-12-10 22:51 ` H. Peter Anvin
2013-12-11 0:35 ` Yinghai Lu
2013-12-11 1:06 ` H. Peter Anvin
2013-12-11 1:42 ` Xishi Qiu
2013-12-11 1:35 ` Xishi Qiu
2013-12-11 2:55 ` H. Peter Anvin
2013-12-11 3:55 ` Xishi Qiu
2013-12-11 4:02 ` H. Peter Anvin
2013-12-11 4:39 ` Xishi Qiu
2013-12-11 5:27 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A6D9B0.7040506@huawei.com \
--to=qiuxishi@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=penberg@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox