* [PATCH] mm: add show num_poisoned_pages when oom
@ 2013-12-09 9:52 Xishi Qiu
2013-12-09 15:50 ` Michal Hocko
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Xishi Qiu @ 2013-12-09 9:52 UTC (permalink / raw)
To: Andrew Morton, KOSAKI Motohiro, Michal Hocko, Mel Gorman, rientjes
Cc: LKML, linux-mm, Xishi Qiu
Show num_poisoned_pages when oom, it is helpful to find the reason.
Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
---
lib/show_mem.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/lib/show_mem.c b/lib/show_mem.c
index 5847a49..1cbdcd8 100644
--- a/lib/show_mem.c
+++ b/lib/show_mem.c
@@ -46,4 +46,7 @@ void show_mem(unsigned int filter)
printk("%lu pages in pagetable cache\n",
quicklist_total_size());
#endif
+#ifdef CONFIG_MEMORY_FAILURE
+ printk("%lu pages poisoned\n", atomic_long_read(&num_poisoned_pages));
+#endif
}
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mm: add show num_poisoned_pages when oom
2013-12-09 9:52 [PATCH] mm: add show num_poisoned_pages when oom Xishi Qiu
@ 2013-12-09 15:50 ` Michal Hocko
2013-12-09 19:50 ` David Rientjes
2013-12-09 21:49 ` Naoya Horiguchi
2 siblings, 0 replies; 5+ messages in thread
From: Michal Hocko @ 2013-12-09 15:50 UTC (permalink / raw)
To: Xishi Qiu
Cc: Andrew Morton, KOSAKI Motohiro, Mel Gorman, rientjes, LKML, linux-mm
On Mon 09-12-13 17:52:30, Xishi Qiu wrote:
> Show num_poisoned_pages when oom, it is helpful to find the reason.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
I would not expect the number of these pages would be too high to matter in
real life but having the information cannot be harmful in any way.
Acked-by: Michal Hocko <mhocko@suse.cz>
> ---
> lib/show_mem.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/lib/show_mem.c b/lib/show_mem.c
> index 5847a49..1cbdcd8 100644
> --- a/lib/show_mem.c
> +++ b/lib/show_mem.c
> @@ -46,4 +46,7 @@ void show_mem(unsigned int filter)
> printk("%lu pages in pagetable cache\n",
> quicklist_total_size());
> #endif
> +#ifdef CONFIG_MEMORY_FAILURE
> + printk("%lu pages poisoned\n", atomic_long_read(&num_poisoned_pages));
> +#endif
> }
> --
> 1.7.1
>
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mm: add show num_poisoned_pages when oom
2013-12-09 9:52 [PATCH] mm: add show num_poisoned_pages when oom Xishi Qiu
2013-12-09 15:50 ` Michal Hocko
@ 2013-12-09 19:50 ` David Rientjes
2013-12-09 21:49 ` Naoya Horiguchi
2 siblings, 0 replies; 5+ messages in thread
From: David Rientjes @ 2013-12-09 19:50 UTC (permalink / raw)
To: Xishi Qiu
Cc: Andrew Morton, KOSAKI Motohiro, Michal Hocko, Mel Gorman, LKML, linux-mm
On Mon, 9 Dec 2013, Xishi Qiu wrote:
> Show num_poisoned_pages when oom, it is helpful to find the reason.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
Acked-by: David Rientjes <rientjes@google.com>
Although this patch says it's for oom conditions, it will be emitted
anytime show_mem() is called which sounds good as well.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: add show num_poisoned_pages when oom
2013-12-09 9:52 [PATCH] mm: add show num_poisoned_pages when oom Xishi Qiu
2013-12-09 15:50 ` Michal Hocko
2013-12-09 19:50 ` David Rientjes
@ 2013-12-09 21:49 ` Naoya Horiguchi
2013-12-09 22:05 ` David Rientjes
2 siblings, 1 reply; 5+ messages in thread
From: Naoya Horiguchi @ 2013-12-09 21:49 UTC (permalink / raw)
To: Xishi Qiu
Cc: Andrew Morton, KOSAKI Motohiro, Michal Hocko, Mel Gorman,
rientjes, LKML, linux-mm
On Mon, Dec 09, 2013 at 05:52:30PM +0800, Xishi Qiu wrote:
> Show num_poisoned_pages when oom, it is helpful to find the reason.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> ---
> lib/show_mem.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/lib/show_mem.c b/lib/show_mem.c
> index 5847a49..1cbdcd8 100644
> --- a/lib/show_mem.c
> +++ b/lib/show_mem.c
> @@ -46,4 +46,7 @@ void show_mem(unsigned int filter)
> printk("%lu pages in pagetable cache\n",
> quicklist_total_size());
> #endif
> +#ifdef CONFIG_MEMORY_FAILURE
> + printk("%lu pages poisoned\n", atomic_long_read(&num_poisoned_pages));
> +#endif
> }
I think that just "poisoned" could be confusing because this word seems to
be used also in other context (like slab and list_debug handling.)
"hwpoisoned" or "hardware corrupted" (which is the same label in /proc/meminfo)
looks better to me.
Thanks,
Naoya Horiguchi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mm: add show num_poisoned_pages when oom
2013-12-09 21:49 ` Naoya Horiguchi
@ 2013-12-09 22:05 ` David Rientjes
0 siblings, 0 replies; 5+ messages in thread
From: David Rientjes @ 2013-12-09 22:05 UTC (permalink / raw)
To: Naoya Horiguchi
Cc: Xishi Qiu, Andrew Morton, KOSAKI Motohiro, Michal Hocko,
Mel Gorman, LKML, linux-mm
On Mon, 9 Dec 2013, Naoya Horiguchi wrote:
> > Show num_poisoned_pages when oom, it is helpful to find the reason.
> >
> > Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> > ---
> > lib/show_mem.c | 3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/lib/show_mem.c b/lib/show_mem.c
> > index 5847a49..1cbdcd8 100644
> > --- a/lib/show_mem.c
> > +++ b/lib/show_mem.c
> > @@ -46,4 +46,7 @@ void show_mem(unsigned int filter)
> > printk("%lu pages in pagetable cache\n",
> > quicklist_total_size());
> > #endif
> > +#ifdef CONFIG_MEMORY_FAILURE
> > + printk("%lu pages poisoned\n", atomic_long_read(&num_poisoned_pages));
> > +#endif
> > }
>
> I think that just "poisoned" could be confusing because this word seems to
> be used also in other context (like slab and list_debug handling.)
> "hwpoisoned" or "hardware corrupted" (which is the same label in /proc/meminfo)
> looks better to me.
>
Ah, good point.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-12-09 22:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-09 9:52 [PATCH] mm: add show num_poisoned_pages when oom Xishi Qiu
2013-12-09 15:50 ` Michal Hocko
2013-12-09 19:50 ` David Rientjes
2013-12-09 21:49 ` Naoya Horiguchi
2013-12-09 22:05 ` David Rientjes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox