From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-la0-f51.google.com (mail-la0-f51.google.com [209.85.215.51]) by kanga.kvack.org (Postfix) with ESMTP id 36B4D6B0031 for ; Tue, 3 Dec 2013 08:48:58 -0500 (EST) Received: by mail-la0-f51.google.com with SMTP id ec20so9178228lab.10 for ; Tue, 03 Dec 2013 05:48:57 -0800 (PST) Received: from relay.parallels.com (relay.parallels.com. [195.214.232.42]) by mx.google.com with ESMTPS id bj6si3020796lbc.17.2013.12.03.05.48.56 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 03 Dec 2013 05:48:56 -0800 (PST) Message-ID: <529DE144.8020005@parallels.com> Date: Tue, 3 Dec 2013 17:48:52 +0400 From: Vladimir Davydov MIME-Version: 1.0 Subject: Re: [PATCH v12 05/18] fs: do not use destroy_super() in alloc_super() fail path References: <20131203090041.GB8803@dastard> <529DA2F5.1040602@parallels.com> <20131203133755.GJ10323@ZenIV.linux.org.uk> In-Reply-To: <20131203133755.GJ10323@ZenIV.linux.org.uk> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Al Viro Cc: Dave Chinner , hannes@cmpxchg.org, mhocko@suse.cz, dchinner@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, devel@openvz.org, glommer@openvz.org On 12/03/2013 05:37 PM, Al Viro wrote: > On Tue, Dec 03, 2013 at 01:23:01PM +0400, Vladimir Davydov wrote: > >> Actually, I'm not going to modify the list_lru structure, because I >> think it's good as it is. I'd like to substitute it with a new >> structure, memcg_list_lru, only in those places where this functionality >> (per-memcg scanning) is really needed. This new structure would look >> like this: >> >> struct memcg_list_lru { >> struct list_lru global_lru; >> struct list_lru **memcg_lrus; >> struct list_head list; >> void *old_lrus; >> } >> >> Since old_lrus and memcg_lrus can be NULL under normal operation, in >> memcg_list_lru_destroy() I'd have to check either the list or the >> global_lru field, i.e. it would look like: >> >> if (!list.next) >> /* has not been initialized */ >> return; >> >> or > ... or just use hlist_head. list_head serves as a list node here (those structures are organized in a linked list) and I have to remove it from the list upon destruction so hlist_head is not relevant here. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org