From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57A35EB64DD for ; Tue, 25 Jul 2023 04:41:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0C056B00AA; Tue, 25 Jul 2023 00:41:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BCCA6B00AB; Tue, 25 Jul 2023 00:41:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85C846B00AC; Tue, 25 Jul 2023 00:41:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 731B86B00AA for ; Tue, 25 Jul 2023 00:41:50 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2E582140761 for ; Tue, 25 Jul 2023 04:41:49 +0000 (UTC) X-FDA: 81048886338.29.3048DBB Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf12.hostedemail.com (Postfix) with ESMTP id 4348040012 for ; Tue, 25 Jul 2023 04:41:47 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=syg9IyMH; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of hughd@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690260107; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4tFc7lI8l/TAp6N4SH/RnjHMrhDjcjpOS0NvhRjK3tI=; b=VA/ELAKnxQkVDNi23xgmiDgA6TSRd37xiv6zOsN/Jvt+96CXLjTt1FGr3Tf9fbMdhd2pNg Qz/Eyx4LR3s4UGGq2MAu5bKAzx3Hkj41gPkkXJjzS4/f/LBRhY0QpfCCDndz/xYLhl2Fnh BFy3ieuqHZU2QkibeiXw6CcAgJ6rXPM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=syg9IyMH; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of hughd@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690260107; a=rsa-sha256; cv=none; b=WUUKTb2o+bErUhRRwbUT1JqQ+KAUEZEKSzjJQCpHDFYOyBeiXtgYW/HKuf6zQ6uaM4DLk8 od0hRckEYhIEIhluRDptuKs+F3E1XOcDbUdiaRnfy61FoSUC0rGdyFn3z0D+/xceqWCYYs 5RJhxWgmt+IHUXq3nCncY1ZtjA2kY3o= Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-d18566dc0c1so263839276.0 for ; Mon, 24 Jul 2023 21:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690260106; x=1690864906; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=4tFc7lI8l/TAp6N4SH/RnjHMrhDjcjpOS0NvhRjK3tI=; b=syg9IyMH/gqJY1k4LT3S6JMx0fSLcgE37Cs+8KWCUO35fKCYg0MuLIIi0nsu37jtyV JWnNbNndjflxoqEknhV3drMoPO1rLP5Mf2NwuEGG3uNqc6WCc3lC70F16ZnEeLC+MDXA tlBtkvCExRePxNsWSrYSlIqtWo9fJaFXM7OzUrScUdzQ6XIpjZwJMknKg/XaSKKfA+Pp NHjPm93xL9xpQDR+q+3gjlysNDu5FD2n2xMli6SN590GUy6WkS3ghg4fMC/PcVORHv0z 7pZwaHoSCWcs0DC0U/7aDMkjw3lDyZjRkGaSMnnCoKZ6Eh2nJ1AJW7AcIEll2MImoPAy 2Dhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690260106; x=1690864906; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4tFc7lI8l/TAp6N4SH/RnjHMrhDjcjpOS0NvhRjK3tI=; b=V9Os2qTobMvbp+iflUNNRBBtAwKBNa0T2dI8JqlSF/LmaApbAoVRj6HUcQmNJpzrsP q/nlal393k63KxsaolEIxHbQdJbmowBBeWYD5J+6qWyE3pga28ho/zCczoPN1TgxkIKF G+1fkBNZtNWX2AIg+P3ROqHO2bvRGW/MTjzIl1xd0BmygfDG4XSTgE0XluMmrGyUBBVJ VyatXvX20dloC4slS5hKk+tQQtQ3ybZ4ZNsgz217pgNWuzTWR4aaHLIXS9XS9AecTDMn tZ78Wf8bnl+CrKilX+ust7IdWNwJ+f+X5KPKG3Ufx9jGiuk/F8jzF+R2IZGYBUjcYi6E S7EQ== X-Gm-Message-State: ABy/qLYE2+q4d9Vp65kTTyNefbU32ILCdd1amCKGpoMziaYbJZdPbl1A ahinNE+V8fUug7itVnvIs/sKaQ== X-Google-Smtp-Source: APBJJlHQLTh3cgEYO+DVAD/fw8XSxxaq77z0mK7JibK/JjnN3wjA/kyDdlXYpJW7FLCpf9E01rW5SQ== X-Received: by 2002:a25:2342:0:b0:d0d:2d17:3f11 with SMTP id j63-20020a252342000000b00d0d2d173f11mr5304231ybj.17.1690260106082; Mon, 24 Jul 2023 21:41:46 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id z16-20020a25e310000000b00c71e4833957sm2656725ybd.63.2023.07.24.21.41.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jul 2023 21:41:45 -0700 (PDT) Date: Mon, 24 Jul 2023 21:41:36 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: "Vishal Moola (Oracle)" cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , Catalin Marinas , Huacai Chen , Geert Uytterhoeven , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , David Hildenbrand , Claudio Imbrenda , Paul Walmsley , "David S. Miller" , Richard Weinberger , Yoshinori Sato , Dave Hansen , Arnd Bergmann , Christophe Leroy Subject: Re: [PATCH mm-unstable v7 00/31] Split ptdesc from struct page In-Reply-To: <20230725042051.36691-1-vishal.moola@gmail.com> Message-ID: <5296514f-cdd1-9526-2e83-a21e76e86e5@google.com> References: <20230725042051.36691-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4348040012 X-Stat-Signature: gxh6jxqgnd6pnf15p97py9e61kbdwhke X-Rspam-User: X-HE-Tag: 1690260107-411096 X-HE-Meta: U2FsdGVkX1/pL/kCXP8XK3RcBpOk+rvP9hvhJMzGNNbIWYmtWUlmbJuWkNxoybzjXEWjtxyiMECYne0osbUf8GaS4Y6KOQns3cP61cY/4Bd8rpBe4Dsru9q/xW2VQ5oq1cqkCqRvhgrHeqen/okeqYcPtNStU7l7uveKo0xaWiInFt91gaq8HCOOMQALFBx6UYG3BHJUDkwxxW+VoWPtta2RZTs+amKGMF9DHHy5zW90YGS4mlV7ttrQ/075I45LdFw2OeH/BqIg+AoKIds69uwxrV7IhPs6CYJxLmKOdSvkgY9BjBF45uUZffVUxX9qoHP31zSrluVVpA7WxYmXLj/iDTw4YTPh87MBHp0SeYx4yTug42OFGcbUeQSqZoEFxqZRZ8K3kYK4uRNC5q1//wDn1hlDih8tm/wgrYnn4Zs3oHzXP1LMx6PYhysiXqARQpCFJYNvQ0X9vZ/iGJFmlqGSj0ikrlI4vFWs2rimcLMvpcha8gZBVwGokFNznd3vPxt5RbMp8j+WssDJp+8mJUdLJ3WtWk21ZkqP2lXVNihifMGV+c0KAiQQmyd95pyxhUIvQPhJrbX44s1rDpXgv6JBtbdrNXzdj6Hl0fX3SExBKP0TDPt2K4j/yaUSnsnIyscIuYVzmQ9/HQQ1q3rUCHl9e7D+OnpVgdKTmmdwQCsYYj4+30mgojwGuon4ewruOfbDw5cl5J5K5/50cCMR+eSCjCfR41RqykGRN5BbaXneiaDRuySR4wJPHmuWEvZDUR549z+yhAUQxaYXKA5RDImDfTrBz3CrItYGrNdl43S0gGcFIzMAk5glqt3BGt9P2T7RpT+I0+ucP+CSHjDXVyxgqcIbxgGntRktkazZbLSV4SN02lCz6U+YFcFYL/rVp433P12L1IISY/t26auwFyvnW3lG3rQTEHwvgaUhDdFj0qDJIdDXRVzlELi9OmyhFn0pFydZ/MB5Bf7muNB euSzR3Ha CQIcVO0cz75HtSh+GweVzIYtI6MSko/1hkreJ9aUvwpKYeIaIbNiyuAqyhGA54pIcEvapQJAuOZNQpc6Fyz8W2d+bioPCooHZPSplcJmmrAkBFSArcVP7TnDS8Dije1U23qdVfLWDZ0Cz0dVA0N8L4/JkP7bPACzDsV182BIQCvUAWCbVtgut2HHOgDWqHi/l3FfKJ44+PiWjsSl/iOmQux+DNDEx7PPSzOuSGnWRDns2TrK2malAGczAxy02ZtujZPgdHFfRMM+frbbeZMVOF0TyQ4UtM2tkRjUtK3C2mSDcbWIY+DwvZqK+NziMcyqmR+g6dgRV3LEy8kdGrtRaGd2XsmKjXnKLBUqgKgGyzkfmTTIAtJvxxVu9kptIGxrJ2u8ZhYseGFdRtnuNdreH4j0xMKQudFK5eoCgSMN4jLyilzZOoveRFwmcFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 24 Jul 2023, Vishal Moola (Oracle) wrote: > The MM subsystem is trying to shrink struct page. This patchset > introduces a memory descriptor for page table tracking - struct ptdesc. > > This patchset introduces ptdesc, splits ptdesc from struct page, and > converts many callers of page table constructor/destructors to use ptdescs. > > Ptdesc is a foundation to further standardize page tables, and eventually > allow for dynamic allocation of page tables independent of struct page. > However, the use of pages for page table tracking is quite deeply > ingrained and varied across archictectures, so there is still a lot of > work to be done before that can happen. Others may differ, but it remains the case that I see no point to this patchset, until the minimal descriptor that replaces struct page is working, and struct page then becomes just overhead. Until that time, let architectures continue to use struct page as they do - whyever not? Hugh > > This is rebased on mm-unstable. > > v7: > Drop s390 gmap ptdesc conversions - gmap is unecessary complication > that can be dealt with later > Be more thorough with ptdesc struct sanity checks and comments > Rebase onto mm-unstable > > Vishal Moola (Oracle) (31): > mm: Add PAGE_TYPE_OP folio functions > pgtable: Create struct ptdesc > mm: add utility functions for ptdesc > mm: Convert pmd_pgtable_page() callers to use pmd_ptdesc() > mm: Convert ptlock_alloc() to use ptdescs > mm: Convert ptlock_ptr() to use ptdescs > mm: Convert pmd_ptlock_init() to use ptdescs > mm: Convert ptlock_init() to use ptdescs > mm: Convert pmd_ptlock_free() to use ptdescs > mm: Convert ptlock_free() to use ptdescs > mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor} > powerpc: Convert various functions to use ptdescs > x86: Convert various functions to use ptdescs > s390: Convert various pgalloc functions to use ptdescs > mm: Remove page table members from struct page > pgalloc: Convert various functions to use ptdescs > arm: Convert various functions to use ptdescs > arm64: Convert various functions to use ptdescs > csky: Convert __pte_free_tlb() to use ptdescs > hexagon: Convert __pte_free_tlb() to use ptdescs > loongarch: Convert various functions to use ptdescs > m68k: Convert various functions to use ptdescs > mips: Convert various functions to use ptdescs > nios2: Convert __pte_free_tlb() to use ptdescs > openrisc: Convert __pte_free_tlb() to use ptdescs > riscv: Convert alloc_{pmd, pte}_late() to use ptdescs > sh: Convert pte_free_tlb() to use ptdescs > sparc64: Convert various functions to use ptdescs > sparc: Convert pgtable_pte_page_{ctor, dtor}() to ptdesc equivalents > um: Convert {pmd, pte}_free_tlb() to use ptdescs > mm: Remove pgtable_{pmd, pte}_page_{ctor, dtor}() wrappers > > Documentation/mm/split_page_table_lock.rst | 12 +- > .../zh_CN/mm/split_page_table_lock.rst | 14 +- > arch/arm/include/asm/tlb.h | 12 +- > arch/arm/mm/mmu.c | 7 +- > arch/arm64/include/asm/tlb.h | 14 +- > arch/arm64/mm/mmu.c | 7 +- > arch/csky/include/asm/pgalloc.h | 4 +- > arch/hexagon/include/asm/pgalloc.h | 8 +- > arch/loongarch/include/asm/pgalloc.h | 27 ++-- > arch/loongarch/mm/pgtable.c | 7 +- > arch/m68k/include/asm/mcf_pgalloc.h | 47 +++--- > arch/m68k/include/asm/sun3_pgalloc.h | 8 +- > arch/m68k/mm/motorola.c | 4 +- > arch/mips/include/asm/pgalloc.h | 32 ++-- > arch/mips/mm/pgtable.c | 8 +- > arch/nios2/include/asm/pgalloc.h | 8 +- > arch/openrisc/include/asm/pgalloc.h | 8 +- > arch/powerpc/mm/book3s64/mmu_context.c | 10 +- > arch/powerpc/mm/book3s64/pgtable.c | 32 ++-- > arch/powerpc/mm/pgtable-frag.c | 56 +++---- > arch/riscv/include/asm/pgalloc.h | 8 +- > arch/riscv/mm/init.c | 16 +- > arch/s390/include/asm/pgalloc.h | 4 +- > arch/s390/include/asm/tlb.h | 4 +- > arch/s390/mm/pgalloc.c | 128 +++++++-------- > arch/sh/include/asm/pgalloc.h | 9 +- > arch/sparc/mm/init_64.c | 17 +- > arch/sparc/mm/srmmu.c | 5 +- > arch/um/include/asm/pgalloc.h | 18 +-- > arch/x86/mm/pgtable.c | 47 +++--- > arch/x86/xen/mmu_pv.c | 2 +- > include/asm-generic/pgalloc.h | 88 +++++----- > include/asm-generic/tlb.h | 11 ++ > include/linux/mm.h | 151 +++++++++++++----- > include/linux/mm_types.h | 18 --- > include/linux/page-flags.h | 30 +++- > include/linux/pgtable.h | 80 ++++++++++ > mm/memory.c | 8 +- > 38 files changed, 585 insertions(+), 384 deletions(-) > > -- > 2.40.1