From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qa0-f50.google.com (mail-qa0-f50.google.com [209.85.216.50]) by kanga.kvack.org (Postfix) with ESMTP id B8AE66B0073 for ; Tue, 26 Nov 2013 08:16:16 -0500 (EST) Received: by mail-qa0-f50.google.com with SMTP id i13so8023564qae.16 for ; Tue, 26 Nov 2013 05:16:16 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTP id r10si11106301qai.133.2013.11.26.05.16.15 for ; Tue, 26 Nov 2013 05:16:15 -0800 (PST) Message-ID: <52949F1C.2060607@redhat.com> Date: Tue, 26 Nov 2013 08:16:12 -0500 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 2/5] mm: compaction: reset cached scanner pfn's before reading them References: <1385389570-11393-1-git-send-email-vbabka@suse.cz> <1385389570-11393-3-git-send-email-vbabka@suse.cz> In-Reply-To: <1385389570-11393-3-git-send-email-vbabka@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mel Gorman On 11/25/2013 09:26 AM, Vlastimil Babka wrote: > Compaction caches pfn's for its migrate and free scanners to avoid scanning > the whole zone each time. In compact_zone(), the cached values are read to > set up initial values for the scanners. There are several situations when > these cached pfn's are reset to the first and last pfn of the zone, > respectively. One of these situations is when a compaction has been deferred > for a zone and is now being restarted during a direct compaction, which is also > done in compact_zone(). > > However, compact_zone() currently reads the cached pfn's *before* resetting > them. This means the reset doesn't affect the compaction that performs it, and > with good chance also subsequent compactions, as update_pageblock_skip() is > likely to be called and update the cached pfn's to those being processed. > Another chance for a successful reset is when a direct compaction detects that > migration and free scanners meet (which has its own problems addressed by > another patch) and sets update_pageblock_skip flag which kswapd uses to do the > reset because it goes to sleep. > > This is clearly a bug that results in non-deterministic behavior, so this patch > moves the cached pfn reset to be performed *before* the values are read. > > Cc: Mel Gorman > Cc: Rik van Riel > Signed-off-by: Vlastimil Babka Acked-by: Rik van Riel -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org