From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15E6AC433F5 for ; Tue, 16 Nov 2021 23:38:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 803C661B95 for ; Tue, 16 Nov 2021 23:38:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 803C661B95 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BA2B66B0071; Tue, 16 Nov 2021 18:38:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B51C46B0072; Tue, 16 Nov 2021 18:38:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A184F6B0073; Tue, 16 Nov 2021 18:38:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 92D696B0071 for ; Tue, 16 Nov 2021 18:38:12 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 58A95182B0300 for ; Tue, 16 Nov 2021 23:38:02 +0000 (UTC) X-FDA: 78816408804.11.5A870F7 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf02.hostedemail.com (Postfix) with ESMTP id 27FF57001A0A for ; Tue, 16 Nov 2021 23:38:01 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0B00A212C4; Tue, 16 Nov 2021 23:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1637105880; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B5bLQ6GbPOxbu8UfgtnzISb6N4GArkk8FZZtgzRR1Pw=; b=o+YYhc6IVrXBbJ5AzfTt2aG4U97QfhFhVLZulFKrbPXXHJDAwn5ED25sersT1yfZtEhqhD /CcE1TbiYUJSCYdxyvpCY6ZyDOvvankpDn3Q0gcXAZemANM7tjTz0T+BOQ2zDEq5nndIZ7 9PsgaVR+tisqkhLz7B+WNHiQvv273Os= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1637105880; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B5bLQ6GbPOxbu8UfgtnzISb6N4GArkk8FZZtgzRR1Pw=; b=apY56TBrKIjgpu73fWg2YklYy+VgPdFETTCb9k12WeKOuvsIUvcRMZaWqrSFXvLqBF0b07 4mp0aXzxmPtloICw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0A7D413C6A; Tue, 16 Nov 2021 23:37:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id U6uhFNZAlGFURQAAMHmgww (envelope-from ); Tue, 16 Nov 2021 23:37:58 +0000 Message-ID: <52923dbf-82f7-8e0d-dc82-cbead3a526d7@suse.cz> Date: Wed, 17 Nov 2021 00:37:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [RFC PATCH 21/32] mm: Convert struct page to struct slab in functions used by other subsystems Content-Language: en-US To: Andrey Konovalov Cc: Matthew Wilcox , Linux Memory Management List , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Julia Lawall , Luis Chamberlain , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Marco Elver , Johannes Weiner , Michal Hocko , Vladimir Davydov , kasan-dev , cgroups@vger.kernel.org References: <20211116001628.24216-1-vbabka@suse.cz> <20211116001628.24216-22-vbabka@suse.cz> <6866ad09-f765-0e8b-4821-8dbdc6d0f24e@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 27FF57001A0A X-Stat-Signature: 4t71qrrmbu8bftirytcq3kmi99cp9mzc Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=o+YYhc6I; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=apY56TBr; dmarc=none; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-HE-Tag: 1637105881-781681 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/17/2021 12:04 AM, Andrey Konovalov wrote: > On Tue, Nov 16, 2021 at 5:33 PM Vlastimil Babka wrote: >> >> On 11/16/21 15:02, Andrey Konovalov wrote: >>>> --- a/mm/kasan/report.c >>>> +++ b/mm/kasan/report.c >>>> @@ -249,7 +249,7 @@ static void print_address_description(void *addr, u8 tag) >>>> >>>> if (page && PageSlab(page)) { >>>> struct kmem_cache *cache = page->slab_cache; >>>> - void *object = nearest_obj(cache, page, addr); >>>> + void *object = nearest_obj(cache, page_slab(page), addr); >>> >>> The tab before addr should be a space. checkpatch should probably report this. >> >> Good catch, thanks. Note the tab is there already before this patch, it just >> happened to appear identical to a single space before. > > Ah, indeed. Free free to keep this as is to not pollute the patch. Thanks! I will fix it up in patch 24/32 so that this one can stay purely autogenerated and there's no extra pre-patch.