From: Dave Hansen <dave@sr71.net>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
dave.jiang@intel.com, akpm@linux-foundation.org,
dhillf@gmail.com, Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] mm: call cond_resched() per MAX_ORDER_NR_PAGES pages copy
Date: Mon, 18 Nov 2013 14:29:24 -0800 [thread overview]
Message-ID: <528A94C4.80101@sr71.net> (raw)
In-Reply-To: <1384811778-7euptzgp-mutt-n-horiguchi@ah.jp.nec.com>
On 11/18/2013 01:56 PM, Naoya Horiguchi wrote:
>> > Why bother trying to "optimize" it?
> I thought that if we call cond_resched() too often, the copying thread can
> take too long in a heavy load system, because the copying thread always
> yields the CPU in every loop.
I think you're confusing cond_resched() and yield(). The way I look at it:
yield() means: "Hey scheduler, go right now and run something else I'm
done running"
cond_resched() means: "Schedule me off if the scheduler has already
decided something else _should_ be running"
I'm sure I'm missing some of the subtleties, but as I see it, yield()
actively goes off and finds something else to run. cond_resched() only
schedules you off if you've *already* run too long.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-11-18 22:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 22:55 [v3][PATCH 0/2] v3: fix hugetlb vs. anon-thp copy page Dave Hansen
2013-11-15 22:55 ` [v3][PATCH 1/2] mm: hugetlbfs: Add VM_BUG_ON()s to catch non-hugetlbfs pages Dave Hansen
2013-11-15 22:55 ` [v3][PATCH 2/2] mm: thp: give transparent hugepage code a separate copy_page Dave Hansen
2013-11-18 10:32 ` Mel Gorman
2013-11-18 18:51 ` [v3][PATCH 2/2] mm: thp: give transparent hugepage code aseparate copy_page Naoya Horiguchi
2013-11-18 18:54 ` [PATCH] mm: call cond_resched() per MAX_ORDER_NR_PAGES pages copy Naoya Horiguchi
2013-11-18 19:02 ` Dave Hansen
2013-11-18 20:20 ` Naoya Horiguchi
2013-11-18 20:48 ` Dave Hansen
2013-11-18 21:56 ` Naoya Horiguchi
2013-11-18 22:29 ` Dave Hansen [this message]
2013-11-19 0:34 ` Naoya Horiguchi
2013-11-18 19:23 ` [v3][PATCH 0/2] v3: fix hugetlb vs. anon-thp copy page Jiang, Dave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528A94C4.80101@sr71.net \
--to=dave@sr71.net \
--cc=akpm@linux-foundation.org \
--cc=dave.jiang@intel.com \
--cc=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox