Re: Breakout struct page

["Martin J. Bligh" <mbligh@aracnet.com>]

> On Sat, Oct 05, 2002 at 12:18:23AM -0700, Martin J. Bligh wrote:
>> This very boring patch breaks out struct page into it's own header
>> file. This should allow you to do struct page arithmetic in other
>> header files using static inlines instead of horribly complex macros 
>> ... by just including <linux/struct_page.h>, which avoids dependency
>> problems.
>> 
>> (inlined to read, attatched for lower probability of mangling)
> 
> I don't like a struct_page.h in addition to page-flags.h.  I had a patch
> for early 2.5 that create <linux/page.h> with struct page and stuff that
> depends only on it (Test/Set/etc macros).  IHMO that's a nicer split,
> but people may flame me for this..

I really don't care how it breaks out, as long as I can get something that
uses inlines rather than macros ... at least 4 people have run into problems
with this, and it's just getting worse.

> I'm inclinde to resubmit that one after feature freeze.

Yeah, I got my hand slapped (correctly ;-)) for that one already ;-) 
Definitely a post-freeze thingy.

M.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/