From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 444EEC25B75 for ; Tue, 4 Jun 2024 02:09:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2DB86B0093; Mon, 3 Jun 2024 22:09:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADE0D6B00A3; Mon, 3 Jun 2024 22:09:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CCD86B00A4; Mon, 3 Jun 2024 22:09:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7E2666B0093 for ; Mon, 3 Jun 2024 22:09:46 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 378401C029E for ; Tue, 4 Jun 2024 02:09:46 +0000 (UTC) X-FDA: 82191575172.22.3DF3D7B Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf09.hostedemail.com (Postfix) with ESMTP id 21504140003 for ; Tue, 4 Jun 2024 02:09:43 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf09.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717466984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4viyx+5/MhDrBhC21NpZ0riI/T+dQ13EIY/JJGG63RA=; b=Y6Th1WVmcHmPUs0dzlV20dtnhGJc3HGes7e5dEw3b8EuZBjg90z0ThziqJH4VhGx2eRPse 42CKgSQ9qmzo8paDrsmWzLunCvxqxDbyWSeKEiXJIBs75ykNqKLotyHpkfiJFG/YsZK6va YvyMoSHRaBKS/wQwrSA9MPoFOOj1DqU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf09.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717466984; a=rsa-sha256; cv=none; b=ii2RC+pLUZPtOR+CK3i5ZAvWK8Ug3CGu61OMih836s0A1FFSuANKYT8EF+UwglYE9t4w0E PVwuYsFU57E6DymGX4WoPhOI8Qpp0jUkklggb7fdEVo05em3YUPFtyTBGJCtWlIbLZzHS0 6uLviJhsypRHaJnqLnBgwFMg1CVJdIg= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 627C81042; Mon, 3 Jun 2024 19:10:07 -0700 (PDT) Received: from [10.162.40.15] (a077893.blr.arm.com [10.162.40.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8A6B63F792; Mon, 3 Jun 2024 19:09:41 -0700 (PDT) Message-ID: <52773c75-916a-42df-b60f-531770a3cc82@arm.com> Date: Tue, 4 Jun 2024 07:39:38 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: sparse: Consistently use _nr Content-Language: en-US To: Dev Jain , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240531124144.240399-1-dev.jain@arm.com> From: Anshuman Khandual In-Reply-To: <20240531124144.240399-1-dev.jain@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 21504140003 X-Stat-Signature: 6h8n7wdsj7u88jnyteb9gwq5gsx883j1 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717466983-935639 X-HE-Meta: U2FsdGVkX19wCl0XNZnwKPaP4axRxr2NSmfK4KZB2mZvIcWyEa8zW4fB53RHHGr2E0/kQUtlGYLd/fjMKmPdTY1Kn+dq2qCHVj/VTAGdPY3ibLXcnjrqgfMZar2YqOqN4TYax90qPvKKPnKH6IoZ6H/QuhPfYVYpV+UIwjGyilAE7Q7iz6g6gNm4rCIhe8GxTIjQkOREm2OHkVPEfeMBqXQTG/EgYjPRX5ebCM8z+0dQClCkU2r6tVigWO9Q742NJiahMj91h3EN7968hUi3RyFBmsj+dumvFs3iUIbRoX2YK24+Q0+14R31GZvEd3aGkQXMOvIcSKkqa5Hvj4CMsmMhuw5Nc06Uy/quh/O2kngDMTuFPGNql7tmuJgwjL3G99EhDfvpVYj1lZEByJf3wYV5FGkfI5SnJIgGEih0ZtBbmWyRUfmH3ZWmt7VwjjqD7yBrTpl/hH8O72WmjDXpyJX/gbJ9++U9q6K0eHflrGqP9dn+0nisCDBDwqnnVhjGpJR/RB3wv+fRXfnj1KN7SONFeYgT319WWfltKxoz1BdBAm55u3+G5ThjTuMwJtT2Rr9/3Y+D6IX16CN9g9s5EAzw7GW2JhSbtCRe5v82QKhbCmphnyj1lx8GFnw4fa6y1Z7lo8tIKNTfvfDndtoLUaLeLfPiLVznhRQYUS99No3eZLOnbZsbACTcbbaNdUQwP+ZGNW+LNRgjy+eMuDYzgtlhi585TpO7vsAsNt1wuw3yKRV4ProMgLHmEuQ6a7p9wv0Bro8kNwRGG8+kd+MuWhhe2MP/CBHIWZZTvPmeXkesQPlgMWha2uR7pr/YqOZtsrL7JoabEdA6qC0KBxx1wxPPD8tNX2LejQieKiSK7qysSxKmbez/adKxx1ceFPfNwKQacgiB2bWc1O2HCY29eC8k0uXcc0y6qWoYvR2JS1pXX7nowZbmWSX0E65SmoYKcOGU6QBSwybb1y9etuj dPRr1vnq Vbl7/kQeSHbjMUGO9tHa5Gvpq3kq+PAAukYRiN6UnJxxDuvqc+359t20GNE3TBaQMBQqb9QF3r+ZXNNj6xzOx6/qcidARe9GzXmKkMYKteJM+k/0QUuusZM1BCD3fV6gLpeGXDLqWsUiK7SorIoz2783z2UMEl4xnXZy04HPImIVnrwIm4/mBYqt/gqlu/PD1SYjFTVLI8ATYx5Z/wYwB2LbGl9zEITjGLwgyKUdLHtp8IoAOIeL0XxTgdJJ5Hyg+DDAkAF1MGis8fvnjqOM15Jc4Gum8WscKj9AUntDPwwwxcU3ovWZ7QfKZHNIyphqQJUZhBbecZuulReU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/31/24 18:11, Dev Jain wrote: > Consistenly name the return variable with an _nr suffix, whenever calling > pfn_to_section_nr(), to avoid confusion with a (struct mem_section *). > > Signed-off-by: Dev Jain Reviewed-by: Anshuman Khandual > --- > mm/sparse.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index de40b2c73406..731f781e91b6 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -192,13 +192,13 @@ static void subsection_mask_set(unsigned long *map, unsigned long pfn, > > void __init subsection_map_init(unsigned long pfn, unsigned long nr_pages) > { > - int end_sec = pfn_to_section_nr(pfn + nr_pages - 1); > - unsigned long nr, start_sec = pfn_to_section_nr(pfn); > + int end_sec_nr = pfn_to_section_nr(pfn + nr_pages - 1); > + unsigned long nr, start_sec_nr = pfn_to_section_nr(pfn); > > if (!nr_pages) > return; > > - for (nr = start_sec; nr <= end_sec; nr++) { > + for (nr = start_sec_nr; nr <= end_sec_nr; nr++) { > struct mem_section *ms; > unsigned long pfns; > > @@ -229,17 +229,17 @@ static void __init memory_present(int nid, unsigned long start, unsigned long en > start &= PAGE_SECTION_MASK; > mminit_validate_memmodel_limits(&start, &end); > for (pfn = start; pfn < end; pfn += PAGES_PER_SECTION) { > - unsigned long section = pfn_to_section_nr(pfn); > + unsigned long section_nr = pfn_to_section_nr(pfn); > struct mem_section *ms; > > - sparse_index_init(section, nid); > - set_section_nid(section, nid); > + sparse_index_init(section_nr, nid); > + set_section_nid(section_nr, nid); > > - ms = __nr_to_section(section); > + ms = __nr_to_section(section_nr); > if (!ms->section_mem_map) { > ms->section_mem_map = sparse_encode_early_nid(nid) | > SECTION_IS_ONLINE; > - __section_mark_present(ms, section); > + __section_mark_present(ms, section_nr); > } > } > }